Re: [PATCHES] [DOCS] maintenance diff

2006-07-14 Thread Peter Eisentraut
Joshua D. Drake wrote: > Updated to have stronger wording for vacuuming. Cleaned out some > extra superlatives. Added a couple of index entries for Routine > Maintenance and added entry specific to Analyze. diff -c please. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---

Re: [PATCHES] [DOCS] maintenance diff

2006-07-14 Thread Robert Treat
On Thursday 13 July 2006 20:58, Joshua D. Drake wrote: > Hello, > > Updated to have stronger wording for vacuuming. Cleaned out some extra > superlatives. Added a couple of index entries for Routine Maintenance > and added entry specific to Analyze. I noticed a number of typos in this... s/Gbord

Re: [PATCHES] include compile problems

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Patch applied. Thanks. > > I suspect the point was that limits.h is needed *instead of* math.h, > not *in addition to*. How many of those headers had math.h before? The issue was that an include file included another include file t

Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
"Charles Duffy" <[EMAIL PROTECTED]> writes: > On 7/12/06, Qingqing Zhou <[EMAIL PROTECTED]> wrote: >> the problem here is that 29247 doesn't look like a big number so I can't see >> why your patch solved the problem, unless the qsort_comparetup() function of >> the data type eats too many circles o

Re: [PATCHES] [DOCS] maintenance diff

2006-07-14 Thread Joshua D. Drake
Peter Eisentraut wrote: Joshua D. Drake wrote: Updated to have stronger wording for vacuuming. Cleaned out some extra superlatives. Added a couple of index entries for Routine Maintenance and added entry specific to Analyze. diff -c please. I have been properly chastised by Neil too. I will

Re: [PATCHES] [DOCS] maintenance diff

2006-07-14 Thread Joshua D. Drake
Robert Treat wrote: On Thursday 13 July 2006 20:58, Joshua D. Drake wrote: Hello, Updated to have stronger wording for vacuuming. Cleaned out some extra superlatives. Added a couple of index entries for Routine Maintenance and added entry specific to Analyze. I noticed a number of typos in th

Re: [PATCHES] [patch 0/9] annual pgcrypto update

2006-07-14 Thread Marko Kreen
On 7/13/06, Neil Conway <[EMAIL PROTECTED]> wrote: Marko, can you take a look at what is causing this regression test failure? The failing machine is kudu: Seems you have skipped the CAST5 patch. Could you recheck? -- marko ---(end of broadcast)---

[PATCHES] build with different options than Bruce

2006-07-14 Thread Kris Jurka
When building with --enable-cassert, without --enable-thread-safety, or when the OS supports USE_WIDE_UPPER_LOWER we need some more include files. Kris JurkaIndex: src/backend/storage/buffer/buf_table.c === RCS file: /projects/cvs

[PATCHES] c.h is the problem of msvc.

2006-07-14 Thread Hiroshi Saito
Hi Bruce-san. Umm, c.h is the problem of msvc. getaddrinfo.c ..\..\include\c.h(63) : fatal error C1083: 'crtdefs.h': No such file or directory does not exist in vs2003... problem is solved by removing this before vs2005. moreover, nothing does not run short by it. Regards, Hiroshi Saito

Re: [PATCHES] pgstattuple extension for indexes

2006-07-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Patch applied. Thanks. >> Also, I added an experimental feature for btree indexes. It checks >> fragmentation factor of indexes. If an leaf has the right link on the next >> adjacent page in the file, it is assumed to be continuous (not fragmented). >>

[PATCHES] toast index entries again

2006-07-14 Thread Kris Jurka
The inclusion of access/tuptoaster.h in access/common/indextuple.c brought in the define of TOAST_INDEX_HACK which compresses large index entries. When this was removed the entries were no longer compressed which caused btree_gist to fail. Kris JurkaIndex: src/backend/access/common/indextupl

[PATCHES] Maintenance and External Projects (try 2)

2006-07-14 Thread Joshua D. Drake
Hello, I did further work on both of these. Cleaned up some stupid spelling and typos (forgot an s here, a y there ;)). The commit log doesn't change from previous except that I added a reference to Sourceforge for external projects, and I specified that there are three required routing main

Re: [PATCHES] build with different options than Bruce

2006-07-14 Thread Tom Lane
Kris Jurka <[EMAIL PROTECTED]> writes: > When building with --enable-cassert, without --enable-thread-safety, or > when the OS supports USE_WIDE_UPPER_LOWER we need some more include files. Done, thanks. regards, tom lane ---(end of broadcast)

Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
"Charles Duffy" <[EMAIL PROTECTED]> writes: > [ CHECK_FOR_INTERRUPTS inside qsort comparison routine ] It occurs to me that there's a nonzero risk of problems here, because if the interrupt occurs qsort() will lose control. I'm wondering whether there are any implementations of qsort() that alloc

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Peter Eisentraut
Tom Lane wrote: > We might have to just tolerate this, but if it occurs on a lot of > platforms I'd have second thoughts about applying the patch. Anyone > familiar with the internals of glibc's qsort, in particular? Doesn't look like it's allocating any nonlocal memory: http://sourceware.org/cg

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> We might have to just tolerate this, but if it occurs on a lot of >> platforms I'd have second thoughts about applying the patch. Anyone >> familiar with the internals of glibc's qsort, in particular? > Doesn't look like it's alloc

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Peter Eisentraut
Tom Lane wrote: > > Doesn't look like it's allocating any nonlocal memory: > > > > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/qsort.c?rev=1. > >12&content-type=text/x-cvsweb-markup&cvsroot=glibc > > But this file defines _quicksort() not qsort(). I was under the > impression that the lat

Re: [PATCHES] [DOCS] Maintenance and External Projects (try 2)

2006-07-14 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > Please let me know if there is anything else you would like me to do or add. A round of copy-editing seems indicated, at least. regards, tom lane ---(end of broadcast)--- TIP 4

Re: [PATCHES] [DOCS] Maintenance and External Projects (try 2)

2006-07-14 Thread Joshua D. Drake
Tom Lane wrote: "Joshua D. Drake" <[EMAIL PROTECTED]> writes: Please let me know if there is anything else you would like me to do or add. A round of copy-editing seems indicated, at least. Oh, no doubt. I tried to fix as much as I find, including a bunch of stuff already there. However, I

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > The merge sort is here: > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/msort.c?rev=1.21&content-type=text/x-cvsweb-markup&cvsroot=glibc > It uses alloca, so we're good here. Uh ... but it also uses malloc, and potentially a honkin' big mallo

Re: [PATCHES] [DOCS] Maintenance and External Projects (try 2)

2006-07-14 Thread Robert Treat
On Friday 14 July 2006 15:23, Joshua D. Drake wrote: > Tom Lane wrote: > > "Joshua D. Drake" <[EMAIL PROTECTED]> writes: > >> Please let me know if there is anything else you would like me to do or > >> add. > > > > A round of copy-editing seems indicated, at least. > > Oh, no doubt. I tried to fix