[PATCHES] contrib/otherlock

2006-09-04 Thread Abhijit Menon-Sen
Someone (David Fetter?) mentioned long ago that contrib/userlock could not be moved into core because it is GPLed, and the author couldn't be contacted to ask about re-licensing. Andrew(@supernews) wrote a specification for the userlock functionality, and I implemented the attached code based on

[PATCHES] Documentation fix for --with-ldap

2006-09-04 Thread Albe Laurenz
This is just a 'one line' change in the documentation of the --with-ldap flag of ./configure Yours, Laurenz Albe ldapdoc.patch Description: ldapdoc.patch ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Michael Meskes
On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote: When I tried the ecpg regression tests it complained there was no results/ directory. I created one and it worked. Hmm, anyone else experiencing this? The pg_regress.sh has this code that should create it: outputdir=results/ if [

Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Tom Lane
Michael Meskes [EMAIL PROTECTED] writes: On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote: When I tried the ecpg regression tests it complained there was no results/ directory. I created one and it worked. Hmm, anyone else experiencing this? The pg_regress.sh has this code that

[PATCHES] Fix PGPORT reassignment in ecpg regression tests

2006-09-04 Thread Michael Glaesemann
The pg_regress.sh script for ecpg regression tests checks to make sure the port number is between 1024 and 65535. If it isn't, it uses 65432. (c310-315. This is the same behavior as the standard regression tests, I believe.) However, it if does reassign the port number, it was changing it

Re: [PATCHES] Backend SSL configuration enhancement

2006-09-04 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: This has been saved for the 8.3 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold This version was withdrawn by the author for rework, no? regards, tom lane ---(end of

[PATCHES] setseed() doc

2006-09-04 Thread Dennis Bjorklund
The doc doesn't state in what range the argument to setseed() should be. Some tests suggest that only values in the range -1.0 to 1.0 work as a seed and values outside of that give the same sequence of random numbers. I've attached a trivial one line patch (this is the patch list after all),

Re: [PATCHES] setseed() doc

2006-09-04 Thread Dennis Bjorklund
Tom Lane skrev: entryliteralfunctionsetseed/function(typedp/type)/literal/entry entrytypeint/type/entry - entryset seed for subsequent literalrandom()/literal calls/entry + entryset seed for subsequent literalrandom()/literal calls (value between -1.0 and

Re: [PATCHES] setseed() doc

2006-09-04 Thread Tom Lane
Dennis Bjorklund [EMAIL PROTECTED] writes: entryliteralfunctionsetseed/function(typedp/type)/literal/entry entrytypeint/type/entry - entryset seed for subsequent literalrandom()/literal calls/entry + entryset seed for subsequent literalrandom()/literal calls

Re: [PATCHES] setseed() doc

2006-09-04 Thread Tom Lane
Dennis Bjorklund [EMAIL PROTECTED] writes: What about the return value? The doc didn't say anything about it. AFAICT it's just junk. It happens to be the input times MAX_RANDOM_VALUE, but what use is that? I wonder if we shouldn't change the function to return VOID ... that option wasn't

Re: [PATCHES] Have psql show current sequnce values - (Resubmission)

2006-09-04 Thread Tom Lane
Dhanaraj M [EMAIL PROTECTED] writes: Sorry for resubmitting this patch. Just now I found a problem. Instead of assigning initial sequence value to 1, I assign LLONG_MAX to avoid the buffer overflow problem. Please find the current version here. This patch is a mess. In the first place, it's

Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Bruce Momjian
Tom Lane wrote: Michael Meskes [EMAIL PROTECTED] writes: On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote: When I tried the ecpg regression tests it complained there was no results/ directory. I created one and it worked. Hmm, anyone else experiencing this? The

Re: [PATCHES] [HACKERS] Fix linking of OpenLDAP libraries

2006-09-04 Thread Tom Lane
Albe Laurenz [EMAIL PROTECTED] writes: # The backend doesn't need everything that's in LIBS, however ! LIBS := $(filter-out -lz -lreadline -ledit -ltermcap -lncurses -lcurses -lldap_r $(PTHREAD_LIBS), $(LIBS)) This seems pretty risky. What if PTHREAD_LIBS contains -L switches? They'd get

Re: [PATCHES] Backend SSL configuration enhancement

2006-09-04 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: This has been saved for the 8.3 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold This version was withdrawn by the author for rework, no? Right, and the thread in patches_hold shows that. The reason it is in there

Re: [PATCHES] Partial Index wording as per BUG

2006-09-04 Thread Bruce Momjian
Patch applied. Thanks. parameterised changed to parameterized, for consistency with existing documentation. (Yea, I know they are both correct.) --- Simon Riggs wrote: Doc patch in response to bug raised:

Re: [PATCHES] Information_schema fixes for sequences and

2006-09-04 Thread Bruce Momjian
Patch applied. Thanks. I did not batckpatch because someone would need to re-initdb to see the changes, and we haven't gotten any complaints about the bug. --- Greg Sabino Mullane wrote: -- Start of PGP signed section.

Re: [PATCHES] Information schema - finalize key_column_usage

2006-09-04 Thread Bruce Momjian
This patch fails in initdb with: creating information schema ... FATAL: column ss.confrelid does not exist at character 30245 Please fix and resubmit soon. --- Greg Sabino Mullane wrote: -- Start of PGP signed

Re: [PATCHES] Have psql show current sequnce values -

2006-09-04 Thread Bruce Momjian
Due to Tom's feedback: This has been saved for the 8.3 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Dhanaraj M wrote: Sorry for resubmitting this patch. Just now I found a problem.

Re: [PATCHES] [HACKERS] Unable to post to -patches (was: Visual C++

2006-09-04 Thread Bruce Momjian
Patch applied. Placed in src/tools/msvc. Thanks. --- Magnus Hagander wrote: a.hub.org[200.46.208.251], delay=1, status=sent (250 2.7.1 Ok, discarded, id=258 35-09 - BANNED: P=p003,L=1,M=multipart/mixed |

Re: [PATCHES] plpgsql, return can contains any expression

2006-09-04 Thread Bruce Momjian
I am going to need this in 24 hours or it might not make it into 8.2. --- bruce wrote: While this patch has new regression tests, it doesn't have new expected output for it. Please update the patch to supply that.

Re: [HACKERS] [PATCHES] Trivial patch to double vacuum speed

2006-09-04 Thread Bruce Momjian
Patch applied. Thanks. --- Gregory Stark wrote: Tom Lane [EMAIL PROTECTED] writes: The reason the patch is so short is that it's a kluge. If we really cared about supporting this case, more wide-ranging changes

Re: [HACKERS] [PATCHES] Trivial patch to double vacuum speed on tables with no indexes

2006-09-04 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. Wait a minute. This patch changes the behavior so that LockBufferForCleanup is applied to *every* heap page, not only the ones where there are removable tuples. It's not hard to imagine scenarios where that results in severe

Re: [HACKERS] [PATCHES] Trivial patch to double vacuum speed

2006-09-04 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. Wait a minute. This patch changes the behavior so that LockBufferForCleanup is applied to *every* heap page, not only the ones where there are removable tuples. It's not hard to imagine scenarios where that

Re: [PATCHES] setseed() doc

2006-09-04 Thread Bruce Momjian
Tom Lane wrote: Dennis Bjorklund [EMAIL PROTECTED] writes: entryliteralfunctionsetseed/function(typedp/type)/literal/entry entrytypeint/type/entry - entryset seed for subsequent literalrandom()/literal calls/entry + entryset seed for subsequent

Re: [HACKERS] [PATCHES] Trivial patch to double vacuum speed on tables with no indexes

2006-09-04 Thread Gregory Stark
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. Wait a minute. This patch changes the behavior so that LockBufferForCleanup is applied to *every* heap page, not only the ones where there are removable tuples.

Re: [PATCHES] Information schema - finalize key_column_usage

2006-09-04 Thread Greg Sabino Mullane
Please fix and resubmit soon. Attached version should now work properly. -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200609041803 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 Index: information_schema.sql

Re: [PATCHES] plpgsql, return can contains any expression

2006-09-04 Thread Tom Lane
Pavel Stehule [EMAIL PROTECTED] writes: This patch allows using any row expression in return statement and does transformation from untyped row to composite types if it's necessary. This patch doesn't seem to cope with cases where the supplied tuple has the wrong number of columns, and it

Re: [PATCHES] Information schema - finalize key_column_usage

2006-09-04 Thread Tom Lane
Greg Sabino Mullane [EMAIL PROTECTED] writes: Attached version should now work properly. Applied, thanks. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives?

Re: [HACKERS] [PATCHES] DOC: catalog.sgml

2006-09-04 Thread Jim C. Nasby
On Sun, Sep 03, 2006 at 12:01:06AM -0400, Tom Lane wrote: But ever since 7.3 the convention for identifying system objects has been pretty well-defined: anything that lives in one of the predefined schemas. What problem were you having using that approach in newsysviews? It was just an issue

Re: [PATCHES] contrib/otherlock

2006-09-04 Thread Bruce Momjian
This has been saved for the 8.3 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Abhijit Menon-Sen wrote: Someone (David Fetter?) mentioned long ago that contrib/userlock could not be moved into

Re: [PATCHES] [HACKERS] Interval aggregate regression failure

2006-09-04 Thread Bruce Momjian
Bruce Momjian wrote: OK, updated patch. It will fix the =24:00:00 case because it cascades up if the remainder number of seconds is greater or equal to one day. One open item is that it still might show 24 hours if the seconds computation combined with the remaning seconds 24 hours. Not

[PATCHES] XML syntax patch

2006-09-04 Thread Bruce Momjian
I have received an update XML syntax patch from Nikolay (summer of code) based on David Fetter's patch from 2005. Comments? It would be nice to have for 8.2. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be