Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-04-13 Thread Brendan Jurd
On Tue, Mar 25, 2008 at 2:41 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > This makes me wonder whether print.c could offer something a bit more > > helpful to callers wishing to DIY a table; we could have a > > table-building struct with methods like a

Re: [PATCHES] libpq patch for pqtypes hook api and PGresult creation

2008-04-13 Thread Andrew Chernow
Kind of a long post, but if you take the time to read it we think it accurately clarifies how we interrupt the current objections and how we see this working. NOTE: any references to overhead are in regards to library size, not performance. >would be to insert hooks at library >_init() time, me

Re: [PATCHES] [HACKERS] Terminating a backend

2008-04-13 Thread Bruce Momjian
Bruce Momjian wrote: > > > When we get the termination signal, why can't we just set a global > > > boolean, do a query cancel, and in the setjmp() code block check the > > > global and exit --- at that stage we know we have released all locks and > > > can exit cleanly. > > > > I have implemented

Re: [PATCHES] datum passed to macro which expects a pointer

2008-04-13 Thread Gavin Sherry
Hi all, Attached are more fixes. Thanks, Gavin, with Feng Tian Index: src/backend/access/common/heaptuple.c === RCS file: /Users/swm/pgsql-cvs/pgsql/src/backend/access/common/heaptuple.c,v retrieving revision 1.120 diff -c -p -r1.12

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-04-13 Thread Alvaro Herrera
Brendan Jurd escribió: > I'd like to submit my first version of this patch for review. I have > introduced a new struct in print.h called printTableContent, which is > used to compose the contents of a psql table. The methods exposed for > this struct are as follows: Looks cool -- on a first re

Re: [PATCHES] [HACKERS] Terminating a backend

2008-04-13 Thread Alvaro Herrera
Bruce Momjian wrote: > I have a idea --- to have pg_terminate_backend() set a PGPROC boolean > and then send a query cancel signal to the backend --- the backend can > then check the boolean and exit if required. I will work on a new > version of this patch tomorrow/Monday. That's fine, even if

Re: [PATCHES] [HACKERS] Remove lossy-operator RECHECK flag?

2008-04-13 Thread Tom Lane
I wrote: > I've committed changes that move the determination of whether recheck is > required into the index AMs. Right now, GIST and GIN just always set > the recheck flag to TRUE. Obviously that control should be pushed down > to the opclass consistent() functions, but I don't know that code w

Re: [PATCHES] Reference by output in : \d

2008-04-13 Thread kenneth d'souza
Hi Brendan, Your observation is correct. The indentation is deliberate. The reason is that the (result7,i,3) starts with the word "FOREIGN KEY ". I am using the details that follow after this blurb. All other keywords which are searched in usingpos = strstr(indexdef, " KEYWORD ") , the KEYWO