Re: [PATCHES] libpq Win32 Mutex performance patch

2008-04-15 Thread Magnus Hagander
Andrew Chernow wrote: > Magnus Hagander wrote: > > >It changes the behavior when the pointer passed in is invalid from > >crash to silent working, right? > > Correct, it a Habit. I sub-consciously write code that checks > pointers. We can remove the pointer checks and let the thing dump > core

Re: [PATCHES] libpq Win32 Mutex performance patch

2008-04-15 Thread Magnus Hagander
Andrew Chernow wrote: > Tom Lane wrote: > > Andrew Chernow <[EMAIL PROTECTED]> writes: > >> The attached patch replaces the win32 mutex calls with critical > >> section calls. The change will not affect the behavior of the > >> windows pthread_xxx functions. > > > > Why have you defined the lock/

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, Apr 13, 2008 at 6:11 PM, Brendan Jurd wrote: > I've written a patch which implements the same \du behaviour as my > previous patch, but using the new printTable API New versions of this patch, including changes made to the printTable API in

Re: [PATCHES] [HACKERS] printTable API (was: Show INHERIT in \du)

2008-04-15 Thread Martijn van Oosterhout
On Tue, Apr 15, 2008 at 06:11:32PM +1000, Brendan Jurd wrote: > Now my question is, how do I indicate that a second version of the > patch has been submitted on the wiki? Should I leave the primary link > pointing at the original submission, or update it to point at this > message? I'd say add a

Re: [PATCHES] libpq Win32 Mutex performance patch

2008-04-15 Thread Magnus Hagander
Merlin Moncure wrote: > On Fri, Apr 11, 2008 at 2:49 PM, Magnus Hagander > <[EMAIL PROTECTED]> wrote: > > Andrew Chernow wrote: > > > I noticed several months ago, and came across it again today, > > > that libpq's pthread-win32.c implementation is using CreateMutex > > > rather than CRITICAL_SE

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, Apr 14, 2008 at 6:03 AM, Alvaro Herrera wrote: > Looks cool -- on a first read, I think you should add some more code > comments at the top of each function specifying whether the texts need > to be translated by the caller or done by the f

[PATCHES] Sorting writes during checkpoint

2008-04-15 Thread ITAGAKI Takahiro
Here is a patch for TODO item, "Consider sorting writes during checkpoint". It writes dirty buffers in the order of block number during checkpoint so that buffers are written sequentially. I proposed the patch before, but it was rejected because 8.3 feature has been frozen already at that time. ht

Re: [PATCHES] Sorting writes during checkpoint

2008-04-15 Thread Greg Smith
On Tue, 15 Apr 2008, ITAGAKI Takahiro wrote: 2x Quad core Xeon, 16GB RAM, 4x HDD (RAID-0) What is the disk controller in this system? I'm specifically curious about what write cache was involved, so I can get a better feel for the hardware your results came from. I'm busy rebuilding my pe

Re: [PATCHES] [HACKERS] MSVC build broken with perl 5.10

2008-04-15 Thread Zeugswetter Andreas OSB SD
Magnus Hagander wrote: > I just tried the MSVC build on a system with ActiveState Perl 5.10, and > it doesn't work. Some quick debugging before I downgraded to 5.8 showed > that this regexp in Project.pm line 262: > my $replace_re = qr{^([^:\n\$]+\.c)\s*:\s*(?:%\s*: )?\$(\([^\)]+\))\/(.*)\/[^\

Re: [PATCHES] Terminating a backend

2008-04-15 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: > oikBruce Momjian wrote: > > Bruce Momjian wrote: > > > > > When we get the termination signal, why can't we just set a global > > > > > boolean, do a query cancel, and in the setjmp() code

[PATCHES] PQmakeResult patch

2008-04-15 Thread Merlin Moncure
Here is a patch to add a few functions to libpq: PQmakeResult: creates a new result with attributes but no rows PQsetValue: set a field inside a result, creating a row if necessary (but only one at a time) PQresultAlloc (basically public wrapper to existing internal function). also, the attribute

Re: [PATCHES] lc_time and localized dates

2008-04-15 Thread Bruce Momjian
Euler Taveira de Oliveira wrote: > Tom Lane wrote: > > > But as Peter remarks nearby, this discussion is wasted anyway, because > > there is only one correct answer: whatever Oracle does with these > > cases is what to_char() should do. > > > My patch does exactly what Oracle does besides one thi

Re: [PATCHES] [HACKERS] MSVC build broken with perl 5.10

2008-04-15 Thread Andrew Dunstan
Zeugswetter Andreas OSB SD wrote: Magnus Hagander wrote: I just tried the MSVC build on a system with ActiveState Perl 5.10, and it doesn't work. Some quick debugging before I downgraded to 5.8 showed that this regexp in Project.pm line 262: my $replace_re = qr{^([^:

Re: [PATCHES] Partial match in GIN (next vesrion)

2008-04-15 Thread Teodor Sigaev
http://www.sigaev.ru/misc/partial_match_gin-0.8.gz Reworked interface as it suggested by Gregory (http://archives.postgresql.org/pgsql-patches/2008-04/msg00199.php) and move check of index into expand_indexqual_opclause() as suggested by Heikki (http://archives.postgresql.org/pgsql-patches/2008

[PATCHES] libpq object hooks patch

2008-04-15 Thread Andrew Chernow
Here is an updated version of the object hooks patch. It now supports a list of hooks for a PGconn, and PGresult. This had to re-introduce the concept of hook name. Being that there is now a list, you need a way to reference an item of that list. Also added PQobjectHooks and PQresultObjectH

Re: [PATCHES] lc_time and localized dates

2008-04-15 Thread Euler Taveira de Oliveira
Bruce Momjian wrote: Euler, have you updated this patch yet? I'm in a process to submit another patch but I want to test on Windows first. -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] libpq object hooks patch

2008-04-15 Thread Andrew Chernow
Andrew Chernow wrote: Here is an updated version of the object hooks patch. It now supports a list of hooks for a PGconn, and PGresult. This had to re-introduce the concept of hook name. Being that there is now a list, you need a way to reference an item of that list. Also added PQobjectHo

Re: [PATCHES] Sorting writes during checkpoint

2008-04-15 Thread ITAGAKI Takahiro
Greg Smith <[EMAIL PROTECTED]> wrote: > On Tue, 15 Apr 2008, ITAGAKI Takahiro wrote: > > > 2x Quad core Xeon, 16GB RAM, 4x HDD (RAID-0) > > What is the disk controller in this system? I'm specifically curious > about what write cache was involved, so I can get a better feel for the > hardwar

Re: [PATCHES] [HACKERS] Text <-> C string

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Mar 29, 2008 at 5:40 AM, Brendan Jurd wrote: > On 29/03/2008, Tom Lane wrote: > > I intentionally didn't touch xml.c, nor anyplace that is not dealing > > in text, even if it happens to be b