[PATCHES] Removing NONSEG mode

I attach patch which remove nonsegment mode support. It was discussed during last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS, XFS) and it is not safe on any OS because each OS support more filesystems. I added RELSEG option to the configure script to allow easily comp

Re: [PATCHES] Improve shutdown during online backup, take 3

Simon Riggs wrote: > Patch applies, and works as described. Looks good for final apply. > > Few minor thoughts: > > * Text in pg_ctl should be WARNING, not Warning. > * CancelBackup() API looks strange, not sure why > * Need to mention that CancelBackup() is not the right way to end a > backup, s

Re: [PATCHES] Removing NONSEG mode

Zdenek Kotala wrote: > I attach patch which remove nonsegment mode support. It was discussed during > last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS, > XFS) and it is not safe on any OS because each OS support more filesystems. Added to May commitfest, thanks. -- Al

Re: [PATCHES] Improve shutdown during online backup, take 3

Albe Laurenz wrote: > Simon Riggs wrote: > > Patch applies, and works as described. Looks good for final apply. > > > > Few minor thoughts: > > > > * Text in pg_ctl should be WARNING, not Warning. > > * CancelBackup() API looks strange, not sure why > > * Need to mention that CancelBackup() is no

Re: [PATCHES] Partial match in GIN (next vesrion)

http://www.sigaev.ru/misc/partial_match_gin-0.9.gz Sync with CVS. -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/ -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To ma

[PATCHES] Snapshot management, final

Here is the patch for snapshot management I currently have. Below is a complete description of the changes in this patch. The most important change is on the use of CopySnapshot and the games with ActiveSnapshot. On the new code, whenever a piece of code needs a snapshot to persist, it is "regis

Re: [PATCHES] Snapshot management, final

On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote: > - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on > copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c. > They are there because they grab the current ActiveSnapshot, modify it, > and then use the re

Re: [PATCHES] Snapshot management, final

Simon Riggs wrote: > On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote: > > > - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on > > copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c. > > They are there because they grab the current ActiveSnapshot, mod

Re: [PATCHES] Snapshot management, final

On Tue, 2008-04-22 at 17:50 -0400, Alvaro Herrera wrote: > Simon Riggs wrote: > > On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote: > > > > > - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on > > > copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c. >

Re: [PATCHES] Snapshot management, final

Simon Riggs wrote: > OK, so it can;t be copied to a longer lived memory context? CopySnapshot always copies snapshots to SnapshotContext, which is a context that lives until transaction end. There's no mechanism for copying a snapshot into another context, because I don't see the need. If you n

Re: [PATCHES] Snapshot management, final

Alvaro Herrera <[EMAIL PROTECTED]> writes: > Simon Riggs wrote: >> OK, so it can;t be copied to a longer lived memory context? > CopySnapshot always copies snapshots to SnapshotContext, which is a > context that lives until transaction end. There's no mechanism for > copying a snapshot into anoth

Re: [PATCHES] Snapshot management, final

Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > CopySnapshot always copies snapshots to SnapshotContext, which is a > > context that lives until transaction end. There's no mechanism for > > copying a snapshot into another context, because I don't see the need. > > The only re