[PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Greg Stark
As described on -hackers this is my work so far adding ADD/DROP INHERITS. It implements the controversial ALTER TABLE table ADD/DROP INHERITS parent syntax that requires making INHERITS a reserved keyword. I haven't seen a clear consensus yet on what the best syntax to use here would be. Also,

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Andrew Dunstan
Greg Stark wrote: As described on -hackers this is my work so far adding ADD/DROP INHERITS. It implements the controversial ALTER TABLE table ADD/DROP INHERITS parent syntax that requires making INHERITS a reserved keyword. I haven't seen a clear consensus yet on what the best syntax to use here

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: We should try very hard to avoid adding new reserved words, IMNSHO. *Especially* ones not sanctioned by the SQL spec. Reserving a word that is not listed as reserved in the standard is really a spec violation, because it means that spec-conforming SQL

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Andrew Dunstan [EMAIL PROTECTED] writes: We should try very hard to avoid adding new reserved words, IMNSHO. *Especially* ones not sanctioned by the SQL spec. Reserving a word that is not listed as reserved in the standard is really a spec violation,

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: I expected that but I haven't seen any agreement on a replacement syntax. The only other one proposed was: ALTER TABLE foo ALTER INHERITS ADD|DROP bar and it received no comments. Should I just assume that's the direction to go if nobody objects? I