Re: [PATCHES] Packed Varlena Update (v21)
Thanks, that was a distinction I didn't know. TODO updated: o Allow single-byte header storage for array elements --- Gregory Stark wrote: > > "Bruce Momjian" <[EMAIL PROTECTED]> writes: > > > Added to TODO: > > > > o Allow single-byte header storage for arrays > > Fwiw this is "single-byte header storage for varlena array *elements*" > > The arrays themselves already get the packed varlena treatment. > > -- > Gregory Stark > EnterpriseDB http://www.enterprisedb.com > > > ---(end of broadcast)--- > TIP 1: if posting/reading through Usenet, please send an appropriate >subscribe-nomail command to [EMAIL PROTECTED] so that your >message can get through to the mailing list cleanly -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Packed Varlena Update (v21)
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > Added to TODO: > > o Allow single-byte header storage for arrays Fwiw this is "single-byte header storage for varlena array *elements*" The arrays themselves already get the packed varlena treatment. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Packed Varlena Update (v21)
Added to TODO: o Allow single-byte header storage for arrays --- Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > > "Tom Lane" <[EMAIL PROTECTED]> writes: > >> Forgot to mention: one of the revisions was to not add the "sizes.sql" > >> test, because the output was platform-dependent and is likely to get > >> more so if any ability to change the toast thresholds gets put in. > >> Can we improve that test to not expose any platform-dependent numbers? > > > I had imagined that we would have two versions of output files. Other than > > 32-bit versus 64-bit what other platform-dependent variations enter into it? > > If there'd be only two then I'd be all right with it, but I'm worried > that making TOAST thresholds configurable would result in lots more > possible outputs than that. > > BTW, another area that should be kept on the TODO list is to see whether > it makes sense to support 1-byte-header format for array elements. > I looked at that briefly while reviewing the patch but decided it was a > large additional chunk of work and not on the critical path. > > regards, tom lane > > ---(end of broadcast)--- > TIP 3: Have you checked our extensive FAQ? > >http://www.postgresql.org/docs/faq -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Packed Varlena Update (v21)
Gregory Stark <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: >> Forgot to mention: one of the revisions was to not add the "sizes.sql" >> test, because the output was platform-dependent and is likely to get >> more so if any ability to change the toast thresholds gets put in. >> Can we improve that test to not expose any platform-dependent numbers? > I had imagined that we would have two versions of output files. Other than > 32-bit versus 64-bit what other platform-dependent variations enter into it? If there'd be only two then I'd be all right with it, but I'm worried that making TOAST thresholds configurable would result in lots more possible outputs than that. BTW, another area that should be kept on the TODO list is to see whether it makes sense to support 1-byte-header format for array elements. I looked at that briefly while reviewing the patch but decided it was a large additional chunk of work and not on the critical path. regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Packed Varlena Update (v21)
"Tom Lane" <[EMAIL PROTECTED]> writes: > I wrote: >> stark <[EMAIL PROTECTED]> writes: >>> [ packed varlena patch ] > >> Applied with revisions. > > Forgot to mention: one of the revisions was to not add the "sizes.sql" > test, because the output was platform-dependent and is likely to get > more so if any ability to change the toast thresholds gets put in. > Can we improve that test to not expose any platform-dependent numbers? I had imagined that we would have two versions of output files. Other than 32-bit versus 64-bit what other platform-dependent variations enter into it? I'll look at it again on a 64-bit machine, but probably not for another week. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Packed Varlena Update (v21)
I wrote: > stark <[EMAIL PROTECTED]> writes: >> [ packed varlena patch ] > Applied with revisions. Forgot to mention: one of the revisions was to not add the "sizes.sql" test, because the output was platform-dependent and is likely to get more so if any ability to change the toast thresholds gets put in. Can we improve that test to not expose any platform-dependent numbers? regards, tom lane ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Packed Varlena Update (v21)
stark <[EMAIL PROTECTED]> writes: > [ packed varlena patch ] Applied with revisions. Waiting to see how badly the buildfarm complains ;-) ... but I did test on little- and big-endian machines with different MAXALIGN values. regards, tom lane ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
[PATCHES] Packed Varlena Update (v21)
This is just an update against CVS because there was a conflict due to the configure Kerberos change. There is one bug fix in indextuple.c. I need to think a bit on how to write a regression test to test it. I'll try to attach the patch as an attachment this time, crossing my fingers. varvarlena-21.patch.gz Description: Binary data -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
