Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-16 Thread Alvaro Herrera
Tatsuhito Kasahara wrote: Hello. I found a bug in contrib/pgstatindex.c to reports a strange value of leaf_fragmentation with some cases. Applied to HEAD and 8.2, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt,

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-08 Thread Alvaro Herrera
Tatsuhito Kasahara wrote: Hello. I found a bug in contrib/pgstatindex.c to reports a strange value of leaf_fragmentation with some cases. #Look the following test example. In GetBTPageStatistics(), stat-fragments is not initialized properly so that invalid leaf_fragments values are

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-08 Thread Alvaro Herrera
Alvaro Herrera wrote: Right. Checking that code, it seems btpo.xact is also being incorrectly handled, is it not? Incidentally, the return value seems a bit useless. Then again, this looks bogus as well. (Sorry for the unidiff -- I had to use interdiff to get it). -- Alvaro Herrera

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-08 Thread Tatsuhito Kasahara
Hi. Alvaro Herrera wrote: In GetBTPageStatistics(), stat-fragments is not initialized properly so that invalid leaf_fragments values are inserted in results. Right. Checking that code, it seems btpo.xact is also being incorrectly handled, is it not? Yeah, I think so. Incidentally, the