Re: [PATCHES] Updated bitmap index patch

2007-07-23 Thread Alvaro Herrera
Simon Riggs wrote: > Alvaro, > > As you note above there is some linkage between bit map indexes and > clustered indexes, so it seems like we'll either get both or neither. > > I notice the GIT patch is being listed as under review by Alexey and > yourself. Are you actively working on this, or i

Re: [PATCHES] Updated bitmap index patch

2007-07-21 Thread Simon Riggs
On Thu, 2007-05-17 at 18:20 -0400, Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > Due to unfinished VACUUM: > > > > This has been saved for the 8.4 release: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > While we're at this, let's consider Heikki's patch for the stre

Re: [PATCHES] Updated bitmap index patch

2007-06-01 Thread Andrew Dunstan
Gavin Sherry wrote: Hi all, Attached is an updated bitmap index patch. It contains bug fixes, API changes, binary changes (page identifier to distinguish it from other indexes) and has been brought up to HEAD. I worked on a few approaches to VACUUM, none very satisfactory. The problem is, bre

Re: [PATCHES] Updated bitmap index patch

2007-05-18 Thread Heikki Linnakangas
Alvaro Herrera wrote: While we're at this, let's consider Heikki's patch for the streaming indexscan API stuff. That patch was supposed to come from the bitmap index patch, but it was also supposed to help the Grouped Index Tuples (GIT) patch. In fact, as far as I understood the discussion, GIT

Re: [PATCHES] Updated bitmap index patch

2007-05-17 Thread Bruce Momjian
I though the stream bitmaps was a cleanup of on-disk bitmaps, but I think you are right that it was for GII too: http://archives.postgresql.org/pgsql-patches/2007-03/msg00163.php Heikki, can you clarify this and send us an updated version? ---

Re: [PATCHES] Updated bitmap index patch

2007-05-17 Thread Alvaro Herrera
Bruce Momjian wrote: > > Due to unfinished VACUUM: > > This has been saved for the 8.4 release: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold While we're at this, let's consider Heikki's patch for the streaming indexscan API stuff. That patch was supposed to come from the bitm

Re: [PATCHES] Updated bitmap index patch

2007-05-17 Thread Bruce Momjian
Due to unfinished VACUUM: This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Gavin Sherry wrote: > Hi all, > > Attached is an updated bitmap index patch. It contains

Re: [PATCHES] Updated bitmap index patch

2007-05-17 Thread Alvaro Herrera
Gavin Sherry wrote: > Hi all, > > Attached is an updated bitmap index patch. It contains bug fixes, API > changes, binary changes (page identifier to distinguish it from other > indexes) and has been brought up to HEAD. Very minor nitpick: I accidentally noticed that the Makefile in this patch us

Re: [PATCHES] Updated bitmap index patch

2007-05-04 Thread Jie Zhang
Finlay, Thanks for testing. If you can send me the schema, that would be great. Thanks, Jie On 5/4/07 5:41 AM, "Finlay Thompson" <[EMAIL PROTECTED]> wrote: > Hi Gavin > > Thanks for the new patch! > > I ran some address matching on the patched code and have generated > another "ERROR: out o

Re: [PATCHES] Updated bitmap index patch

2007-05-04 Thread Finlay Thompson
Hi Gavin Thanks for the new patch! I ran some address matching on the patched code and have generated another "ERROR: out of memory" problem. The strange thing is that it runs over 150 queries without problem and then crashes. I have attached the logfile (well some of it). If you want I can

Re: [PATCHES] Updated bitmap index patch

2007-05-03 Thread Mark Kirkwood
Mark Kirkwood wrote: I have applied this to todays HEAD performed some quick tests - looks good! I have to re-create a TPC-H dataset to test one of the previous bugs, so I'll probably look at that tomorrow or so. The TPC-H query query that previously produced a SIGSEGV now runs and gives

Re: [PATCHES] Updated bitmap index patch

2007-05-03 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Ga

Re: [PATCHES] Updated bitmap index patch

2007-05-02 Thread Mark Kirkwood
Gavin Sherry wrote: Hi all, Attached is an updated bitmap index patch. It contains bug fixes, API changes, binary changes (page identifier to distinguish it from other indexes) and has been brought up to HEAD. I have applied this to todays HEAD performed some quick tests - looks good! I have

Re: [PATCHES] Updated bitmap index patch

2007-03-12 Thread Gavin Sherry
Teodor, On Mon, 12 Mar 2007, Teodor Sigaev wrote: > I don't very like GiST changes: gistgetbitmap will lock/unlock page for every > tuple. It seems to me taht is better to change gistnext function to use some > sort callback, for example. Or have static array for tids in gistgetbitmap... Good p

Re: [PATCHES] Updated bitmap index patch

2007-03-12 Thread Heikki Linnakangas
Gavin Sherry wrote: Hi all, I've updated the bitmap index patch. It can be found here: http://www.alcove.com.au/~swm/bitmap-2007-03-12.diff This fixes some bugs introduced in the last patch, catches up to HEAD and tidies up the executor code. I want to do a little more tidying, such as reverti

Re: [PATCHES] Updated bitmap index patch

2007-03-12 Thread Teodor Sigaev
I don't very like GiST changes: gistgetbitmap will lock/unlock page for every tuple. It seems to me taht is better to change gistnext function to use some sort callback, for example. Or have static array for tids in gistgetbitmap... -- Teodor Sigaev E-mail: [EM

[PATCHES] Updated bitmap index patch

2007-03-12 Thread Gavin Sherry
Hi all, I've updated the bitmap index patch. It can be found here: http://www.alcove.com.au/~swm/bitmap-2007-03-12.diff This fixes some bugs introduced in the last patch, catches up to HEAD and tidies up the executor code. I want to do a little more tidying, such as reverting the name changes we