Re: [PATCHES] pg_ctl.c

2004-06-02 Thread Gaetano Mendola
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Momjian wrote: | Gaetano Mendola wrote: | |>Bruce Momjian wrote: |> |> |>>Here is the C version of pg_ctl.c written by Andrew Dunstan and updated |>>by me. |>> |>>You can use it by creating a src/bin/pg_ctl_test directory and putting |>>the C and

Re: [PATCHES] pg_ctl.c

2004-05-27 Thread Bruce Momjian
Magnus Hagander wrote: > Seems it needs an implementation of the "pgwin32 special kill". Try > stealing the one from backend/port/win32/signal.c (look for pqkill). > > Perhaps this function (not the rest of signal.c!) should be moved into > port/, instead of backend/port. IIRC it depends on no ot

Re: [PATCHES] pg_ctl.c

2004-05-27 Thread Magnus Hagander
//Magnus > -Original Message- > From: Thomas Hallgren [mailto:[EMAIL PROTECTED] > Sent: Thursday, May 27, 2004 10:53 AM > To: [EMAIL PROTECTED] > Subject: Re: [PATCHES] pg_ctl.c > > Neither the version in CVS head nor the version you attached > here links on > wi

Re: [PATCHES] pg_ctl.c

2004-05-27 Thread Thomas Hallgren
Neither the version in CVS head nor the version you attached here links on win32 (msys/mingw). I get the following: gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declaratio ns pg_ctl.o ec.o -L../../../src/interfaces/libpq -lpq -L../../../src/port -lz -lreadli ne -lwsock32 -lm

Re: [PATCHES] pg_ctl.c

2004-05-26 Thread Gaetano Mendola
Andrew Dunstan wrote: Gaetano Mendola wrote: Andrew Dunstan wrote: Gaetano Mendola wrote: Bruce Momjian wrote: however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) If we used a number of different error codes I might agree. But it seems pointless here, and the style is

Re: [PATCHES] pg_ctl.c

2004-05-26 Thread Andrew Dunstan
Gaetano Mendola wrote: Andrew Dunstan wrote: Gaetano Mendola wrote: Bruce Momjian wrote: however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) If we used a number of different error codes I might agree. But it seems pointless here, and the style is widely used in our cod

Re: [PATCHES] pg_ctl.c

2004-05-26 Thread Gaetano Mendola
Andrew Dunstan wrote: Gaetano Mendola wrote: Bruce Momjian wrote: however below the result of my quich review: 1) exit(1) => exit(EXIT_FAILURE) If we used a number of different error codes I might agree. But it seems pointless here, and the style is widely used in our code base (I just counted

Re: [PATCHES] pg_ctl.c

2004-05-26 Thread Bruce Momjian
OK, here is a new version with lots of fixes. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 1

Re: [PATCHES] pg_ctl.c

2004-05-26 Thread Andrew Dunstan
Gaetano Mendola wrote: Bruce Momjian wrote: Here is the C version of pg_ctl.c written by Andrew Dunstan and updated by me. You can use it by creating a src/bin/pg_ctl_test directory and putting the C and Makefile into that directory. You can then do a make install and use it for testing. Unless so

Re: [PATCHES] pg_ctl.c

2004-05-25 Thread Gaetano Mendola
Bruce Momjian wrote: Here is the C version of pg_ctl.c written by Andrew Dunstan and updated by me. You can use it by creating a src/bin/pg_ctl_test directory and putting the C and Makefile into that directory. You can then do a make install and use it for testing. Unless someone finds a problem,

[PATCHES] pg_ctl.c

2004-05-25 Thread Bruce Momjian
Here is the C version of pg_ctl.c written by Andrew Dunstan and updated by me. You can use it by creating a src/bin/pg_ctl_test directory and putting the C and Makefile into that directory. You can then do a make install and use it for testing. Unless someone finds a problem, I will apply the ch