Re: [PATCHES] [HACKERS] Fix PID file location?

2005-06-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Is reading postgresql.conf > > from pg_ctl without a parser really accurate? > > The brute-force solution is to duplicate guc-file.l. > > That seems pretty ugly but in the long run it might be the most > maintainable solution. We eventually gave up tr

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Tom Lane
Bruce Momjian writes: > Is reading postgresql.conf > from pg_ctl without a parser really accurate? The brute-force solution is to duplicate guc-file.l. That seems pretty ugly but in the long run it might be the most maintainable solution. We eventually gave up trying to have a cut-rate SQL lexe

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > On Fri, May 27, 2005 at 07:40:17PM -0400, Tom Lane wrote: > >> I really think we have only two choices: teach pg_ctl how to dig the > >> data directory location out of postgresql.conf, > > > I don't think this is extremely hard, isn'

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > On Fri, May 27, 2005 at 07:40:17PM -0400, Tom Lane wrote: >> I really think we have only two choices: teach pg_ctl how to dig the >> data directory location out of postgresql.conf, > I don't think this is extremely hard, isn't it? One small problem is

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Alvaro Herrera
On Fri, May 27, 2005 at 07:40:17PM -0400, Tom Lane wrote: > I really think we have only two choices: teach pg_ctl how to dig the > data directory location out of postgresql.conf, I don't think this is extremely hard, isn't it? -- Alvaro Herrera () "El realista sabe lo que quiere; el idealista q

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Tom Lane
Bruce Momjian writes: > I have generated the following patch that moves postmaster.pid into the > configuration directory. pg_ctl only knows about the configuration > directory because it can't read postgresql.conf, so it seems that is the > right place to move it. Unfortunately, that is *absolu

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Josh Berkus
Peter, > Files that are not actually configuration files, to be edited by users, > do not belong in the configuration directory. Do you have an alternate suggestion then? Current behavior is broken. -- --Josh Josh Berkus Aglio Database Solutions San Francisco ---(end

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Andrew Dunstan
Bruce Momjian said: > > I have generated the following patch that moves postmaster.pid into the > configuration directory. pg_ctl only knows about the configuration > directory because it can't read postgresql.conf, so it seems that is > the right place to move it. this seems wrong ... wouldn't i

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Peter Eisentraut
Bruce Momjian wrote: > I have generated the following patch that moves postmaster.pid into > the configuration directory. pg_ctl only knows about the > configuration directory because it can't read postgresql.conf, so it > seems that is the right place to move it. Files that are not actually conf

Re: [PATCHES] [HACKERS] Fix PID file location?

2005-05-27 Thread Bruce Momjian
I have generated the following patch that moves postmaster.pid into the configuration directory. pg_ctl only knows about the configuration directory because it can't read postgresql.conf, so it seems that is the right place to move it. I have tested it and it seems to work. I would like to backp