Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Tom Lane said: Jeremy Drake [EMAIL PROTECTED] writes: On Sun, 2 Jul 2006, Tom Lane wrote: Nah, it was a false alarm: I was looking at the first post-patch report, http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01 but apparently mongoose had managed to pick up a partially-updated snapshot. The later reports (including mongoose's own next try an hour later) were all OK. As the keeper of mongoose, is there anything I should do to prevent it from picking up a partially-updated snapshot? Or is this just a race condition that's bound to happen now and then? Well, it's certainly not *your* problem to fix. I suspect that this risk is inherent in CVS --- although there might also be something involved about our primary-vs-mirror CVS setup. Does anyone know exactly how the mirroring is done and whether it makes any attempt to ensure a consistent copy? Since CVS updates are not atomic, it's hard to see how mirroring could be, unless you did something like disallow updates, mirror, allow updates. I suspect such a cure would be worse than the disease. This is such a rare event that I don't think it's worth the trouble. Buildfarm members are doing 200 builds a day or more, and I can't recall having seen this before. cheers andrew ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: So this patch was by no stretch of the imagination ready to apply, but you did it anyway. Right. What is your next question? Perhaps why is the buildfarm failing would be appropriate. Yes, that is appropriate, though it seems Neil's cleanup of the patch has fixed it now. I see only a single stats failure and an initdb failure in the buildfarm, neither of which I assume are related to the patch. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
On Sun, 2 Jul 2006, Tom Lane wrote: Nah, it was a false alarm: I was looking at the first post-patch report, http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01 but apparently mongoose had managed to pick up a partially-updated snapshot. The later reports (including mongoose's own next try an hour later) were all OK. As the keeper of mongoose, is there anything I should do to prevent it from picking up a partially-updated snapshot? Or is this just a race condition that's bound to happen now and then? ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Perhaps why is the buildfarm failing would be appropriate. Yes, that is appropriate, though it seems Neil's cleanup of the patch has fixed it now. I see only a single stats failure and an initdb failure in the buildfarm, neither of which I assume are related to the patch. Nah, it was a false alarm: I was looking at the first post-patch report, http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01 but apparently mongoose had managed to pick up a partially-updated snapshot. The later reports (including mongoose's own next try an hour later) were all OK. Sorry for the noise. Thanks for keeping an eye on that buildfarm. I often forget to look myself. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Jeremy Drake [EMAIL PROTECTED] writes: On Sun, 2 Jul 2006, Tom Lane wrote: Nah, it was a false alarm: I was looking at the first post-patch report, http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoosedt=2006-07-02%2003:30:01 but apparently mongoose had managed to pick up a partially-updated snapshot. The later reports (including mongoose's own next try an hour later) were all OK. As the keeper of mongoose, is there anything I should do to prevent it from picking up a partially-updated snapshot? Or is this just a race condition that's bound to happen now and then? Well, it's certainly not *your* problem to fix. I suspect that this risk is inherent in CVS --- although there might also be something involved about our primary-vs-mirror CVS setup. Does anyone know exactly how the mirroring is done and whether it makes any attempt to ensure a consistent copy? regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Bruce Momjian [EMAIL PROTECTED] writes: I ran pgindent on the tablecmds.c block of code, and cleaned up some boolean assignments. There are a few XXX comments still in the code so someone should look at those questions and either modify the code or remove the comments. So this patch was by no stretch of the imagination ready to apply, but you did it anyway. regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I ran pgindent on the tablecmds.c block of code, and cleaned up some boolean assignments. There are a few XXX comments still in the code so someone should look at those questions and either modify the code or remove the comments. So this patch was by no stretch of the imagination ready to apply, but you did it anyway. Right. What is your next question? -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: So this patch was by no stretch of the imagination ready to apply, but you did it anyway. Right. What is your next question? Perhaps why is the buildfarm failing would be appropriate. regards, tom lane ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
