Re: [PATCHES] Charset WIN1252
Below is the patch I applied.
> I'm the one who originally posted the patch. But the
> "include/mb/pg_wchar.h" was as complete source in the ZIP attached to
> my mail on 02.11.04 as well as patch in my mail on 30.11.04 with
> correct contents.
>
> And also in the confirmation of Bruce Momjian from 30.11.04 "Your patch
> has been added to the PostgreSQL unapplied patches list ..." there was
> the correct file contents listed.
You will notice there is no mention of "include/mb/pg_wchar.h" anywhere
in the message, and it was not in the zip file, at least in the most
recent version I applied.
FYI, this patch went through several revisions as people commented on it
so it is very possible some files get lost during the revisions.
---
pgman wrote:
>
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
>
> ---
>
>
> Roland Volkmann wrote:
> > Hallo Alvaron
> >
> >
> > Alvaro Herrera schrieb am 30.11.2004 17:38:
> >
> > >On Tue, Nov 30, 2004 at 02:05:31AM +0100, Roland Volkmann wrote:
> > >
> > >
> > >
> > >>this is the first time, I use CVS (TortoisCVS), so I hope the result is
> > >>what you were missing:
> > >>
> > >>
> > >
> > >You have to include the new files separately. And please send context
> > >diffs, not unified diffs.
> > >
> > >
> > sorry, but I can't find any option for changing patch style in
> > TortoiseCVS. And the patches of other developers look similar to me.
> >
> > The new files were attached as ZIP-file to my mail on 02.11.2004. Please
> > find these files again attached to this mail:
> >
> > Index:
> > src/backend/utils/mb/conversion_procs/utf8_and_win1252/utf8_and_win1252.c
> > Index: src/backend/utils/mb/conversion_procs/utf8_and_win1252/Makefile
> > Index: src/backend/utils/mb/Unicode/utf8_to_win1252.map
> > Index: src/backend/utils/mb/Unicode/win1252_to_utf8.map
> > ===
> > ++ new files
> >
> >
> > >Also there's a typo here:
> > >
> > >
> > >
> > thank you, you're right. And here is the corrected patch which shoult
> > replace the earlier faulty one:
> >
> >
> > Index: src/backend/utils/mb/encnames.c
> > ===
> > RCS file:
> > Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/encnames.c,v
> > retrieving revision 1.1
> > diff -u -r1.1 encnames.c
> > --- src/backend/utils/mb/encnames.c30 Nov 2004 23:42:16 -1.1
> > +++ src/backend/utils/mb/encnames.c30 Nov 2004 23:56:27 -
> > @@ -194,6 +194,9 @@
> > "win1251", PG_WIN1251
> > },/* alias for Windows-1251 */
> > {
> > +"win1252", PG_WIN1252
> > +},/* alias for Windows-1252 */
> > +{
> > "win1256", PG_WIN1256
> > },/* alias for Windows-1256 */
> > {
> > @@ -221,6 +224,9 @@
> > "windows1251", PG_WIN1251
> > },/* Windows-1251; Microsoft */
> > {
> > +"windows1252", PG_WIN1252
> > +},/* Windows-1251; Microsoft */
> > +{
> > "windows1256", PG_WIN1256
> > },/* Windows-1256; Microsoft */
> > {
> > @@ -342,6 +348,9 @@
> > },
> > {
> > "WIN1250", PG_WIN1250
> > +},
> > +{
> > +"WIN1252", PG_WIN1252
> > },
> > {
> > "SJIS", PG_SJIS
> >
> > ===
> >
> >
> > With best regards,
> >
> > Roland
> >
>
> > #-
> > #
> > # $PostgreSQL:
> > pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252/Makefile,v 1.3
> > 2004/10/31 22:40:41 pgsql Exp $
> > #
> > #-
> > subdir = src/backend/utils/mb/conversion_procs/utf8_and_win1252
> > top_builddir = ../../../../../..
> > include $(top_builddir)/src/Makefile.global
> >
> > NAME:= utf8_and_win1252
> >
> > include $(srcdir)/../proc.mk
>
> > /*-
> > *
> > *WIN1252 and UTF-8
> > *
> > * Portions Copyright (c) 1996-2004, PostgreSQL Global Development Group
> > * Portions Copyright (c) 1994, Regents of the University of California
> > *
> > * IDENTIFICATION
> > *$PostgreSQL:
> > pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252/utf8_and_win1252.c,v
> > 1.8 2004/10/31 04:12:59 momjian Exp $
> > *
> > *-
Re: [PATCHES] Charset WIN1252
Hallo Alvaron
Alvaro Herrera schrieb am 30.11.2004 17:38:
On Tue, Nov 30, 2004 at 02:05:31AM +0100, Roland Volkmann wrote:
this is the first time, I use CVS (TortoisCVS), so I hope the result is
what you were missing:
You have to include the new files separately. And please send context
diffs, not unified diffs.
sorry, but I can't find any option for changing patch style in
TortoiseCVS. And the patches of other developers look similar to me.
The new files were attached as ZIP-file to my mail on 02.11.2004. Please
find these files again attached to this mail:
Index:
src/backend/utils/mb/conversion_procs/utf8_and_win1252/utf8_and_win1252.c
Index: src/backend/utils/mb/conversion_procs/utf8_and_win1252/Makefile
Index: src/backend/utils/mb/Unicode/utf8_to_win1252.map
Index: src/backend/utils/mb/Unicode/win1252_to_utf8.map
===
++ new files
Also there's a typo here:
thank you, you're right. And here is the corrected patch which shoult
replace the earlier faulty one:
Index: src/backend/utils/mb/encnames.c
===
RCS file:
Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/encnames.c,v
retrieving revision 1.1
diff -u -r1.1 encnames.c
--- src/backend/utils/mb/encnames.c30 Nov 2004 23:42:16 -1.1
+++ src/backend/utils/mb/encnames.c30 Nov 2004 23:56:27 -
@@ -194,6 +194,9 @@
"win1251", PG_WIN1251
},/* alias for Windows-1251 */
{
+"win1252", PG_WIN1252
+},/* alias for Windows-1252 */
+{
"win1256", PG_WIN1256
},/* alias for Windows-1256 */
{
@@ -221,6 +224,9 @@
"windows1251", PG_WIN1251
},/* Windows-1251; Microsoft */
{
+"windows1252", PG_WIN1252
+},/* Windows-1251; Microsoft */
+{
"windows1256", PG_WIN1256
},/* Windows-1256; Microsoft */
{
@@ -342,6 +348,9 @@
},
{
"WIN1250", PG_WIN1250
+},
+{
+"WIN1252", PG_WIN1252
},
{
"SJIS", PG_SJIS
===
With best regards,
Roland
#-
#
# $PostgreSQL:
pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252/Makefile,v 1.3
2004/10/31 22:40:41 pgsql Exp $
#
#-
subdir = src/backend/utils/mb/conversion_procs/utf8_and_win1252
top_builddir = ../../../../../..
include $(top_builddir)/src/Makefile.global
NAME:= utf8_and_win1252
include $(srcdir)/../proc.mk
/*-
*
*WIN1252 and UTF-8
*
* Portions Copyright (c) 1996-2004, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
*$PostgreSQL:
pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252/utf8_and_win1252.c,v
1.8 2004/10/31 04:12:59 momjian Exp $
*
*-
*/
#include "postgres.h"
#include "fmgr.h"
#include "mb/pg_wchar.h"
#include "../../Unicode/utf8_to_win1252.map"
#include "../../Unicode/win1252_to_utf8.map"
PG_FUNCTION_INFO_V1(utf_to_win1252);
PG_FUNCTION_INFO_V1(win1252_to_utf);
extern Datum utf_to_win1252(PG_FUNCTION_ARGS);
extern Datum win1252_to_utf(PG_FUNCTION_ARGS);
/* --
* conv_proc(
* INTEGER,-- source encoding id
* INTEGER,-- destination encoding id
* CSTRING,-- source string (null terminated C string)
* CSTRING,-- destination string (null terminated C string)
* INTEGER -- source string length
* ) returns VOID;
* --
*/
Datum
utf_to_win1252(PG_FUNCTION_ARGS)
{
unsigned char *src = PG_GETARG_CSTRING(2);
unsigned char *dest = PG_GETARG_CSTRING(3);
int len = PG_GETARG_INT32(4);
Assert(PG_GETARG_INT32(0) == PG_UTF8);
Assert(PG_GETARG_INT32(1) == PG_WIN1252);
Assert(len >= 0);
UtfToLocal(src, dest, ULmapWIN1252,
sizeof(ULmapWIN1252) / sizeof(pg_utf_to_local), len);
PG_RETURN_VOID();
}
Datum
win1252_to_utf(PG_FUNCTION_ARGS)
{
unsigned char *src = PG_GETARG_CSTRING(2);
unsigned char *dest = PG_GETARG_CSTRING(3);
int len = PG_GETARG_INT32(4);
Assert(PG_GETARG_INT32(0) == PG_WIN1252);
Assert(PG_GETARG_INT32(1) == PG_UTF8);
Assert(len >= 0);
LocalToUtf(src, dest, LUmapWIN1252,
sizeof(LUmapWIN1252) / sizeof(pg_local_to_utf), PG_WIN1252,
len);
Re: [PATCHES] Charset WIN1252
On Tue, Nov 30, 2004 at 02:05:31AM +0100, Roland Volkmann wrote:
> this is the first time, I use CVS (TortoisCVS), so I hope the result is
> what you were missing:
You have to include the new files separately. And please send context
diffs, not unified diffs.
Also there's a typo here:
> Index: src/backend/utils/mb/encnames.c
> ===
> RCS file:
> Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/encnames.c,v
> retrieving revision 1.1
> diff -u -r1.1 encnames.c
> --- src/backend/utils/mb/encnames.c30 Nov 2004 00:51:56 -1.1
> +++ src/backend/utils/mb/encnames.c31 Oct 2004 19:09:16 -
> @@ -342,6 +348,9 @@
> },
> {
> "WIN1250", PG_WIN1250
> +},
> +{
> +"WIN1250", PG_WIN1252
> },
> {
> "SJIS", PG_SJIS
--
Alvaro Herrera (<[EMAIL PROTECTED]>)
"The important things in the world are problems with society that we don't
understand at all. The machines will become more complicated but they won't
be more complicated than the societies that run them."(Freeman Dyson)
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
Re: [PATCHES] Charset WIN1252
Hello Peter, Hello Bruce,
Peter Eisentraut schrieb am 29.11.2004 08:11:
Bruce Momjian wrote:
Your patch has been added to the PostgreSQL unapplied patches list
at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers
reviews and approves it.
He should send a patch, not a source tarball, so it's possible to see
what actually changed.
this is the first time, I use CVS (TortoisCVS), so I hope the result is
what you were missing:
Index: src/include/mb/pg_wchar.h
===
RCS file:
Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/include/mb/pg_wchar.h,v
retrieving revision 1.1
diff -u -r1.1 pg_wchar.h
--- src/include/mb/pg_wchar.h30 Nov 2004 00:49:17 -1.1
+++ src/include/mb/pg_wchar.h31 Oct 2004 19:08:58 -
@@ -178,6 +178,7 @@
PG_ISO_8859_7,/* ISO-8859-7 */
PG_ISO_8859_8,/* ISO-8859-8 */
PG_WIN1250,/* windows-1250 */
+PG_WIN1252,/* windows-1252 */
/* followings are for client encoding only */
PG_SJIS,/* Shift JIS (Winindows-932) */
@@ -189,7 +190,7 @@
} pg_enc;
-#define PG_ENCODING_BE_LAST PG_WIN1250
+#define PG_ENCODING_BE_LAST PG_WIN1252
#define PG_ENCODING_FE_LAST PG_GB18030
/*
Index: src/backend/utils/mb/encnames.c
===
RCS file:
Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/encnames.c,v
retrieving revision 1.1
diff -u -r1.1 encnames.c
--- src/backend/utils/mb/encnames.c30 Nov 2004 00:51:56 -1.1
+++ src/backend/utils/mb/encnames.c31 Oct 2004 19:09:16 -
@@ -194,6 +194,9 @@
"win1251", PG_WIN1251
},/* alias for Windows-1251 */
{
+"win1252", PG_WIN1252
+},/* alias for Windows-1252 */
+{
"win1256", PG_WIN1256
},/* alias for Windows-1256 */
{
@@ -221,6 +224,9 @@
"windows1251", PG_WIN1251
},/* Windows-1251; Microsoft */
{
+"windows1252", PG_WIN1252
+},/* Windows-1251; Microsoft */
+{
"windows1256", PG_WIN1256
},/* Windows-1256; Microsoft */
{
@@ -342,6 +348,9 @@
},
{
"WIN1250", PG_WIN1250
+},
+{
+"WIN1250", PG_WIN1252
},
{
"SJIS", PG_SJIS
Index: src/backend/utils/mb/wchar.c
===
RCS file:
Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/wchar.c,v
retrieving revision 1.1
diff -u -r1.1 wchar.c
--- src/backend/utils/mb/wchar.c30 Nov 2004 00:52:08 -1.1
+++ src/backend/utils/mb/wchar.c31 Oct 2004 19:25:30 -
@@ -1,7 +1,7 @@
/*
* conversion functions between pg_wchar and multibyte streams.
* Tatsuo Ishii
- * $PostgreSQL: pgsql/src/backend/utils/mb/wchar.c,v 1.38 2004/09/17
21:59:57 petere Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/mb/wchar.c,v 1.39 2004/10/31
21:59:57 petere Exp $
*
* WIN1250 client encoding updated by Pavel Behal
*
@@ -744,11 +744,12 @@
{pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen,
1},/* 26; ISO-8859-7 */
{pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen,
1},/* 27; ISO-8859-8 */
{pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen,
1},/* 28; PG_WIN1250 */
-{0, pg_sjis_mblen, pg_sjis_dsplen, 2},/* 29; PG_SJIS */
-{0, pg_big5_mblen, pg_big5_dsplen, 2},/* 30; PG_BIG5 */
-{0, pg_gbk_mblen, pg_gbk_dsplen, 2},/* 31; PG_GBK */
-{0, pg_uhc_mblen, pg_uhc_dsplen, 2},/* 32; PG_UHC */
-{0, pg_gb18030_mblen, pg_gb18030_dsplen, 2} /* 33; PG_GB18030 */
+{pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen,
1},/* 29; PG_WIN1252 */
+{0, pg_sjis_mblen, pg_sjis_dsplen, 2},/* 30; PG_SJIS */
+{0, pg_big5_mblen, pg_big5_dsplen, 2},/* 31; PG_BIG5 */
+{0, pg_gbk_mblen, pg_gbk_dsplen, 2},/* 32; PG_GBK */
+{0, pg_uhc_mblen, pg_uhc_dsplen, 2},/* 33; PG_UHC */
+{0, pg_gb18030_mblen, pg_gb18030_dsplen, 2} /* 34; PG_GB18030 */
};
/* returns the byte length of a word for mule internal code */
Index: src/backend/utils/mb/conversion_procs/Makefile
===
RCS file:
Y:\CVS_Repositories\postgres.org/postgresql-8.0.0beta5/src/backend/utils/mb/conversion_procs/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- src/backend/utils/mb/conversion_procs/Makefile30 Nov 2004
00:54:21 -1.1
+++ src/backend/utils/mb/conversion_procs/Makefile31 Oct 2004
18:50:44 -
@@ -4,7 +4,7 @@
#Makefile for utils/mb/conversion_procs
#
# IDENTIFICATION
-#$PostgreSQL:
pgsql/sr
Re: [PATCHES] Charset WIN1252
Bruce Momjian wrote: > Your patch has been added to the PostgreSQL unapplied patches list > at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers > reviews and approves it. He should send a patch, not a source tarball, so it's possible to see what actually changed. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] Charset WIN1252
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Roland Volkmann wrote: > Hello developers, > > please find attached a ZIP with sources, headers, and tables for > WIN1252-Support. > > Even if UTF-8 handling will be completed in the engine, there will still be > some applications which need WIN1252 on client side. I added the new charset > to pg_enc and pg_enc2name[] after WIN1250 and before the entries which are > for client encoding only. > > > With best regards, > > Roland Volkmann > > -- > Roland Volkmann > Stuttgart / Germany > > > > -Original Message- > From: Peter Eisentraut [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 02, 2004 10:23 AM > To: Roland Volkmann > Cc: PostgreSQL Developers > Subject: Re: [HACKERS] FW: Charset WIN1252 > > > Am Montag, 1. November 2004 22:16 schrieb Roland Volkmann: > > now, where the native Win32-Version of PostgreSQL is nearly ready for > > Production use, I'm still missing support of WIN1252 charset. And UTF-8 > > can't be used on server side in West Europe, because it's implementation > > isn't complete yet (e.g. upper() / lower() missing for umlauts). > > This will work in 8.0. > > > Therefore I've added / modyfied all related sources, headers, and tables > > for WIN1252-Support. > > Please send your patch to [EMAIL PROTECTED] for consideration. > > -- > Peter Eisentraut > http://developer.postgresql.org/~petere/ > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 6: Have you searched our list archives? > >http://archives.postgresql.org -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
