Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Simon Riggs" <[EMAIL PROTECTED]> writes: >> I'll return the infomasks directly, for you to manipulate. >> >> Not happy with that, but open to suggestions. > Well the alternative would be a long list of boolean columns which would make > the output kind

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Gregory Stark
"Simon Riggs" <[EMAIL PROTECTED]> writes: > I'll return the infomasks directly, for you to manipulate. > > Not happy with that, but open to suggestions. Well the alternative would be a long list of boolean columns which would make the output kind of long. Perhaps a function pg_decode_infomask(va

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Simon Riggs
On Tue, 2007-03-06 at 09:33 +0530, Pavan Deolasee wrote: > Simon Riggs wrote: > > I'll happily code it as functions or system cols or any other way, as > > long as we can see everything there is to see. > With HOT, other useful information is about the line pointers. Done > It would be > cool t

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Pavan Deolasee
Simon Riggs wrote: I'll happily code it as functions or system cols or any other way, as long as we can see everything there is to see. With HOT, other useful information is about the line pointers. It would be cool to be able to print the redirection info, details about LP_DELETEd line poi

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Exactly what will these allow that you can't do with inspection of ctid > etc? (I suspect your answer will be "can't see infomask" For testing the packed varlena stuff it would have been handy to be able to see the length of tuples on disk. I made do with

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > On Mon, 2007-03-05 at 14:31 -0500, Tom Lane wrote: >> Exactly what will these allow that you can't do with inspection of ctid >> etc? (I suspect your answer will be "can't see infomask", but I'd >> rather expose that as a new system column than invent fu

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Simon Riggs
On Mon, 2007-03-05 at 14:31 -0500, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > WIP patch for diagnostic/test functions for heap pages. (Linked to > > discussion thread on -hackers "HOT - Whats Next?") > > --- no security checks; surely these must be superuser-only. OK thanks

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > WIP patch for diagnostic/test functions for heap pages. (Linked to > discussion thread on -hackers "HOT - Whats Next?") --- no security checks; surely these must be superuser-only. --- relation_open will succeed on things that don't have storage; better