Re: [PATCHES] Interval month, week - day

2006-09-03 Thread Michael Glaesemann
On Sep 1, 2006, at 9:32 , Tom Lane wrote: Michael Glaesemann [EMAIL PROTECTED] writes: On Sep 1, 2006, at 9:12 , Tom Lane wrote: I agree that this seems like an oversight in the original months/days/seconds patch, rather than behavior we want to keep. But is DecodeInterval the only place

Re: [PATCHES] Interval month, week - day

2006-09-03 Thread Michael Glaesemann
On Sep 3, 2006, at 20:00 , Michael Glaesemann wrote: On Sep 1, 2006, at 9:32 , Tom Lane wrote: Michael Glaesemann [EMAIL PROTECTED] writes: On Sep 1, 2006, at 9:12 , Tom Lane wrote: I agree that this seems like an oversight in the original months/days/seconds patch, rather than behavior

Re: [PATCHES] Interval month, week - day

2006-09-03 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes: I realized there might be something in ecpg, and there was. I've updated the ecpg DecodeInterval to match. However, I haven't been able to get ecpg make check to work, so that part's untested. This patch fails to apply --- looks like whitespace

Re: [PATCHES] Interval month, week - day

2006-09-03 Thread Michael Glaesemann
On Sep 4, 2006, at 9:41 , Tom Lane wrote: This patch fails to apply --- looks like whitespace got mangled in transit. Please resend as an attachment. Please let me know if you have any problems with this one. Michael Glaesemann grzm seespotcode net 10interval_input_0904T0855+0900.diff

Re: [PATCHES] Interval month, week - day

2006-08-31 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes: I came across some behavior that seems counterintuitive to me: test=# select '1.5 mon'::interval; interval - 1 mon 360:00:00 (1 row) With the time/day/month interval struct introduced in 8.1, I'd expect this to return '1

Re: [PATCHES] Interval month, week - day

2006-08-31 Thread Michael Glaesemann
On Sep 1, 2006, at 9:12 , Tom Lane wrote: Michael Glaesemann [EMAIL PROTECTED] writes: I came across some behavior that seems counterintuitive to me: test=# select '1.5 mon'::interval; interval - 1 mon 360:00:00 (1 row) With the time/day/month interval struct

Re: [PATCHES] Interval month, week - day

2006-08-31 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes: On Sep 1, 2006, at 9:12 , Tom Lane wrote: I agree that this seems like an oversight in the original months/days/seconds patch, rather than behavior we want to keep. But is DecodeInterval the only place with the problem? I'll check on this tonight.

Re: [PATCHES] Interval month, week - day

2006-08-29 Thread Bruce Momjian
The masks don't need changing. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.