Re: [PATCHES] Memory leak in nodeAgg

2008-03-11 Thread Bruce Momjian
Added to TODO: * Consider simplifying how memory context resets handle child contexts http://archives.postgresql.org/pgsql-patches/2007-08/msg00067.php --- Neil Conway wrote: > On Mon, 2007-08-06 at 18:52 -0400, Tom Lan

Re: [PATCHES] Memory leak in nodeAgg

2007-08-08 Thread Neil Conway
On Mon, 2007-08-06 at 14:21 -0700, Neil Conway wrote: > Attached is a patch that fixes a gradual memory leak in ExecReScanAgg(), > when the AGG_HASHED strategy is used Applied to HEAD, and backpatched back to 7.4. -Neil ---(end of broadcast)--- T

Re: [PATCHES] Memory leak in nodeAgg

2007-08-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > ... Perhaps we could redefine Reset to mean > ResetAndDeleteChildren, and add another name for the current Reset > functionality. ResetAndPreserveChildren, maybe? Yeah, I was considering exactly that as an interim step. >> Anyone want to investigate what

Re: [PATCHES] Memory leak in nodeAgg

2007-08-06 Thread Neil Conway
On Mon, 2007-08-06 at 18:52 -0400, Tom Lane wrote: > Hmm. Good catch, but I can't help wondering if this is just the tip > of the iceberg. Should *every* MemoryContextReset be > MemoryContextResetAndDeleteChildren? Yeah, the same thought occurred to me. Certainly having the current behavior as t

Re: [PATCHES] Memory leak in nodeAgg

2007-08-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch that fixes a gradual memory leak in ExecReScanAgg(), > when the AGG_HASHED strategy is used: Hmm. Good catch, but I can't help wondering if this is just the tip of the iceberg. Should *every* MemoryContextReset be MemoryContextResetAn