Re: [PATCHES] Patch for BUG #2073: Can't drop sequence when created

2006-06-26 Thread Bruce Momjian
Patch applied. Thanks. --- Dhanaraj M wrote: > Hi > > I send the appropriate patch for bug #2073. This fix disallows to change the > default sequence. > I ran the regression test and passed. The bug details are given bel

Re: [PATCHES] Patch for BUG #2073: Can't drop sequence when created

2006-04-29 Thread Bruce Momjian
Tom Lane wrote: > I wrote: > > Bruce Momjian writes: > >> Patch applied. Thanks. > > > Has this been reviewed at all? I thought we were still discussing what > > the behavior should be, let alone whether the patch is correct. > > Actually, now that I look at it, this patch is definitely *not*

Re: [PATCHES] Patch for BUG #2073: Can't drop sequence when created

2006-04-29 Thread Tom Lane
I wrote: > Bruce Momjian writes: >> Patch applied. Thanks. > Has this been reviewed at all? I thought we were still discussing what > the behavior should be, let alone whether the patch is correct. Actually, now that I look at it, this patch is definitely *not* correct, as it does not implemen

Re: [PATCHES] Patch for BUG #2073: Can't drop sequence when created

2006-04-29 Thread Tom Lane
Bruce Momjian writes: > Patch applied. Thanks. Has this been reviewed at all? I thought we were still discussing what the behavior should be, let alone whether the patch is correct. regards, tom lane ---(end of broadcast)

Re: [PATCHES] Patch for BUG #2073: Can't drop sequence when created

2006-04-29 Thread Bruce Momjian
Patch applied. Thanks. --- Dhanaraj M wrote: > Hi > > I send the appropriate patch for bug #2073. This fix disallows to change the > default sequence. > I ran the regression test and passed. The bug details are given bel

Re: [PATCHES] Patch for bug #2073 (Can't drop sequence when created

2006-04-17 Thread Dhanaraj M - Sun Microsystems
Pl. look at the following code, which is taken from alter_table.sql (regression test) = mydb=# create table anothertab (atcol1 serial8, atcol2 boolean, constraint anothertab_chk check (atcol1 <= 3)); NOTICE: CREATE TABLE

Re: [PATCHES] Patch for bug #2073 (Can't drop sequence when created via SERIAL column)

2006-04-10 Thread Tom Lane
Dhanaraj M - Sun Microsystems <[EMAIL PROTECTED]> writes: > I fixed the above bug. I attach the patch here. Please review and > acknowledge me. > Bug details > > BUG #2073: Can't drop sequence when created via SERIAL column That isn't a bug, and this "fix" is not appropriate. See eg Br