Re: [PATCHES] Pipe fixes for win32 services

2004-07-25 Thread Bruce Momjian

Patch applied.  Thanks.

---


Magnus Hagander wrote:
 Here is a patch that fixes the pipes used in find_other_exec() when
 running as a service on windows = 2000. Required to make the pg_ctl
 service wrapper to work at all.
 
 //Magnus

Content-Description: exec_pipe.patch

[ Attachment, skipping... ]

 
 ---(end of broadcast)---
 TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


Re: [PATCHES] Pipe fixes for win32 services

2004-07-24 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes:
 This needs to be applied soon so the installer can be tested.

I can't speak to the details of the Windows process-launch code,
but it looked okay to me otherwise.

One point: if I understood correctly, this is necessary only for
Windows 2000, because we've already blown off the thought of
supporting any older Windows versions, no?  If we later decide
we can't support W2K either, this would be a pretty large chunk
of code that we could pull out.  Please make sure it's clearly
labeled as useful only as long as we support Windows 2000.

regards, tom lane

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])


Re: [PATCHES] Pipe fixes for win32 services

2004-07-24 Thread Bruce Momjian
Tom Lane wrote:
 Bruce Momjian [EMAIL PROTECTED] writes:
  This needs to be applied soon so the installer can be tested.
 
 I can't speak to the details of the Windows process-launch code,
 but it looked okay to me otherwise.
 
 One point: if I understood correctly, this is necessary only for
 Windows 2000, because we've already blown off the thought of
 supporting any older Windows versions, no?  If we later decide
 we can't support W2K either, this would be a pretty large chunk
 of code that we could pull out.  Please make sure it's clearly
 labeled as useful only as long as we support Windows 2000.

Yep, I had him add this comment:

+  * The runtime librarys popen() on win32 does not work when being
+  * called from a service when running on windows = 2000, because
+  * there is no stdin/stdout/stderr.

I think we support NT too, hence the = 2000.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


Re: [PATCHES] Pipe fixes for win32 services

2004-07-24 Thread Magnus Hagander
Bruce Momjian [EMAIL PROTECTED] writes:
 This needs to be applied soon so the installer can be tested.

I can't speak to the details of the Windows process-launch code,
but it looked okay to me otherwise.

One point: if I understood correctly, this is necessary only for
Windows 2000, because we've already blown off the thought of
supporting any older Windows versions, no? 

No, NT4 is also on our list of supported versions.

 If we later decide
we can't support W2K either, this would be a pretty large chunk
of code that we could pull out.  Please make sure it's clearly
labeled as useful only as long as we support Windows 2000.

It is, in the comment preceding the code.

//Magnus

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [PATCHES] Pipe fixes for win32 services

2004-07-24 Thread Claudio Natoli

Tom Lane writes:
 I can't speak to the details of the Windows process-launch code,

FWIW, it checks out fine to me.

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
a
href=http://www.memetrics.com/emailpolicy.html;http://www.memetrics.com/em
ailpolicy.html/a

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly