Re: [PATCHES] Please define PQ_BUFFER_SIZE in interfaces/libpq/fe-misc.c

[Tom Lane]

Hideyuki Kawashima [EMAIL PROTECTED] writes:
 While coding, I was surprised that 
 magic number 8192 (which is defined as PQ_BUFFER_SIZE in 
 backend/libpq/pqcomm.c) are written into the code 
 in interfaces/libpq/fe-misc.

AFAICS the uses of 8192 in fe-misc.c have no relationship to
PQ_BUFFER_SIZE or indeed much of anything.  They are just arbitrary
amounts by which to increase the I/O buffer size.

Of course they are not *completely* arbitrary --- they are essentially
guesses about the buffering behavior of the kernel and TCP stack.
But they have nothing to do with the server-side PQ_BUFFER_SIZE.

 The result is attached to this mail.

In future please submit proposed changes as diff -c patches.
A complete file is useless because it cannot be applied without
risking overwriting other people's changes.

regards, tom lane

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] Please define PQ_BUFFER_SIZE in

[Hideyuki Kawashima]

Thanks for teaching me about 8192 in fe-misc.c.
I recognized the 8192 in fe-misc.c does not relate to PQ_BUFFER_SIZE
in pqcomm.c, but I am pleased if someone revises the magic number.
And I am sorry for my incorrect format patch.
From next time, I will submit my proposition as diff -c patches.

-- Hideyuki Kawashima

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster