Re: [PATCHES] Solve a problem of LC_TIME of windows.

2008-09-24 Thread Magnus Hagander
Hiroshi Saito wrote: Hi. I have problem of LC_TIME of windows.(CVS-HEAD) As for Version 8.3.3. It is edited by wrong gettext and is. (But, it is expressed.) http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/pg8.3.3-to_char_gettext_format.png As for Version 8.4. It came to

Re: [PATCHES] Solve a problem of LC_TIME of windows.

2008-09-24 Thread Alvaro Herrera
Magnus Hagander wrote: Also, the patch needs error checking. strftime() can fail, and the multibyte conversion functions can certainly fail. That will need to be added. What about this line? #define STRLEN_MAX 255 Are we really sure the strftime format cannot be longer than that? --

Re: [PATCHES] Solve a problem of LC_TIME of windows.

2008-09-24 Thread Hiroshi Saito
Hi. - Original Message - From: Magnus Hagander [EMAIL PROTECTED] In principle, I think this patch looks good. Do you (or somebody else) have an example where this breaks in an encoding where I can actually understand the characters, though ;-) That would make testing a whole lot