Re: [PATCHES] cleanup error reporting
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > (side note - maybe we need a check target for these that uses a temp install > - that would make it easier to check for errors like this). IIRC, the reason we don't have that is that it's too hard to get it to work reliably (shared library search paths, and all that rot). Of course that decision was taken some time ago, and maybe we've fixed all the underlying problems since then ... regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] cleanup error reporting
Neil Conway said: > On Tue, 2006-02-28 at 22:38 -0500, Tom Lane wrote: >> There are one or two "cannot"s that should be "could not"s in your hit >> list, per the style guidelines. >> >> While you're at it -- I noticed several of the tsearch2 messages refer >> to "lexem(s)". The word is "lexeme", the plural "lexemes", so this >> should be "lexeme(s)". Looks like it's misspelled various places in >> the README and code comments too ... > > Thanks for the suggestions -- I fixed both of those issues, and applied > a revised patch to HEAD. > This has apparently broken regression tests in both contrib and PL. See buildfarm for details. (side note - maybe we need a check target for these that uses a temp install - that would make it easier to check for errors like this). cheers andrew ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] cleanup error reporting
On Tue, 2006-02-28 at 22:38 -0500, Tom Lane wrote: > There are one or two "cannot"s that should be "could not"s in your > hit list, per the style guidelines. > > While you're at it -- I noticed several of the tsearch2 messages refer > to "lexem(s)". The word is "lexeme", the plural "lexemes", so this > should be "lexeme(s)". Looks like it's misspelled various places in the > README and code comments too ... Thanks for the suggestions -- I fixed both of those issues, and applied a revised patch to HEAD. -Neil ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] cleanup error reporting
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch that makes the message strings used in elogs and > ereports more consistent with the style guidelines: There are one or two "cannot"s that should be "could not"s in your hit list, per the style guidelines. While you're at it -- I noticed several of the tsearch2 messages refer to "lexem(s)". The word is "lexeme", the plural "lexemes", so this should be "lexeme(s)". Looks like it's misspelled various places in the README and code comments too ... regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
