Re: [PATCHES] listening addresses

2004-03-24 Thread Andrew Dunstan
Bruce Momjian said: Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Second attempt attached. The fatal message now reads no configured listening socket available, but I am not wedded to the wording. I also was not sure how to mark up * in the docs. I went with no socket

Re: [PATCHES] listening addresses

2004-03-24 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Both of these are not always correct - they might well have configured a listening address but we were unable to bind to it, although in that case a warning would have already been issued. To be strictly correct either we need to

Re: [PATCHES] listening addresses

2004-03-24 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: How about no socket created for listening or some such? Or no socket available for listening? Created seems better since it's a verb, and focuses attention on the probability that we tried and failed to make a socket. Available is too

Re: [PATCHES] listening addresses

2004-03-23 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Second attempt attached. The fatal message now reads no configured listening socket available, but I am not wedded to the wording. I also was not sure how to mark up * in the docs. Reviewed and committed. I found a bunch more

Re: [PATCHES] listening addresses

2004-03-22 Thread Andrew Dunstan
Tom Lane wrote: Please revise, and update the docs too. Second attempt attached. The fatal message now reads no configured listening socket available, but I am not wedded to the wording. I also was not sure how to mark up * in the docs. cheers andrew Index: doc/src/sgml/runtime.sgml

Re: [PATCHES] listening addresses

2004-03-22 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Second attempt attached. The fatal message now reads no configured listening socket available, but I am not wedded to the wording. I also was not sure how to mark up * in the docs. Reviewed and committed. I found a bunch more references in the docs

Re: [PATCHES] listening addresses

2004-03-21 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Submitted for review. Okay, some random comments: ! char *ListenAddresses = localhost; I think you made this mistake in the log_line_prefix patch too. The contents of a GUC string var should always be either NULL or a pointer to a malloc'd