Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. --- Alvaro Herrera wrote: An untested patch to update the password file. Something that bugged me a lot is that I tried to find the

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. Let me include this patch in the next patch I'll submit shortly. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I suspect most samba

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
OK. Also, I would like you to post a list of the open items you have so we can all know the status. --- Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: Alvaro, you call

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Patch withdrawn by author. --- Alvaro Herrera wrote: An untested patch to update the password file. Something that bugged me a lot is that I tried to find the format of the file for testing the patch, and I couldn't

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. It looks like Alvaro forgot to include diffs for xact.c in that patch. I imagine what he had in mind was to add such a function to xact.c. I would like to counsel

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. It looks like Alvaro forgot to include diffs for xact.c in that patch. I imagine what he had in mind was to add such a function to xact.c. I

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
OK, but why would we document the contents of a file that are not to be modified by the user? --- Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:18:40PM -0400, Bruce Momjian wrote: Something that bugged me a lot is

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 02:18:40PM -0400, Bruce Momjian wrote: Something that bugged me a lot is that I tried to find the format of the file for testing the patch, and I couldn't find anything anywhere in the docs. Apparently the docs for the file were ripped with the docs for the

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: OK, but why would we document the contents of a file that are not to be modified by the user? Also note that the 7.2 docs are out of date anyway (looks to me like we use spaces not colons as column separators...) regards, tom lane

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I have several files, one per

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I have several files, one per pg_hba.conf entry? Can I use multiple files with a single pg_hba.conf entry? What happens if I have a username that

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 03:19:43PM -0400, Bruce Momjian wrote: Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I