Re: [PATCHES] pg_dump lock timeout

2008-07-21 Thread daveg
On Mon, Jul 21, 2008 at 03:43:11AM -0400, Tom Lane wrote: > daveg <[EMAIL PROTECTED]> writes: > > On Sun, Jul 20, 2008 at 02:50:50PM -0400, Tom Lane wrote: > >> In most cases our policy has been that pg_dumpall should accept and pass > >> through any pg_dump option for which it's sensible to do so.

Re: [PATCHES] pg_dump lock timeout

2008-07-21 Thread Tom Lane
daveg <[EMAIL PROTECTED]> writes: > On Sun, Jul 20, 2008 at 02:50:50PM -0400, Tom Lane wrote: >> In most cases our policy has been that pg_dumpall should accept and pass >> through any pg_dump option for which it's sensible to do so. I did not >> make that happen but it seems it'd be a reasonable f

Re: [PATCHES] pg_dump lock timeout

2008-07-21 Thread daveg
On Sun, Jul 20, 2008 at 02:50:50PM -0400, Tom Lane wrote: > daveg <[EMAIL PROTECTED]> writes: > > Here is an updated version of this patch against head. It builds, runs and > > functions as expected. I did not build the sgml. > > Applied with mostly minor cosmetic improvements --- the only actual

Re: [PATCHES] pg_dump lock timeout

2008-07-20 Thread Tom Lane
daveg <[EMAIL PROTECTED]> writes: > Here is an updated version of this patch against head. It builds, runs and > functions as expected. I did not build the sgml. Applied with mostly minor cosmetic improvements --- the only actual error I noticed was failing to check whether the server version supp

Re: [PATCHES] pg_dump lock timeout

2008-07-16 Thread daveg
Here is an updated version of this patch against head. It builds, runs and functions as expected. I did not build the sgml. I've made changes based on various comments as follows: - use WAIT_TIME in description consistantly. Reworded for clarity. (Stephan Frost) - Use a separate query b

Re: [PATCHES] pg_dump lock timeout

2008-07-16 Thread daveg
On Thu, Jul 03, 2008 at 05:55:01AM -0700, daveg wrote: > On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote: > > On 5/11/08, daveg <[EMAIL PROTECTED]> wrote: > > > Attached is a patch to add a commandline option to pg_dump to limit how > > > long > > > pg_dump will wait for locks during

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread Tom Lane
daveg <[EMAIL PROTECTED]> writes: > On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote: >> - The statement_timeout is set back with "statement_timeout = default" >> Maybe it would be better to do "= 0" here? Although such decision >> would go outside the scope of the patch, I see no sense

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread daveg
On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote: > On 5/11/08, daveg <[EMAIL PROTECTED]> wrote: > > Attached is a patch to add a commandline option to pg_dump to limit how > > long > > pg_dump will wait for locks during startup. > > My quick review: > > - It does not seem important

Re: [PATCHES] pg_dump lock timeout

2008-07-03 Thread Marko Kreen
On 5/11/08, daveg <[EMAIL PROTECTED]> wrote: > Attached is a patch to add a commandline option to pg_dump to limit how long > pg_dump will wait for locks during startup. My quick review: - It does not seem important enough to waste a short option on. Having only long option should be enough.

Re: [PATCHES] pg_dump lock timeout

2008-07-02 Thread David Fetter
On Sun, May 11, 2008 at 06:00:35AM -0700, David Gould wrote: > On Sun, May 11, 2008 at 04:30:47AM -0700, daveg wrote: > > > > Attached is a patch to add a commandline option to pg_dump to > > limit how long pg_dump will wait for locks during startup. > > Ooops, really attached this time. Can we

Re: [PATCHES] pg_dump lock timeout - resend

2008-05-17 Thread Euler Taveira de Oliveira
Joshua D. Drake wrote: The pages could certainly stand an updating to reflect how development currently commences. I will work up a patch next week. IMHO, this development information needs to be at [1]. [1] http://www.postgresql.org/developer/roadmap -- Euler Taveira de Oliveira http:

Re: [PATCHES] pg_dump lock timeout - resend

2008-05-17 Thread Joshua D. Drake
daveg wrote: On Sat, May 17, 2008 at 06:55:27PM -0300, Euler Taveira de Oliveira wrote: daveg wrote: I originally sent this a week ago, but there was no response and I do not see it Nope. FYI, the right link is [1] and your patch [2] is in the queue for July Commit Fest. [1] http://wiki.po

Re: [PATCHES] pg_dump lock timeout - resend

2008-05-17 Thread daveg
On Sat, May 17, 2008 at 06:55:27PM -0300, Euler Taveira de Oliveira wrote: > daveg wrote: > > >I originally sent this a week ago, but there was no response and I do not > >see it > > > Nope. FYI, the right link is [1] and your patch [2] is in the queue for > July Commit Fest. > > [1] http://wiki

Re: [PATCHES] pg_dump lock timeout - resend

2008-05-17 Thread Euler Taveira de Oliveira
daveg wrote: I originally sent this a week ago, but there was no response and I do not see it Nope. FYI, the right link is [1] and your patch [2] is in the queue for July Commit Fest. [1] http://wiki.postgresql.org/wiki/Development_information [2] http://wiki.postgresql.org/wiki/CommitFest:J

Re: [PATCHES] pg_dump lock timeout

2008-05-11 Thread daveg
On Sun, May 11, 2008 at 04:30:47AM -0700, daveg wrote: > > Attached is a patch to add a commandline option to pg_dump to limit how long > pg_dump will wait for locks during startup. Ooops, really attached this time. -dg -- David Gould [EMAIL PROTECTED] 510 536 1443510 282 0869