Jorgen Austvik - Sun Norway <[EMAIL PROTECTED]> writes:
> this patch should only move the stat operation into
> convert_sourcefiles_in().
Applied, thanks.
regards, tom lane
---(end of broadcast)---
TIP 9: In versions below
Jorgen Austvik wrote:
Maybe push the stat operation inside convert_sourcefiles_in ?
Yes, that was what I tried to do in the patch, but unfortunately I was
too eager :) I'll send a new proposal tomorrow. Thanks for your help!
Hi,
this patch should only move the stat operation into
convert_s
Tom Lane wrote:
Ah. The reason this works in VPATH mode is that setup of the build tree
duplicated all subdirectories of the source tree, so ./input/ should
exist iff $srcdir/input/ does. I agree it's a bit ugly though; it'd
be better to stat what we really plan to read.
Maybe push the stat op
Jorgen Austvik <[EMAIL PROTECTED]> writes:
> But if we have set srcdir, the directory we are stat'ing, is not the
> same directory that we are reading the files from:
Ah. The reason this works in VPATH mode is that setup of the build tree
duplicated all subdirectories of the source tree, so ./in
Tom Lane wrote:
Jorgen Austvik <[EMAIL PROTECTED]> writes:
Tom Lane wrote:
Actually, it looks to me like the patch is wrong specifically because
it does not do the right thing in the VPATH case.
Are you thinking about "failing if the folders are missing" as "not the
right thing in the VPATH
Jorgen Austvik <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> Actually, it looks to me like the patch is wrong specifically because
>> it does not do the right thing in the VPATH case.
> Are you thinking about "failing if the folders are missing" as "not the
> right thing in the VPATH case", or
Tom Lane wrote:
Alvaro Herrera <[EMAIL PROTECTED]> writes:
I didn't check the rest of the patch, but did you verify that it still
works in VPATH builds?
Actually, it looks to me like the patch is wrong specifically because
it does not do the right thing in the VPATH case.
Are you thinking ab
Alvaro Herrera wrote:
Jorgen Austvik - Sun Norway wrote:
This patch will also make pg_regress fail if the directories are
missing, instead of silently ignoring the missing directories. If you
think this fail-fast behavior is undesirable, I can create a patch
that just ignores the files (todays
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> I didn't check the rest of the patch, but did you verify that it still
> works in VPATH builds?
Actually, it looks to me like the patch is wrong specifically because
it does not do the right thing in the VPATH case.
regards, tom
Jorgen Austvik - Sun Norway wrote:
> This patch will also make pg_regress fail if the directories are
> missing, instead of silently ignoring the missing directories. If you
> think this fail-fast behavior is undesirable, I can create a patch
> that just ignores the files (todays behavior), or ign
10 matches
Mail list logo
