Re: [PATCHES] txid strtoull fix

2007-10-08 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 10/8/07, Tom Lane <[EMAIL PROTECTED]> wrote: >> (Note that your overflow test didn't actually work; AFAIK there >> really isn't any decent solution other than dividing at each step.) > Hmm. It did seem to work here. Just in case I peeked into > Free

Re: [PATCHES] txid strtoull fix

2007-10-08 Thread Marko Kreen
On 10/8/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Marko Kreen" <[EMAIL PROTECTED]> writes: > > I noticed strtoull() causes problems on some buildfarm > > machines. As a fix I propose small str2num function inside > > txid.c itself. Main reason is that the txid actually does > > not need fully-fe

Re: [PATCHES] txid strtoull fix

2007-10-08 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > I noticed strtoull() causes problems on some buildfarm > machines. As a fix I propose small str2num function inside > txid.c itself. Main reason is that the txid actually does > not need fully-featured strtoull (radixes, whitespace skipping). Seems lik