Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-05 Thread Esteban Lorenzano
yes, I will do it now :) On 05 May 2015, at 13:22, Sean P. DeNigris s...@clipperadams.com wrote: Sean P. DeNigris wrote - Issue 15475: TxText Cleanup for Pharo 5.0 #2 Okay to include? I'd like to resume cleaning but don't want to get too deep before some of this gets integrated...

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-05 Thread Sean P. DeNigris
Sean P. DeNigris wrote - Issue 15475: TxText Cleanup for Pharo 5.0 #2 Okay to include? I'd like to resume cleaning but don't want to get too deep before some of this gets integrated... - Cheers, Sean -- View this message in context:

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-05 Thread Sean P. DeNigris
EstebanLM wrote yes, I will do it now :) - Issue 15475: TxText Cleanup for Pharo 5.0 #2 Okay to include? I'd like to resume cleaning but don't want to get too deep before some of this gets integrated... Thanks for integrating :) Sorry! I listed the older issue by mistake. The latest is:

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-05 Thread Esteban Lorenzano
ha, I knew it.. ok, integrating :P On 05 May 2015, at 16:26, Sean P. DeNigris s...@clipperadams.com wrote: EstebanLM wrote yes, I will do it now :) - Issue 15475: TxText Cleanup for Pharo 5.0 #2 Okay to include? I'd like to resume cleaning but don't want to get too deep before some of

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-04 Thread Camille
On 03 May 2015, at 06:25, Sean P. DeNigris s...@clipperadams.com wrote: Questions first: - TxModel class comment - I don't provide a direct interface for mutating/editing my data (and this is a very important point). Instead I am modified using position(s) (TxTextPosition) and/or

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-04 Thread Camille
On 03 May 2015, at 06:27, Sean P. DeNigris s...@clipperadams.com wrote: Sean P. DeNigris wrote Questions first: Oh I forgot these... - Why TxBasicSpan instead of just TxSpan? TxAbstractSpan? - TxModel has 4 nearly identical methods for selection - #newSelection, #select, #selectAll,

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-04 Thread Sean P. DeNigris
Thanks for the answers! I'll add them to the roadmap... camille teruel wrote you cannot provide operations that take indexes... Instead you use positions/cursors and intervals/selections because they know to which spans they correspond. I guess it makes sense because the model can just

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-04 Thread Sean P. DeNigris
Sean P. DeNigris wrote Sean P. DeNigris wrote a bit of cleaning... Issue 15475: TxText Cleanup for Pharo 5.0 #2 Finally passed validation! Okay to include? Now there are: - Issue 15475: TxText Cleanup for Pharo 5.0 #2 - Issue 15481: TxText Cleanup for Pharo 5.0 #3 Both have passed

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-03 Thread Sean P. DeNigris
Sean P. DeNigris wrote a bit of cleaning... Issue 15475: TxText Cleanup for Pharo 5.0 #2 Finally passed validation! Okay to include? - Cheers, Sean -- View this message in context: http://forum.world.st/TxText-More-Cleaning-and-Questions-tp4823894p4824054.html Sent from the Pharo

Re: [Pharo-dev] TxText: More Cleaning and Questions

2015-05-02 Thread Sean P. DeNigris
Sean P. DeNigris wrote Questions first: Oh I forgot these... - Why TxBasicSpan instead of just TxSpan? - TxModel has 4 nearly identical methods for selection - #newSelection, #select, #selectAll, and #selection. How do we pare that down? - Cheers, Sean -- View this message in context: