Re: [Pharo-dev] Executive Summary of the recent FileStream Changes

2018-03-15 Thread Nicolas Cellier
Very good initiative! It's worth a few hick-ups. I've tried to reduce RWBinaryOrTextStream usage in Squeak maybe 10 years ago, but you know it very well, the last places which are resisting are the more intricated and convoluted. I call it the SwiisKnifeStream and allways wandered why we would

[Pharo-dev] Executive Summary of the recent FileStream Changes

2018-03-15 Thread Sven Van Caekenberghe
Executive Summary of the recent FileStream Changes In Pharo 7 Guille Polito recently committed a heroic set of changes that we were planning to do for a long time but were afraid to take on. The idea is to replace a couple of fat, overly complex, multi-functional, do-all classes with a set of

[Pharo-dev] FileHandle creates a buffered stream on a buffered stream

2018-03-15 Thread Sven Van Caekenberghe
Hi (Guille), FileHandle creates a buffered stream on a buffered stream when sent #readStream. Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded: Probably the latter should not do this Sven

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Marcus Denker
-> better structure -> simplified the large print (no need to talk about downloading zip files) TODO: - add back a section about downloading images. > On 14 Mar 2018, at 18:18, Marcus Denker wrote: > > Ok, I will fix that in the next pass. > >> On 9 Mar 2018,

Re: [Pharo-dev] Pharo 7 new file stream encoders

2018-03-15 Thread Sven Van Caekenberghe
I think the idea is to use ZnCrPortableWriteStream for that. > On 15 Mar 2018, at 14:58, Thierry Goubier wrote: > > Hi all, > > how does one create a file stream in Pharo 7 that forces a specific > line end convention ? For example, for forcing all end of lines to be

[Pharo-dev] Pharo 7 new file stream encoders

2018-03-15 Thread Thierry Goubier
Hi all, how does one create a file stream in Pharo 7 that forces a specific line end convention ? For example, for forcing all end of lines to be Character lf. The old way, fileStream lineEndConvention: #'lf'. does not work anymore. Thanks, Thierry

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Sven Van Caekenberghe
And in PNGReadWriter>>nextImage we should remove stream reset and stream binary. This probably goes for the other image readers as well. > On 15 Mar 2018, at 13:38, Sven Van Caekenberghe wrote: > > Yeah, right, good catch. > > But what is this nonsense: > > PNGReadWriter>>on:

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Sven Van Caekenberghe
Yeah, right, good catch. But what is this nonsense: PNGReadWriter>>on: aStream (stream := aStream) reset. stream binary "Note that 'reset' makes a file be text. Must do this after." Of course you can only read an image from a binary stream, there should be nothing

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Alistair Grant
Also: 'apicture.png' asFileReference inspect. Will raise a "image format not recognised" because: - AbstractFileReference>>binaryReadStreamDo: ultimately uses a ZnBufferedReadStream - ImageReadWriter>>on: sends #reset to the stream and ZnBufferedReadStream doesn't implement #reset. My guess

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Sven Van Caekenberghe
BTW, for the record, we should deprecate Base64MimeConverter, and remove/change the following convenience methods: Remove String>>#base64Encoded. Change ByteArray>>#base64Encoded "Encode the receiver using Base64, see ZnBase64Encoder" ^ ZnBase64Encoder new encode:

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Alistair Grant
Hi Sven, On 15 March 2018 at 12:47, Sven Van Caekenberghe wrote: > > >> On 15 Mar 2018, at 12:28, Alistair Grant wrote: >> >> Hi Guille & Pavel, >> >> On 6 Feb Guille changed Base64MimeConverter class>>mimeDecodeToBytes: >> so that it doesn't reset the

Re: [Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Sven Van Caekenberghe
> On 15 Mar 2018, at 12:28, Alistair Grant wrote: > > Hi Guille & Pavel, > > On 6 Feb Guille changed Base64MimeConverter class>>mimeDecodeToBytes: > so that it doesn't reset the dataStream position back to the start of > the stream. This breaks Pavel's PlayingCard,

[Pharo-dev] Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load

2018-03-15 Thread Alistair Grant
Hi Guille & Pavel, On 6 Feb Guille changed Base64MimeConverter class>>mimeDecodeToBytes: so that it doesn't reset the dataStream position back to the start of the stream. This breaks Pavel's PlayingCard, part of FreeCell (you can see that I only load important stuff :-)). PlayingCard

Re: [Pharo-dev] [Pharo-users] Something is happening...

2018-03-15 Thread Nicolas Anquetil
On 15/03/2018 10:31, Marcus Denker wrote: [...] What I would like to have is a way to count “currently running images”. But I guess adding that by default (like all mobile apps now do) would not be wanted.. but one could add some config option. spotter has it and nobody complained as it is

Re: [Pharo-dev] [Pharo-users] Something is happening...

2018-03-15 Thread Marcus Denker
> On 14 Mar 2018, at 19:02, Esteban A. Maringolo wrote: > > Do we have any metrics on the number of visits we get on the pharo.org > website, which parts are the most visited, etc? > Yes, we have Google Analytics installed… but I did not look at it for a long time. It

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Esteban Lorenzano
> On 15 Mar 2018, at 09:34, Marcus Denker wrote: > > > >> On 15 Mar 2018, at 09:27, Esteban Lorenzano > > wrote: >> >> >> >>> On 15 Mar 2018, at 00:08, Cyril Ferlicot >>

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Marcus Denker
> On 15 Mar 2018, at 09:27, Esteban Lorenzano wrote: > > > >> On 15 Mar 2018, at 00:08, Cyril Ferlicot > > wrote: >> >> >> On mer. 14 mars 2018 at 18:18, Marcus Denker >

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Esteban Lorenzano
> On 15 Mar 2018, at 00:08, Cyril Ferlicot wrote: > > > On mer. 14 mars 2018 at 18:18, Marcus Denker > wrote: > > > > On 9 Mar 2018, at 23:34, Torsten Bergmann > >

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Marcus Denker
> On 15 Mar 2018, at 00:08, Cyril Ferlicot wrote: > > > On mer. 14 mars 2018 at 18:18, Marcus Denker > wrote: > > > > On 9 Mar 2018, at 23:34, Torsten Bergmann > >

Re: [Pharo-dev] Experiment: New Download page based on Pharo Launcher

2018-03-15 Thread Stephan Eggermont
Marcus Denker wrote: >> On 9 Mar 2018, at 23:34, Torsten Bergmann wrote: >> >> Additional portable versions would be nice too (based on a simple ZIP) >> instead of only the installable apps >> > > Is there a deeper reason for this? If I look at “other