[Pharo-dev] [Pharo 8.0] Build #668: 4403-cannot-change-position-in-a-memory-write-stream

[ci-pharo-ci-jenkins2]

There is a new Pharo build available!
  
The status of the build #668 was: SUCCESS.

The Pull Request #4404 was integrated: 
"4403-cannot-change-position-in-a-memory-write-stream"
Pull request url: https://github.com/pharo-project/pharo/pull/4404

Issue Url: https://github.com/pharo-project/pharo/issues/4403
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/668/

[Pharo-dev] [Pharo 8.0] Build #667: 4406-fix-class-def-parser-for-simple-definitions

[ci-pharo-ci-jenkins2]

There is a new Pharo build available!
  
The status of the build #667 was: FAILURE.

The Pull Request #4409 was integrated: 
"4406-fix-class-def-parser-for-simple-definitions"
Pull request url: https://github.com/pharo-project/pharo/pull/4409

Issue Url: https://github.com/pharo-project/pharo/issues/4406
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/667/

Re: [Pharo-dev] Class definition with slot template is broken

[Marcus Denker]

> On 23 Aug 2019, at 12:43, Marcus Denker  wrote:
> 
> 
> 
>> On 23 Aug 2019, at 12:13, Denis Kudriashov > > wrote:
>> 
>> Hi
>> 
>> пт, 23 авг. 2019 г., 11:06 Marcus Denker > >:
>> 
>> 
>> > On 23 Aug 2019, at 11:49, Cyril Ferlicot > > > wrote:
>> > 
>> > Hi,
>> > 
>> > Since yesterday I get a lot of bugs when I try to edit class
>> > definitions while having the slot template in class definition
>> > enabled. (See comment:
>> > https://github.com/pharo-project/pharo/pull/4391 
>> > )
>> > This make it a little hard to develop :(
>> > 
>> > Is there an easy fix? Else maybe we should revert the change until we
>> > have the fix?
>> > 
>> 
>> I have a fix, I will commit when the internet connection is good enough
>> 
>> That's good.
> 
> https://github.com/pharo-project/pharo/pull/4409 
> 
> 
> 
>> 
>> I guess it was a class parser bug? I only tested browser with classic 
>> definition.
> 
> yes, even with this fix I need to do some (larger) change to support Slots 
> with parameters, e.g.
> 
>   {#lazy => LazySlot default: 5 .
>  #computed => ComputedSlot with: [:object | object 
> calculateSomething] }
> 
> 

I updated the fix: now it should work, there will be just no menu shown for 
these kinds of slots for now
(to be fixed in a second step, we should add tests, too)

Marcus

Re: [Pharo-dev] Class definition with slot template is broken

[Marcus Denker]

> On 23 Aug 2019, at 12:13, Denis Kudriashov  wrote:
> 
> Hi
> 
> пт, 23 авг. 2019 г., 11:06 Marcus Denker  >:
> 
> 
> > On 23 Aug 2019, at 11:49, Cyril Ferlicot  > > wrote:
> > 
> > Hi,
> > 
> > Since yesterday I get a lot of bugs when I try to edit class
> > definitions while having the slot template in class definition
> > enabled. (See comment:
> > https://github.com/pharo-project/pharo/pull/4391 
> > )
> > This make it a little hard to develop :(
> > 
> > Is there an easy fix? Else maybe we should revert the change until we
> > have the fix?
> > 
> 
> I have a fix, I will commit when the internet connection is good enough
> 
> That's good.

https://github.com/pharo-project/pharo/pull/4409 



> 
> I guess it was a class parser bug? I only tested browser with classic 
> definition.

yes, even with this fix I need to do some (larger) change to support Slots with 
parameters, e.g.

{#lazy => LazySlot default: 5 .
 #computed => ComputedSlot with: [:object | object calculateSomething] }


This need some change in how the class parser models slots, though… CDSlotNode 
is just modelling a name and the class of the slot, but not the fact
that slot definitions can contain parameters which can contain even blocks…

and with composition (not yet in Pharo8), we need to support things like

#lazyAndObservable => SpObservableSlot +  LazySlot default: 5 .

but I think it is not hard to do. 

Marcus

Re: [Pharo-dev] Class definition with slot template is broken

[Denis Kudriashov]

Hi

пт, 23 авг. 2019 г., 11:06 Marcus Denker :

>
>
> > On 23 Aug 2019, at 11:49, Cyril Ferlicot 
> wrote:
> >
> > Hi,
> >
> > Since yesterday I get a lot of bugs when I try to edit class
> > definitions while having the slot template in class definition
> > enabled. (See comment:
> > https://github.com/pharo-project/pharo/pull/4391)
> > This make it a little hard to develop :(
> >
> > Is there an easy fix? Else maybe we should revert the change until we
> > have the fix?
> >
>
> I have a fix, I will commit when the internet connection is good enough
>

That's good.

I guess it was a class parser bug? I only tested browser with classic
definition.


> Marcus
>
>
>

Re: [Pharo-dev] Class definition with slot template is broken

[Marcus Denker]

> On 23 Aug 2019, at 11:49, Cyril Ferlicot  wrote:
> 
> Hi,
> 
> Since yesterday I get a lot of bugs when I try to edit class
> definitions while having the slot template in class definition
> enabled. (See comment:
> https://github.com/pharo-project/pharo/pull/4391)
> This make it a little hard to develop :(
> 
> Is there an easy fix? Else maybe we should revert the change until we
> have the fix?
> 

I have a fix, I will commit when the internet connection is good enough

Marcus

Re: [Pharo-dev] Class definition with slot template is broken

[ducasse]

Argh this is probably the changes using the class definition. 
Denis can you check?
Else I will check how to revert it and wait that it becoming more ready. 

Stef

> On 23 Aug 2019, at 11:49, Cyril Ferlicot  wrote:
> 
> Hi,
> 
> Since yesterday I get a lot of bugs when I try to edit class
> definitions while having the slot template in class definition
> enabled. (See comment:
> https://github.com/pharo-project/pharo/pull/4391)
> This make it a little hard to develop :(
> 
> Is there an easy fix? Else maybe we should revert the change until we
> have the fix?
> 
> Have a nice day!
> 
> -- 
> Cyril Ferlicot
> https://ferlicot.fr
> 

[Pharo-dev] Class definition with slot template is broken

[Cyril Ferlicot]

Hi,

Since yesterday I get a lot of bugs when I try to edit class
definitions while having the slot template in class definition
enabled. (See comment:
https://github.com/pharo-project/pharo/pull/4391)
This make it a little hard to develop :(

Is there an easy fix? Else maybe we should revert the change until we
have the fix?

Have a nice day!

-- 
Cyril Ferlicot
https://ferlicot.fr