Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Besides other action, in parallel perhaps the first step would be displaying a QA tip? cheers -ben On Mon, Jun 5, 2017 at 3:26 AM, Cyril Ferlicot D. wrote: > Le 04/06/2017 à 18:20, Eliot Miranda a écrit : > > Hi Cyril, > > > > Hi Eliot, > > > > > As Minty points out,

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

2017-06-04 21:28 GMT+02:00 Cyril Ferlicot D. : > Le 04/06/2017 à 21:26, Cyril Ferlicot D. a écrit : > > For this problem I would like to see all the smalltalks using SUnit > > change this behaviour. I really do not want to break compatibility and I > > think this change

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Le 04/06/2017 à 21:26, Cyril Ferlicot D. a écrit : > For this problem I would like to see all the smalltalks using SUnit > change this behaviour. I really do not want to break compatibility and I > think this change is important for the usability of SUnit. I don't have > much contact with other

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Le 04/06/2017 à 18:20, Eliot Miranda a écrit : > Hi Cyril, > Hi Eliot, > > As Minty points out, this unintuitive behaviour exists fur a reason and there > is a work around. > > SUnit is a community wide package existing in all the dialects of Smalltalk > I'm aware of. If you change the

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

2017-06-04 15:32 GMT+02:00 Denis Kudriashov : > > 2017-06-04 15:03 GMT+02:00 Cyril Ferlicot D. : > >> If most people agree that we should inherit the tests by default I think >> this is a change that should be done very early in the Pharo 7 dev.

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Hi Cyril, > On Jun 3, 2017, at 5:50 PM, Cyril Ferlicot D. > wrote: > >> Le 04/06/2017 à 02:26, monty a écrit : >> I've seen this before, and I'm not sure it's a bug. >> >> A testless, non-abstract subclass of a TestCase is useless unless it >> inherits test

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

2017-06-04 15:03 GMT+02:00 Cyril Ferlicot D. : > If most people agree that we should inherit the tests by default I think > this is a change that should be done very early in the Pharo 7 dev. Thus > it would let time to people to adapt their project. > I agree :)

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Le 04/06/2017 à 12:38, monty a écrit : > I agree with you, and I would rather subclasses inherit tests by default, but > be aware that this isn't a bug[1], and changing it will temporarily break > some test hierarchies. > > [1] >

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

/TestCase.class/class/shouldInheritSelectors.st > Sent: Saturday, June 03, 2017 at 8:50 PM > From: "Cyril Ferlicot D." <cyril.ferli...@gmail.com> > To: pharo-dev@lists.pharo.org > Subject: Re: [Pharo-dev] Abstract test classes are not managed well in SUnit > > Le

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

> On 4 Jun 2017, at 02:50, Cyril Ferlicot D. wrote: > > Le 04/06/2017 à 02:26, monty a écrit : >> I've seen this before, and I'm not sure it's a bug. >> >> A testless, non-abstract subclass of a TestCase is useless unless it >> inherits test methods. But if it

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

Le 04/06/2017 à 02:26, monty a écrit : > I've seen this before, and I'm not sure it's a bug. > > A testless, non-abstract subclass of a TestCase is useless unless it inherits > test methods. But if it defines its own test methods, then it isn't clear if > it was made a subclass to inherit test

Re: [Pharo-dev] Abstract test classes are not managed well in SUnit

lt;pharo-dev@lists.pharo.org> > Subject: [Pharo-dev] Abstract test classes are not managed well in SUnit > > Hi, > > Today I found a bug in SUnit. > > Sometimes when you have an abstract test class and you override it the > tests will be inherit or not. > > I

[Pharo-dev] Abstract test classes are not managed well in SUnit

Hi, Today I found a bug in SUnit. Sometimes when you have an abstract test class and you override it the tests will be inherit or not. If a subclass has other tests, the tests will not be inherited. If the subclass has no other tests, the tests will be inherited. Here is a little script