[PHP-CVS] svn: /php/php-src/trunk/ NEWS

2010-11-23 Thread Andi Gutmans
andi Wed, 24 Nov 2010 04:31:45 + Revision: http://svn.php.net/viewvc?view=revisionrevision=305709 Log: - Fix typo Changed paths: U php/php-src/trunk/NEWS Modified: php/php-src/trunk/NEWS

RE: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c

2009-08-11 Thread Andi Gutmans
Sure. -Original Message- From: Derick Rethans [mailto:der...@php.net] Sent: Tuesday, August 11, 2009 2:11 AM To: Andi Gutmans Cc: php-cvs@lists.php.net; gwy...@php.net Subject: Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c On Sun, 9 Aug 2009, Andi Gutmans

[PHP-CVS] svn: /php/php-src/trunk/ README.UNICODE

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 03:39:15 + Revision: http://svn.php.net/viewvc?view=revisionrevision=286937 Log: - Fix small typo Changed paths: U php/php-src/trunk/README.UNICODE Modified: php/php-src/trunk/README.UNICODE

[PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_alloc.c

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 04:46:02 + Revision: http://svn.php.net/viewvc?view=revisionrevision=286940 Log: - Optimize slightly for common case - n!=4 Changed paths: U php/php-src/trunk/Zend/zend_alloc.c Modified: php/php-src/trunk/Zend/zend_alloc.c

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 04:46:30 + Revision: http://svn.php.net/viewvc?view=revisionrevision=286941 Log: - MFH Changed paths: U php/php-src/branches/PHP_5_3/Zend/zend_alloc.c Modified: php/php-src/branches/PHP_5_3/Zend/zend_alloc.c

[PHP-CVS] cvs: CVSROOT / avail

2009-03-22 Thread Andi Gutmans
andiMon Mar 23 02:32:49 2009 UTC Modified files: /CVSROOTavail Log: - Give ericstewart commit access to php-src for INI and test work http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1503r2=1.1504diff_format=u Index: CVSROOT/avail diff -u

RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-02 Thread Andi Gutmans
Ok will ask him to take a look when he's back. Cheers, Andi -Original Message- From: Marcus Boerger [mailto:he...@php.net] Sent: Friday, January 02, 2009 4:04 AM To: Andi Gutmans Cc: Marcus Boerger; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext

RE: [PHP-CVS] cvs: php-src(PHP_5_3) /main network.c

2009-01-02 Thread Andi Gutmans
Does this mean you should be using WSASetLastError() on Windows? Andi -Original Message- From: Felipe Pena [mailto:fel...@php.net] Sent: Friday, January 02, 2009 1:43 PM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /main network.c felipeFri

RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-01 Thread Andi Gutmans
Hi Marcus, I think dl() should also be disabled for FastCGI. It may require a bit of reordering of the code to make this work but I think it's the right thing. If you bump into any problems then maybe Dmitry could help out but he's on vacation for the next couple of weeks. Thanks! Andi

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 04:59:41 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre config.w32 Log: - Remove NO_RECURSE as it causes a huge performance impact. Up to 50% with Wordpress. Stack size is not really anymore of an issue than on Linux with

[PHP-CVS] cvs: php-src /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 05:00:04 2009 UTC Modified files: /php-src/ext/pcre config.w32 Log: - MF PHP_5_2 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/config.w32?r1=1.18r2=1.19diff_format=u Index: php-src/ext/pcre/config.w32 diff -u

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 05:00:35 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pcre config.w32 Log: - MF PHP_5_3 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/config.w32?r1=1.4.2.5.2.8r2=1.4.2.5.2.9diff_format=u Index: php-src/ext/pcre/config.w32 diff

[PHP-CVS] cvs: CVSROOT / avail

2008-11-02 Thread Andi Gutmans
andiSun Nov 2 16:46:02 2008 UTC Modified files: /CVSROOTavail Log: - Karma to Zend Engine tests for Felix De Vliegher http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1461r2=1.1462diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1461

[PHP-CVS] cvs: CVSROOT / avail

2008-08-11 Thread Andi Gutmans
andiMon Aug 11 19:41:57 2008 UTC Modified files: /CVSROOTavail Log: - Karma to commit tests for CURL. http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1433r2=1.1434diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1433 CVSROOT/avail:1.1434

RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd_priv.h

2007-10-27 Thread Andi Gutmans
Hi Andrey, Are you sure it's a good idea to replicate these macros? It kind of breaks the ability to tweak them in a central place. What's the reasoning for it? Andi -Original Message- From: Andrey Hristov [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 16, 2007 1:56 PM To:

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Weird, I'm pretty sure I created the branch for Chris in PECL. This is intentionally in a branch so that people can play around with it but without risking the stable branch. Chris, did you checkout pecl/oci8 or php-src/ext/oci8 before you commited? Andi -Original Message- From: Jani

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Yeah I also got confused for a sec :) -Original Message- From: Jani Taskinen [mailto:[EMAIL PROTECTED] Sent: Friday, October 05, 2007 4:38 PM To: Andi Gutmans Cc: Christopher Jones; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c

[PHP-CVS] cvs: CVSROOT / avail

2007-09-12 Thread Andi Gutmans
andiWed Sep 12 21:57:30 2007 UTC Modified files: /CVSROOTavail Log: - Enable Stas to help with CVS accounts http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1302r2=1.1303diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1302

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard basic_functions.c /ext/standard/tests/network ip.phpt

2007-08-20 Thread Andi Gutmans
There are some convenience functions in zend_operators.h which would save having to repeat this logic (I think they are called zend_binary_strcmp() and zend_binary_zval_strcmp()). Andi -Original Message- From: Antony Dovgal [mailto:[EMAIL PROTECTED] Sent: Thursday, August 16, 2007

[PHP-CVS] cvs: CVSROOT / avail

2007-05-02 Thread Andi Gutmans
andiWed May 2 17:48:57 2007 UTC Modified files: /CVSROOTavail Log: - Give access to ext/standard for writing tests http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1266r2=1.1267diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1266

[PHP-CVS] cvs: CVSROOT / avail

2007-03-07 Thread Andi Gutmans
andiWed Mar 7 19:52:57 2007 UTC Modified files: /CVSROOTavail Log: - Karma for Rajini Sivaram [EMAIL PROTECTED] to pecl/sdo http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1250r2=1.1251diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1250

[PHP-CVS] cvs: php-src(PHP_5_2) /sapi/cgi CREDITS

2007-02-14 Thread Andi Gutmans
andiWed Feb 14 08:12:27 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/sapi/cgi CREDITS Log: - Give Dmitry credit for all the FastCGI work http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/CREDITS?r1=1.2r2=1.2.20.1diff_format=u Index:

[PHP-CVS] cvs: php-src(PHP_5_2) /main/streams php_stream_transport.h

2007-02-04 Thread Andi Gutmans
andiMon Feb 5 05:15:16 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/main/streams php_stream_transport.h Log: - Make sure to be ANSI C compliant

[PHP-CVS] cvs: php-src /main/streams php_stream_transport.h

2007-02-04 Thread Andi Gutmans
andiMon Feb 5 05:15:49 2007 UTC Modified files: /php-src/main/streams php_stream_transport.h Log: - Make sure to be ANSI C compliant http://cvs.php.net/viewvc.cgi/php-src/main/streams/php_stream_transport.h?r1=1.14r2=1.15diff_format=u Index:

[PHP-CVS] cvs: CVSROOT / avail

2007-01-27 Thread Andi Gutmans
andiSat Jan 27 16:55:07 2007 UTC Modified files: /CVSROOTavail Log: - ext/com karma for Andy Wharmby who will help fix outstanding issues. http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1235r2=1.1236diff_format=u Index: CVSROOT/avail diff -u

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_close.c zip_open.c zip_source_file.c

2006-11-16 Thread Andi Gutmans
How come the b in fopen() doesn't work? -Original Message- From: Pierre-Alain Joye [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 15, 2006 11:14 AM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_close.c zip_open.c zip_source_file.c

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c

2006-11-16 Thread Andi Gutmans
Oops, didn't see this. -Original Message- From: Pierre [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 15, 2006 9:41 AM To: Dmitry Stogov Cc: Pierre-Alain Joye; php-cvs@lists.php.net; Wez Furlong Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c On

[PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2006-11-10 Thread Andi Gutmans
andiFri Nov 10 18:51:06 2006 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS Log: - Fix typo http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.355r2=1.2027.2.547.2.356diff_format=u Index: php-src/NEWS diff -u

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-08-26 Thread Andi Gutmans
I missed the discussion about this. Is there a bug in VCWD_REALPATH()? Can you explain? Thanks. -Original Message- From: Pierre-Alain Joye [mailto:[EMAIL PROTECTED] Sent: Saturday, August 26, 2006 5:24 AM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
Why is this important? We never defined these as static. As long as you move them to the .c file (for whatever reason you have that might be justified) you really don't have to define them as static IMO. -Original Message- From: Nuno Lopes [mailto:[EMAIL PROTECTED] Sent: Monday,

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
in handly with dlls. Andi -Original Message- From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] On Behalf Of Ilia Alshanetsky Sent: Saturday, August 26, 2006 9:59 AM To: Andi Gutmans Cc: 'Nuno Lopes'; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c

[PHP-CVS] RE: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard var.c /main main.c /sapi/apache mod_php5.c /sapi/apache2filter sapi_apache2.c /

2006-07-18 Thread Andi Gutmans
Didn't see this but I did :) Andi -Original Message- From: Andrei Zmievski [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 18, 2006 10:13 AM To: Dmitry Stogov Cc: php-cvs@lists.php.net; internals@lists.php.net Subject: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: [PHP-CVS]

Re: [PHP-CVS] cvs: php-src /ext/unicode php_transform.h transform.c unicode.c

2006-06-15 Thread Andi Gutmans
Thanks! At 10:37 AM 6/15/2006, Andrei Zmievski wrote: andrei Thu Jun 15 17:37:48 2006 UTC Modified files: /php-src/ext/unicodephp_transform.h transform.c unicode.c Log: Rename to str_transliterate().

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-14 Thread Andi Gutmans
. text_transliterate()? str_transliterate()? We've abandoned the idea of i18n_ prefix and unicode_ doesn't fit here either.. -Andrei On Jun 13, 2006, at 8:41 PM, Andi Gutmans wrote: As you know our naming conventions are module_function, e.g. unicode_transliterate, i18n_transliterate

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
Please fix the naming conventions... At 04:46 PM 6/13/2006, Andrei Zmievski wrote: andrei Tue Jun 13 23:46:04 2006 UTC Added files: /php-src/ext/unicodephp_transform.h transform.c Modified files: /php-src/ext/unicodeconfig.m4 config.w32 unicode.c Log:

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
. Thx. At 07:49 PM 6/13/2006, Andrei Zmievski wrote: What do you mean? -Andrei On Jun 13, 2006, at 5:45 PM, Andi Gutmans wrote: Please fix the naming conventions... -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c /ext/tidy tidy.c /ext/zlib zlib.c /main S

2006-06-03 Thread Andi Gutmans
Thanks! I missed the original email you sent with the patch which is why I didn't catch it earlier. At 04:19 AM 6/3/2006, Michael Wallner wrote: mikeSat Jun 3 11:19:44 2006 UTC Modified files: /php-src/ext/sessionsession.c /php-src/ext/soap soap.c

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /sapi/cgi cgi_main.c /sapi/cli php_cli.c

2006-06-03 Thread Andi Gutmans
Hey, I must have missed the discussion around this one. Why is it useless? How long has this feature existed? Thx. Andi At 03:02 PM 6/3/2006, Johannes Schlüter wrote: johannesSat Jun 3 22:02:02 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/sapi/cli

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Can you give a short summary of what the essence of the change is and how the APIs have changed (Both the ones available to the PHP developer and to the extension writer?) Thanks! Andi At 12:51 PM 6/2/2006, Michael Wallner wrote: mikeFri Jun 2 19:51:43 2006 UTC Added files:

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Btw, any reason why we need all those redefinition of functions? If it's just to save having to write TSRMLS_C then I'd prefer to remove those macros. They just make debugging harder, there's no real benefit and we've tried to be explicit in other places. The patch looks nice though although I

[PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2006-05-30 Thread Andi Gutmans
andiWed May 31 03:43:17 2006 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS Log: - Fix typo http://cvs.php.net/viewcvs.cgi/php-src/NEWS?r1=1.2027.2.547.2.66r2=1.2027.2.547.2.67diff_format=u Index: php-src/NEWS diff -u

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Andi Gutmans
Hartmut, This is a very odd name to be using and doesn't follow our naming conventions. Maybe something like sys_get_tmpdir()? Andi At 02:59 AM 5/6/2006, Hartmut Holzgraefe wrote: hholzgraSat May 6 09:59:02 2006 UTC Modified files: /php-srcNEWS

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Andi Gutmans
Either of these works for me. At 11:02 AM 5/7/2006, Pierre wrote: On 5/7/06, Antony Dovgal [EMAIL PROTECTED] wrote: On 07.05.2006 21:26, Wez Furlong wrote: sys_tmpdir()? I vote for sys_ as the prefix, as we've started down that path with sys_getloadavg(). Yeah, sys_tmpdir() sounds good.

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/standard php_smart_str.h

2006-05-02 Thread Andi Gutmans
Does smart_str realloc at the end? If not, then this patch can lead to much higher memory use. From our tests we found 5.1 to use more memory and this was part of the reason for some slowdown. Even if a micro benchmark can show this to be faster, for real world apps and the various CPUs we are

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /sapi/apache php_apache.c

2006-04-27 Thread Andi Gutmans
Shouldn't you use ZEND_DLIMPORT? It'd be much nicer and save us those #ifdef's Andi At 02:31 AM 4/26/2006, Edin Kadribasic wrote: edink Wed Apr 26 09:31:23 2006 UTC Modified files: (Branch: PHP_5_1) /php-src/sapi/apachephp_apache.c Log: Correctly

Re: [PHP-CVS] cvs: php-src /ext/unicode unicode.c /main main.c /main/streams filter.c streams.c ZendEngine2 zend.c zend_constants.c zend_globals.h zend_unicode.c zend_unicode.h

2006-03-26 Thread Andi Gutmans
We should namespaces these and all other unicode constants... + REGISTER_MAIN_LONG_CONSTANT(FROM_UNICODE, ZEND_FROM_UNICODE, CONST_PERSISTENT | CONST_CS); + REGISTER_MAIN_LONG_CONSTANT(TO_UNICODE, ZEND_TO_UNICODE, CONST_PERSISTENT | CONST_CS); At 05:48 PM 3/25/2006, Andrei

[PHP-CVS] cvs: php-src /ext/com_dotnet com_persist.c /ext/curl interface.c /ext/dbase dbase.c /ext/fdf fdf.c /ext/filepro filepro.c /ext/gd php_gd.h /ext/ming ming.c /ext/oci8 oci8_interface.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 00:55:21 2006 UTC Modified files: /php-src/ext/com_dotnet com_persist.c /php-src/ext/curl interface.c /php-src/ext/dbase dbase.c /php-src/ext/fdffdf.c /php-src/ext/fileprofilepro.c /php-src/ext/gd

[PHP-CVS] cvs: php-src /main fopen_wrappers.c main.c /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 01:10:13 2006 UTC Modified files: /php-src/main fopen_wrappers.c main.c /php-src/main/streams plain_wrapper.c Log: - Some more safe_mode nuking

[PHP-CVS] cvs: php-src /main fopen_wrappers.c fopen_wrappers.h /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 01:19:37 2006 UTC Modified files: /php-src/main fopen_wrappers.c fopen_wrappers.h /php-src/main/streams plain_wrapper.c Log: Nuke php_check_safe_mode_include_dir

[PHP-CVS] cvs: php-src /ext/curl interface.c /ext/openssl openssl.c /ext/standard file.c ftok.c iptc.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 03:07:39 2006 UTC Modified files: /php-src/ext/curl interface.c /php-src/ext/opensslopenssl.c /php-src/ext/standard file.c ftok.c iptc.c Log: - More safe_mode nuking

[PHP-CVS] cvs: php-src /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 03:41:25 2006 UTC Modified files: /php-src/main/streams plain_wrapper.c Log: - Fix according to Sara's reply http://cvs.php.net/viewcvs.cgi/php-src/main/streams/plain_wrapper.c?r1=1.61r2=1.62diff_format=u Index:

[PHP-CVS] cvs: php-src /ext/bz2 bz2.c /ext/dba dba.c /ext/exif exif.c /ext/ftp php_ftp.c /ext/gd gd.c /ext/hash hash.c hash_md.c hash_sha.c /ext/imap php_imap.c /ext/libxml libxml.c /ext/mime_

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 04:29:42 2006 UTC Modified files: /php-src/ext/bz2bz2.c /php-src/ext/dbadba.c /php-src/ext/exif exif.c /php-src/ext/ftpphp_ftp.c /php-src/ext/gd gd.c /php-src/ext/hash hash.c hash_md.c hash_sha.c

[PHP-CVS] cvs: php-src /ext/curl interface.c /ext/gd php_gd.h

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 05:05:42 2006 UTC Modified files: /php-src/ext/curl interface.c /php-src/ext/gd php_gd.h Log: - Couple of compile fixes. http://cvs.php.net/viewcvs.cgi/php-src/ext/curl/interface.c?r1=1.76r2=1.77diff_format=u Index:

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /ext/standard basic_functions.c basic_functions.h

2006-02-17 Thread Andi Gutmans
needs to be matched in phpweb. --Wez. Andi Gutmans wrote: Hey Wez, We should stick to coding standards for new functions. How about sys_getloadavg()? Andi At 02:49 PM 2/16/2006, Wez Furlong wrote: wez Thu Feb 16 22:49:13 2006 UTC Modified files: (Branch

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /ext/standard basic_functions.c basic_functions.h

2006-02-16 Thread Andi Gutmans
Hey Wez, We should stick to coding standards for new functions. How about sys_getloadavg()? Andi At 02:49 PM 2/16/2006, Wez Furlong wrote: wez Thu Feb 16 22:49:13 2006 UTC Modified files: (Branch: PHP_5_1) /php-srcconfigure.in /php-src/ext/standard

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / NEWS php.ini-dist php.ini-recommended

2006-02-08 Thread Andi Gutmans
Thanks. Sucks that this was missing :) At 03:43 PM 2/8/2006, Ilia Alshanetsky wrote: iliaa Wed Feb 8 23:43:48 2006 UTC Modified files: (Branch: PHP_5_1) /php-srcphp.ini-dist php.ini-recommended NEWS Log: Fixed bug #36334 (Added missing documentation about

Re: [PHP-CVS] cvs: php-src /ext/msession README config.m4 msession-test.php msession.c msessionapi.h php_msession.h reqclient.h

2006-01-30 Thread Andi Gutmans
Seems like your commit screwed up the copyright notice. Did you commit ancient code? :) - | Copyright (c) 1997-2006 The PHP Group| + | Copyright (c) 1997-2003 The PHP Group|

Re: [PHP-CVS] cvs: php-src /ext/reflection php_reflection.c /ext/reflection/tests 007.phpt

2006-01-27 Thread Andi Gutmans
OK in that case it's probably best not to add inconsistency and leave it this way. At 12:44 AM 1/25/2006, Marcus Boerger wrote: Hello Andi, it was Sebastians idea and he took the name from invokeArgs(). I don't care, so if you can sleep better with your proposal change both names and live

Re: [PHP-CVS] cvs: php-src / run-tests.php /ext/ctype ctype.c /ext/date php_date.c /ext/date/tests bug35143.phpt /ext/dom document.c node.c /ext/dom/tests dom002.phpt dom_set_attr_node.phpt /ext/

2006-01-17 Thread Andi Gutmans
Thanks! At 04:18 AM 1/17/2006, Dmitry Stogov wrote: dmitry Tue Jan 17 12:18:54 2006 UTC Modified files: /php-srcrun-tests.php /ZendEngine2zend.c zend.h zend_API.c zend_API.h zend_builtin_functions.c zend_compile.c

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/gd gd.c

2006-01-17 Thread Andi Gutmans
FYI, this actually breaks BC. A negative number evaluates to true. I don't think this change should be an issue but there might have been people who did a 0 check before. Anyone got a problem with the change? At 07:44 AM 1/17/2006, Pierre-Alain Joye wrote: pajoye Tue Jan 17 15:44:12

Re: [PHP-CVS] cvs: php-src / php.ini-dist php.ini-recommended

2005-12-30 Thread Andi Gutmans
At 04:20 AM 12/30/2005, Jani Taskinen wrote: -; which should be instantiated. +; which should be instanciated. Hey, You introduced a typo. The previous version was fine. Andi -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-22 Thread Andi Gutmans
Are you sure you want to fix it this way? It'll make things less maintainable. I'm sure there's a way to make it one implementation that works everywhere. At 01:36 PM 12/20/2005, Marcus Boerger wrote: helly Tue Dec 20 21:36:48 2005 EDT Modified files: /php-src/ext/spl

Re: [PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-22 Thread Andi Gutmans
It's hard for me to believe though that memset() plus copying some values is noticeably slower. For such small structures I doubt it has any impact on the SPL Iterator performance (you're allocating on stack so allocation is not an issue). You can keep it this way, but my $.02 would be to only

Re: [PHP-CVS] cvs: php-src /ext/reflection config.m4

2005-11-18 Thread Andi Gutmans
As I mentioned to Marcus, it seems odd to me to move reflection in the first place. It seems to me to be very much a language feature and in my opinion, should always be enabled. I can't really see a good reason for this move. Andi At 07:40 AM 11/18/2005, Derick Rethans wrote: On Fri, 18

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/libxml libxml.c

2005-10-17 Thread Andi Gutmans
Hey Rob, This looks a bit strange (although it probably works :) Andi At 01:34 PM 10/13/2005, Rob Richards wrote: + context = context = php_libxml_streams_IO_open_write_wrapper(URI); Zend/PHP Conference Expo Power Your Business with PHP October 18-21, 2005 - San Francisco

Re: [PHP-CVS] cvs: php-src / NEWS /sapi/apache2handler sapi_apache2.c

2005-10-17 Thread Andi Gutmans
I don't see a reason why not to also commit critical patches to 5.0.x. I believe we will still have 5.0.6, especially due to the reference fixes, and who knows if we have security problems, we might have more in future. The fact that Jani and you aren't using 5.0 doesn't mean we

Re: [PHP-CVS] cvs: php-src / NEWS /sapi/apache2handler sapi_apache2.c

2005-10-17 Thread Andi Gutmans
Thanks! Will verify it works. At 12:36 PM 10/17/2005, Rasmus Lerdorf wrote: Andi Gutmans wrote: I don't see a reason why not to also commit critical patches to 5.0.x. I believe we will still have 5.0.6, especially due to the reference fixes, and who knows if we have security problems, we

Re: [PHP-CVS] cvs: php-src(PHP_4_4) /ext/standard base64.c

2005-08-26 Thread Andi Gutmans
Is this going to break apps that relied on this behavior? At 08:33 PM 8/25/2005, Ilia Alshanetsky wrote: iliaa Thu Aug 25 23:33:08 2005 EDT Modified files: (Branch: PHP_4_4) /php-src/ext/standard base64.c Log: MFH: Fixed bug #34214 (base64_decode() does

Re: [PHP-CVS] cvs: php-src /ext/ming config.m4

2005-08-25 Thread Andi Gutmans
Yes, I think it can be safely MFH'ed. Thanks. At 01:52 PM 8/25/2005, Marcus Boerger wrote: Hello RMs, should this be MFHed to 5.0.5 and 5.1.0 ? marcus Thursday, August 25, 2005, 10:49:49 PM, you wrote: helly Thu Aug 25 16:49:49 2005 EDT Modified files:

Re: [PHP-CVS] cvs: php-src /ext/zlib zlib.c

2005-08-25 Thread Andi Gutmans
How are we doing with this? Is it a new bug in 5.0.5 and 5.1.0? At 12:06 PM 8/24/2005, Xuefer wrote: this patch produce bug: http://bugs.php.net/bug.php?id=34240 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src / unicode-progress.txt /ext/standard dir.c dns.c filestat.c info.c link.c string.c type.c uniqid.c /ext/standard/tests/file userdirstream.phpt /ext/standard/tests/strings

2005-08-23 Thread Andi Gutmans
What's the RT in add_property_rt_string_ex? Maybe should make it more verbose so that mortals like me can understand it? At 05:53 AM 8/23/2005, Dmitry Stogov wrote: dmitry Tue Aug 23 08:53:32 2005 EDT Modified files: /php-srcunicode-progress.txt /ZendEngine2

Re: [PHP-CVS] cvs: php-src /ext/standard php_string.h string.c

2005-08-16 Thread Andi Gutmans
In-Reply-To: [EMAIL PROTECTED] Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed why do we need this? shouldn't the return type be the same as the string...? At 06:02 AM 8/16/2005 +, Rolland Santimano wrote: rolland Tue Aug 16 02:02:57 2005 EDT Modified

Re: [PHP-CVS] cvs: php-src /ext/simplexml simplexml.c /ext/standard http_fopen_wrapper.c

2005-08-16 Thread Andi Gutmans
never mind. i thought you were changing a PHP function :) At 06:05 AM 8/16/2005 +, Rolland Santimano wrote: rolland Tue Aug 16 02:05:00 2005 EDT Modified files: /php-src/ext/simplexml simplexml.c /php-src/ext/standard http_fopen_wrapper.c Log: Updated calls

Re: [PHP-CVS] cvs: php-src /ext/standard md5.c /ext/standard/tests/strings explode.phpt strcspn.phpt strspn.phpt strstr.phpt

2005-08-16 Thread Andi Gutmans
Shouldn't we have a macro that does this? I see lots of places that require the same code. - RETVAL_STRING(md5str, 1); + if (UG(unicode)) { + UChar *u_temp = zend_ascii_to_unicode(md5str, 33 ZEND_FILE_LINE_CC); +

RE: [PHP-CVS] cvs: php-src /ext/standard md5.c /ext/standard/tests/strings explode.phpt strcspn.phpt strspn.phptstrstr.phpt

2005-08-16 Thread Andi Gutmans
(runrime_encoding)). Dmitry. -Original Message- From: Andi Gutmans [mailto:[EMAIL PROTECTED] Sent: Wednesday, August 17, 2005 4:54 AM To: Dmitry Stogov; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src /ext/standard md5.c /ext/standard/tests/strings explode.phpt strcspn.phpt

Re: [PHP-CVS] cvs: php-src / README.PEAR

2005-08-15 Thread Andi Gutmans
Cool! This will make our lives easier. At 10:16 PM 8/15/2005 +, Pierre-Alain Joye wrote: pajoye Mon Aug 15 18:16:02 2005 EDT Added files: /php-srcREADME.PEAR Log: - add a little doc to redirect people to go-pear

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/ming ming.c

2005-08-11 Thread Andi Gutmans
Thx. At 03:54 AM 8/11/2005 +, Frank M. Kromann wrote: fmk Wed Aug 10 23:54:07 2005 EDT Modified files: (Branch: PHP_5_1) /php-src/ext/ming ming.c Log: Revert the last patch so we can release PHP 5.1

[PHP-CVS] cvs: php-src / php.ini-dist php.ini-recommended

2005-08-11 Thread Andi Gutmans
andiFri Aug 12 01:30:07 2005 EDT Modified files: /php-srcphp.ini-dist php.ini-recommended Log: - Add unicode INI settings http://cvs.php.net/diff.php/php-src/php.ini-dist?r1=1.231r2=1.232ty=u Index: php-src/php.ini-dist diff -u

[PHP-CVS] cvs: php-src(PHP_5_1) / NEWS

2005-08-09 Thread Andi Gutmans
andiTue Aug 9 18:23:04 2005 EDT Modified files: (Branch: PHP_5_1) /php-srcNEWS Log: - This didn't end up being included http://cvs.php.net/diff.php/php-src/NEWS?r1=1.2027.2.2r2=1.2027.2.3ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.2027.2.2

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard string.c /ext/standard/tests/strings stristr.phpt strstr.phpt

2005-08-09 Thread Andi Gutmans
Please use strlcpy() and not strncpy(). http://www.courtesan.com/todd/papers/strlcpy.html for more info PHP bundles this functionality... Andi At 08:49 PM 8/9/2005 +, Johannes Schlüter wrote: johannesTue Aug 9 16:49:19 2005 EDT Added files:

[PHP-CVS] cvs: php-src(PHP_5_1) / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-08-08 Thread Andi Gutmans
andiTue Aug 9 01:09:01 2005 EDT Modified files: (Branch: PHP_5_1) /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - RC1 http://cvs.php.net/diff.php/php-src/NEWS?r1=1.2027r2=1.2027.2.1ty=u Index:

[PHP-CVS] cvs: php-src(PHP_5_1) / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-08-08 Thread Andi Gutmans
andiTue Aug 9 01:40:56 2005 EDT Modified files: (Branch: PHP_5_1) /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - No release today. Found a critical bug...

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-02 Thread Andi Gutmans
It's really irrelevant. The fact that something isn't supported doesn't mean you should commit stuff which doesn't fit coding standards. At 04:22 AM 8/2/2005 +0200, Marcus Boerger wrote: Hello Andi, in the end we want class constants but right now we didn't commit that patch. marcus

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-01 Thread Andi Gutmans
Aren't these RIT constants against our coding standards? Might be too late now if it's in 5.0.x but we should stick to plan. Something like RECURSIVE_ITERATOR_SELF_FIRST Andi At 10:19 PM 7/27/2005 +, Marcus Boerger wrote: helly Wed Jul 27 18:19:02 2005 EDT Modified files:

Re: [PHP-CVS] cvs: php-src /main php_ini.c

2005-07-28 Thread Andi Gutmans
Is this a bug fix? Or added functionality? At 03:12 PM 7/27/2005 +, Hartmut Holzgraefe wrote: hholzgraWed Jul 27 11:12:19 2005 EDT Modified files: /php-src/main php_ini.c Log: php.ini search logic needs to use the absolute path of the running binary when

Re: [PHP-CVS] cvs: php-src /main php_ini.c

2005-07-28 Thread Andi Gutmans
Ok thanks. At 03:18 AM 7/29/2005 +0300, Jani Taskinen wrote: It's a fix. php.ini was looked in php/ when it should have been looked under /path-to-php-binary/ --Jani On Thu, 28 Jul 2005, Andi Gutmans wrote: Is this a bug fix? Or added functionality? At 03:12 PM 7/27/2005 +

Re: [PHP-CVS] cvs: php-src /ext/xsl/tests bug33853.phpt

2005-07-25 Thread Andi Gutmans
Never mind my previous email. I see it was the right bug # :) At 08:21 PM 7/25/2005 +, Marcus Boerger wrote: helly Mon Jul 25 16:21:45 2005 EDT Added files: /php-src/ext/xsl/tests bug33853.phpt Log: - Add new test

Re: [PHP-CVS] cvs: php-src /ext/mcve mcve.c php_mcve.h

2005-07-18 Thread Andi Gutmans
Brad, In any case, we are in a complete feature freeze right now. I sent an email about this to [EMAIL PROTECTED] Only bug fixes allowed. Please #if BRAD_0 that code in HEAD. I don't see a problem allowing the addition of such simple wrapper functions after 5.1.0 goes out the door; but I

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-07-14 Thread Andi Gutmans
andiThu Jul 14 09:44:03 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 3 http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1996r2=1.1997ty=u Index: php-src/NEWS diff

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-14 Thread Andi Gutmans
andiThu Jul 14 10:01:02 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/configure.in?r1=1.574r2=1.575ty=u Index:

Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-13 Thread Andi Gutmans
Is this a build error in Beta 3? Was just about to post it... Andi At 02:20 AM 7/14/2005 +, Wez Furlong wrote: wez Wed Jul 13 22:20:52 2005 EDT Modified files: /php-src/ext/pdo_mysql mysql_statement.c Log: gah!

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 15:59:53 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 3 http://cvs.php.net/diff.php/php-src/configure.in?r1=1.570r2=1.571ty=u Index:

Re: [PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
Hmm, I wonder where I got that from :) Good catch. At 10:33 PM 7/12/2005 +0200, Derick Rethans wrote: On Tue, 12 Jul 2005, Andi Gutmans wrote: http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1993r2=1.1994ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1993 php-src/NEWS:1.1994 --- php-src

[PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 16:40:11 2005 EDT Modified files: /php-srcNEWS Log: - Update Beta 3 date http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1994r2=1.1995ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1994 php-src/NEWS:1.1995 --- php-src/NEWS:1.1994 Tue

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
Is this a critical patch to include in Beta 3? Andi At 08:38 PM 7/12/2005 +, Antony Dovgal wrote: tony2001Tue Jul 12 16:38:35 2005 EDT Modified files: /php-src/ext/mysqli mysqli_fe.c php_mysqli.h Log: add forgotten ifdefs, fix #33667 (mysqli doesn't compile)

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
OK good. I'll reroll. Thanks. Andi At 12:50 AM 7/13/2005 +0400, Antony Dovgal wrote: On Tue, 12 Jul 2005 13:43:39 -0700 Andi Gutmans [EMAIL PROTECTED] wrote: Is this a critical patch to include in Beta 3? Yes, as ext/mysqli just doesn't compile without these ifdefs, if you have MySQL

Re: [PHP-CVS] cvs: php-src / NEWS /ext/ldap ldap.c

2005-07-08 Thread Andi Gutmans
Why do you need to convert_to_string_ex() if entry is a string? Should that be !=? At 12:46 AM 7/9/2005 +, Jani Taskinen wrote: + /* If anything else than string is passed, ldap_base_dn = NULL */ + if (Z_TYPE_PP(entry) ==

Re: [PHP-CVS] cvs: php-src /ext/pdo_pgsql pgsql_driver.c

2005-07-07 Thread Andi Gutmans
Oh, that's a different story then... At 01:54 PM 7/7/2005 +0800, Christopher Kings-Lynne wrote: It does impose a v7.4 and above libpq requirement, however. Chris Andi Gutmans wrote: Yeah, definitely seems like PQexecParams is the safest and easiest way of doing so. In general, I'm always

Re: [PHP-CVS] cvs: php-src /ext/pdo_pgsql pgsql_driver.c

2005-07-06 Thread Andi Gutmans
Yeah, definitely seems like PQexecParams is the safest and easiest way of doing so. In general, I'm always in favor of using bound parameters exactly for this reason. Andi At 10:44 AM 7/7/2005 +0800, Christopher Kings-Lynne wrote: By the way, using PQexecParams is by far the easiest fastest

Re: [PHP-CVS] cvs: php-src / NEWS

2005-07-02 Thread Andi Gutmans
Never mind. I see the bug # here. At 11:04 PM 7/2/2005 +, Edin Kadribasic wrote: edink Sat Jul 2 19:04:34 2005 EDT Modified files: /php-srcNEWS Log: BFN http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1971r2=1.1972ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1971

  1   2   3   4   >