[PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Xinchen Hui
Commit:9fb5cfdeb1f13f2e3ab3751494cdd366bc78cb38 Author:Xinchen Hui larue...@php.net Fri, 14 Dec 2012 17:21:43 +0800 Parents: 359d91a80756cd9a9ce945c0e3aa1d2038633e7a Branches: PHP-5.5 Link:

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Stas Malyshev
Hi! Commit:9fb5cfdeb1f13f2e3ab3751494cdd366bc78cb38 Author:Xinchen Hui larue...@php.net Fri, 14 Dec 2012 17:21:43 +0800 Parents: 359d91a80756cd9a9ce945c0e3aa1d2038633e7a Branches: PHP-5.5 Link:

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Laruence
Zend/zend_generators.c:734: warning: control reaches end of non-void function yes it's nothing difference , just make the compiler happy thanks On Fri, Dec 14, 2012 at 5:35 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Commit:9fb5cfdeb1f13f2e3ab3751494cdd366bc78cb38 Author:

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Stas Malyshev
Hi! Zend/zend_generators.c:734: warning: control reaches end of non-void function yes it's nothing difference , just make the compiler happy zend_error_noreturn already supposed to do that. Why it does not do it in your case? Which compiler do you use? -- Stanislav Malyshev, Software

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Pierre Joye
On Fri, Dec 14, 2012 at 10:40 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Zend/zend_generators.c:734: warning: control reaches end of non-void function yes it's nothing difference , just make the compiler happy zend_error_noreturn already supposed to do that. Why it does not do it

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Stas Malyshev
Hi! a couple of compilers or analyzers are confused by this macro, not sure why, but reducing the noises at no cost help to get a better view in future checks. There is a cost - now we have both zend_error_noreturn and return statements, which is unneeded. If we say zend_error_noreturn does

Re: [PHP-CVS] com php-src: Fixed warning of no return in non-void funciton: Zend/zend_vm_def.h Zend/zend_vm_execute.h Zend/zend_vm_gen.php

2012-12-14 Thread Laruence
On Fri, Dec 14, 2012 at 5:40 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Zend/zend_generators.c:734: warning: control reaches end of non-void function yes it's nothing difference , just make the compiler happy zend_error_noreturn already supposed to do that. Why it does not do it