But - since when is hash not optional?
It still is optional :-)
Only if it is shared we cannot rely on it for higher SHA.
Grr no exports. OK, gotcha now, sorry for the noise.
- Steph
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Hello Steph,
Tuesday, November 4, 2008, 2:52:48 PM, you wrote:
>>> Nope. The *original* logic said 'is it there?' Greg changed that to 'is
>>> it
>>> !shared?' You changed it back to 'is it there?' It needs to be 'is it
>>> there
>>> && !shared?'
>>
>> read again. It says if it is shared then i
Nope. The *original* logic said 'is it there?' Greg changed that to 'is
it
!shared?' You changed it back to 'is it there?' It needs to be 'is it
there
&& !shared?'
read again. It says if it is shared then issue an error. If it is present
then use it.
Args, sorry. I misread the commit and tho
Hello Steph,
Tuesday, November 4, 2008, 2:42:05 PM, you wrote:
> Hi Marcus,
>>> I'm pretty sure this is a wrong fix - the check for "not shared" replaces
>>> the original check for HAVE_HASH_EXT, which is effectively a global
>>> equivalent to $PHP_HASH. So it should be something like:
>>
>>> i
Hi Marcus,
I'm pretty sure this is a wrong fix - the check for "not shared" replaces
the original check for HAVE_HASH_EXT, which is effectively a global
equivalent to $PHP_HASH. So it should be something like:
if test "$PHP_HASH" != "no"; then
if test "$PHP_HASH_SHARED" != "yes"; then
Hello Steph,
Tuesday, November 4, 2008, 1:12:32 PM, you wrote:
> Hi Marcus,
> I'm pretty sure this is a wrong fix - the check for "not shared" replaces
> the original check for HAVE_HASH_EXT, which is effectively a global
> equivalent to $PHP_HASH. So it should be something like:
> if test "
Hi Marcus,
I'm pretty sure this is a wrong fix - the check for "not shared" replaces
the original check for HAVE_HASH_EXT, which is effectively a global
equivalent to $PHP_HASH. So it should be something like:
if test "$PHP_HASH" != "no"; then
if test "$PHP_HASH_SHARED" != "yes"; then
AC_
On 01.06.2008 08:21, Greg Beaver wrote:
cellog Sun Jun 1 04:21:27 2008 UTC
Added files: (Branch: PHP_5_3)
/php-src/ext/phar/tests/files openssl.phar openssl.phar.pubkey
private.pem
Modified files:
Valgrind has
