[PHP-CVS] cvs: php-src /ext/standard exec.c

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 08:28:09 2008 UTC Modified files: /php-src/ext/standard exec.c Log: fix ZTS build http://cvs.php.net/viewvc.cgi/php-src/ext/standard/exec.c?r1=1.129&r2=1.130&diff_format=u Index: php-src/ext/standard/exec.c diff -u php-src/ext

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard exec.c

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 08:28:24 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard exec.c Log: fix ZTS build http://cvs.php.net/viewvc.cgi/php-src/ext/standard/exec.c?r1=1.113.2.3.2.1.2.6&r2=1.113.2.3.2.1.2.7&diff_format=u Index: php-sr

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard exec.c

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 08:28:36 2008 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard exec.c Log: fix ZTS build http://cvs.php.net/viewvc.cgi/php-src/ext/standard/exec.c?r1=1.113.2.3.2.7&r2=1.113.2.3.2.8&diff_format=u Index: php-src/ext/st

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard/tests/streams .cvsignore

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 08:30:02 2008 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/streams .cvsignore Log: add missing .cvsignore http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/streams/.cvsignore?view=markup&rev=1.1 Index: ph

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Antony Dovgal
On 03/20/2008 09:12 PM, Stanislav Malyshev wrote: > +- Allowed user-level access for short_open_tag. (Stas) -1 > Now you force people to put something like "ini_set('short_open_tag', 0);" in > each script to be sure it's not being enabled. +1 Please revert. -- Wbr, Antony Dovgal -- PHP CV

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Derick Rethans
On Fri, 21 Mar 2008, Antony Dovgal wrote: > On 03/20/2008 09:12 PM, Stanislav Malyshev wrote: > > +- Allowed user-level access for short_open_tag. (Stas) > > -1 > > > Now you force people to put something like "ini_set('short_open_tag', 0);" > > in > > each script to be sure it's not being ena

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Pierre Joye
Hi Stas, On Fri, Mar 21, 2008 at 1:28 AM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > I am open to discussion, but this is not a discussion - this is plain > refusal to listen. And it's pretty irritating, especially when done > after 2 weeks of silence in answer to the original invitation

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Marcus Boerger
Hello Lars, Friday, March 21, 2008, 12:10:30 AM, you wrote: > Hi Marcus, > Am Donnerstag, den 20.03.2008, 21:59 +0100 schrieb Marcus Boerger: > [...] >> so instead promoting code fixes we are promoting bad style, is that what >> you want? I am strongly against this! Please revert and ask for

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Marcus Boerger
Hello Stanislav, Friday, March 21, 2008, 12:56:57 AM, you wrote: > Hi! >> yadda, yadda.. it's another case for potential bogus bug reports arising >> from the misuse of it. And you're not always in control what is used and >> where. > Bogus bug reports existed and will exist forever. This is

[PHP-CVS] cvs: php-src /ext/standard/tests/general_functions bug44461.phpt

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 15:18:18 2008 UTC Added files: /php-src/ext/standard/tests/general_functions bug44461.phpt Log: - Add new test http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/general_functions/bug44461.phpt?view=markup&rev=1.1 Index: php-sr

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/general_functions bug44461.phpt

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 15:21:39 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/general_functions bug44461.phpt Log: - MFH Add new test http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/general_functions/bug44461.phpt?view=markup&

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Stanislav Malyshev
100% agreed. Please revert, this commit has nothing but the potential for confusion and bugs. short_open_tag is thankfully deprecated and No, it has something but. Please read the list. And I don't see why to deprecate short_open_tag anyway, and it is not listed anywhere as deprecated, and is

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Stanislav Malyshev
Yeah, I also think this is a bad idea. For example when an application turns short tags on, while a library that it uses relies on it being of How it's different from having it on in php.ini? -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Stanislav Malyshev
Where did you post it? I can't remember a proposal and and can't find it either in the internals archive. Fix your search. I posted it on the internals list. Hint: there's a certain company providing a free service for internet users, allowing you to give it a keyword (e.g. "short_open_tag") a

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Marcus Boerger
Hello Stanislav, well you require each and everyone of us working on PHP to wait for you guys to approve. So it would only be fair if you guys would wait for us, too. We often had this before. A non answer does not necessary mean we are in favor of something. And you guys always ask us to repeat

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Marcus Boerger
Hello Stanislav, the difference is that it can get enabled uncontrollable in cases wher you do not want it to be enabled. Uncontrollable as you add a library and suddenly it's active even though you don't like it. Just becasue that library code forgot to disable it. marcus Friday, March 21, 20

[PHP-CVS] cvs: php-src /main main.c

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 16:38:50 2008 UTC Modified files: /php-src/main main.c Log: [DOC] revert short tags to their previous state http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.767&r2=1.768&diff_format=u Index: php-src/main/main.c diff -u p

[PHP-CVS] cvs: php-src(PHP_5_3) /main main.c

2008-03-21 Thread Antony Dovgal
tony2001Fri Mar 21 16:39:11 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main main.c Log: MFH: revert http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.19&r2=1.640.2.23.2.57.2.20&diff_format=u Index: php-src/main/main.

[PHP-CVS] cvs: php-src /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 17:12:38 2008 UTC Modified files: /php-src/main/streams mmap.c Log: - Increase max mmap size to 8 MB http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.11&r2=1.12&diff_format=u Index: php-src/main/streams/mmap.c diff -u php-s

[PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 17:13:08 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main/streams mmap.c Log: - MFH Increase max mmap size to 8 MB http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.8.2.1.2.1.2.1&r2=1.8.2.1.2.1.2.2&diff_format=u Index

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Stanislav Malyshev
guys to approve. So it would only be fair if you guys would wait for us, too. We often had this before. A non answer does not necessary mean we are I completely agree and in fact there's no change that I have done in a that I first didn't write on the list about and waited for the feedback. An

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Derick Rethans
On Fri, 21 Mar 2008, Marcus Boerger wrote: > /* For now, we impose an arbitrary 2MB limit to avoid >* runaway swapping when large files are passed thru. */ > - if (length > 2 * 1024 * 1024) { > + if (length > 8 * 1024 * 1024) { Fix the comment too please? :) Derick -- Der

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
Why the increase? On 21-Mar-08, at 1:13 PM, Marcus Boerger wrote: helly Fri Mar 21 17:13:08 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main/streamsmmap.c Log: - MFH Increase max mmap size to 8 MB Ilia Alshanetsky -- PHP CVS Mailing List (htt

[PHP-CVS] cvs: php-src /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 18:20:52 2008 UTC Modified files: /php-src/main/streams mmap.c Log: - Fix comment http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.12&r2=1.13&diff_format=u Index: php-src/main/streams/mmap.c diff -u php-src/main/streams/mma

[PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 18:21:09 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main/streams mmap.c Log: - MFH Fix comment http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.8.2.1.2.1.2.2&r2=1.8.2.1.2.1.2.3&diff_format=u Index: php-src/main/stre

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Derick, good point, I Dropped the number in gthe comment marcus Friday, March 21, 2008, 6:16:29 PM, you wrote: > On Fri, 21 Mar 2008, Marcus Boerger wrote: >> /* For now, we impose an arbitrary 2MB limit to avoid >>* runaway swapping when large files are passed thru. */ >

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Ilia, mmapping of larger phars, like the pear installer :-) marcus Friday, March 21, 2008, 6:39:10 PM, you wrote: > Why the increase? > On 21-Mar-08, at 1:13 PM, Marcus Boerger wrote: >> helly Fri Mar 21 17:13:08 2008 UTC >> >> Modified files: (Branch: PHP_5_3) >

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
The reason a 2 meg limit was imposed originally was partially due to memory_limit value set in PHP, which at the time was 8 megs. By bumping it to a much higher value, you are quite easily exceeding the memory limit. I am not opposed to increasing the value, but 8megs seems a bit high...

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Ilia, Friday, March 21, 2008, 7:28:36 PM, you wrote: > The reason a 2 meg limit was imposed originally was partially due to > memory_limit value set in PHP, which at the time was 8 megs. By > bumping it to a much higher value, you are quite easily exceeding the > memory limit. I am no

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
I think 4mb would be a better value. On 21-Mar-08, at 2:44 PM, Marcus Boerger wrote: Hello Ilia, Friday, March 21, 2008, 7:28:36 PM, you wrote: The reason a 2 meg limit was imposed originally was partially due to memory_limit value set in PHP, which at the time was 8 megs. By bumping it to a

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Pierre Joye
On Fri, Mar 21, 2008 at 6:13 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > > guys to approve. So it would only be fair if you guys would wait for us, > > too. We often had this before. A non answer does not necessary mean we are > > I completely agree and in fact there's no change that I ha

[PHP-CVS] cvs: php-src /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 19:37:32 2008 UTC Modified files: /php-src/main/streams mmap.c Log: - Settle to 4 MB, see internals@ archives http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.13&r2=1.14&diff_format=u Index: php-src/main/streams/mmap.c diff

[PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
helly Fri Mar 21 19:37:43 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main/streams mmap.c Log: - MFH Settle to 4 MB, see internals@ archives http://cvs.php.net/viewvc.cgi/php-src/main/streams/mmap.c?r1=1.8.2.1.2.1.2.3&r2=1.8.2.1.2.1.2.4&diff_forma

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/oci8 oci8.c oci8_collection.c oci8_lob.c oci8_statement.c php_oci8_int.h /ext/oci8/tests drcp_cclass1.phpt drcp_connect1.phpt

2008-03-21 Thread Christopher Jones
sixdSat Mar 22 01:27:50 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/oci8 oci8.c oci8_collection.c oci8_lob.c oci8_statement.c php_oci8_int.h /php-src/ext/oci8/tests drcp_cclass1.phpt drcp_connect1.phpt Log: Further