[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqlnd/mysqlnd_net.c branches/PHP_5_4/ext/mysqlnd/mysqlnd_net.c trunk/ext/mysqlnd/mysqlnd_net.c

2011-05-16 Thread Johannes Schlüter
johannes Mon, 16 May 2011 10:15:28 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311072 Log: - Move the access behind the check. # I can't find an unsafe call, but let's play safe Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo_mysql/mysql_statement.c branches/PHP_5_3/ext/pdo_mysql/tests/bug53782.phpt branches/PHP_5_4/ext/pdo_mysql/mysql_statement.c

2011-05-16 Thread Johannes Schlüter
johannes Mon, 16 May 2011 15:37:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311088 Log: - Fix Bug #53782 (foreach throws irrelevant exception) Bug: http://bugs.php.net/53782 (Re-Opened) foreach throws irrelevant exception Changed

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/main/SAPI.h branches/PHP_5_4/sapi/apache2handler/sapi_apache2.c trunk/main/SAPI.h trunk/sapi/apache2handler/sapi_apache2.c

2011-05-16 Thread Rasmus Lerdorf
rasmus Mon, 16 May 2011 15:52:31 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311096 Log: Fix a couple of warnings. Use %zu to printf a time_t and get_request_time actually returns a double, not a time_t. Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/mod_files.c branches/PHP_5_4/ext/soap/php_sdl.c branches/PHP_5_4/main/main.c branches/PHP_5_4/main/php.h trunk/ext/session/mod_files.c trunk/e

2011-05-16 Thread Rasmus Lerdorf
rasmus Mon, 16 May 2011 16:58:02 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311099 Log: Add php_ignore_value() macro to suppress unused return value warnings from gcc. There are times when we really don't care about the return value and this

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/Zend/zend_language_scanner.c branches/PHP_5_4/Zend/zend_language_scanner.l branches/PHP_5_4/Zend/zend_language_scanner_defs.h branches/PHP_5_4/ext/standar

2011-05-16 Thread Rasmus Lerdorf
rasmus Mon, 16 May 2011 17:22:41 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311100 Log: Suppress a dozen unused return value warnings in places where the return value is really not useful to us. Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/Zend/zend_language_scanner.c branches/PHP_5_4/Zend/zend_language_scanner.l branches/PHP_5_4/Zend/zend_language_scanner_defs.h trunk/Zend/zend_language_sca

2011-05-16 Thread Rasmus Lerdorf
rasmus Mon, 16 May 2011 17:26:10 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311101 Log: oops, can't use that macro here Changed paths: U php/php-src/branches/PHP_5_4/Zend/zend_language_scanner.c U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/file/ bug39863.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 19:40:12 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311103 Log: removing XFAIL as #39863 has already been fixed Bug: http://bugs.php.net/39863 (Assigned) file_exists() silently truncates after a null byte

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/TSRM/tsrm_virtual_cwd.c branches/PHP_5_4/TSRM/tsrm_virtual_cwd.c trunk/TSRM/tsrm_virtual_cwd.c

2011-05-16 Thread Johannes Schlüter
johannes Mon, 16 May 2011 19:46:32 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311104 Log: - Fix possible memory leak # Found by parfait - http://labs.oracle.com/projects/parfait/ Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/serialize/ 001.phpt serialization_arrays_001.phpt serialization_objects_001.phpt serialization_objects_002.phpt serialization_objects_00

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 19:49:59 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311105 Log: adding the serialize_precision=100 for the tests, credits to Mats Lindh for reporting it Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 19:51:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311106 Log: fix the test with the removal of the unnecessary newline Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/date/tests/ DateInterval_format_a.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 20:07:55 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311107 Log: fix the test via setting the timezone to UTC as suggested by Alexey Shein, and adding an SKIPIF as this test was originaly intended for windows only,

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/date/tests/ bug51994.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 20:10:04 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311108 Log: adding an XFAIL, as we have an open bug for this test Changed paths: U php/php-src/branches/PHP_5_3/ext/date/tests/bug51994.phpt Modified:

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/date/tests/ bug51819.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 20:11:00 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311109 Log: adding an XFAIL, as we have an open bug for this test Changed paths: U php/php-src/branches/PHP_5_3/ext/date/tests/bug51819.phpt Modified:

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Kalle Sommer Nielsen
Hi 2011/5/16 Ferenc Kovacs tyr...@php.net: tyrael                                   Mon, 16 May 2011 19:51:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311106 Log: fix the test with the removal of the unnecessary newline Changed paths:    U  

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Ferenc Kovacs
On Mon, May 16, 2011 at 11:17 PM, Kalle Sommer Nielsen ka...@php.netwrote: Hi 2011/5/16 Ferenc Kovacs tyr...@php.net: tyrael Mon, 16 May 2011 19:51:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311106 Log: fix the test with the

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Kalle Sommer Nielsen
Hi 2011/5/16 Ferenc Kovacs i...@tyrael.hu: oh, so you favor that over merging between the branches? Tyrael Yeah, less spam on php.cvs :) -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/lib/parse_tz.c branches/PHP_5_4/ext/date/lib/parse_tz.c trunk/ext/date/lib/parse_tz.c

2011-05-16 Thread Johannes Schlüter
johannes Mon, 16 May 2011 21:29:45 + Revision: http://svn.php.net/viewvc?view=revisionrevision=30 Log: - Fix a few more memleaks found by parfait Changed paths: U php/php-src/branches/PHP_5_3/ext/date/lib/parse_tz.c U

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Pierrick Charron
And also easier to revert since there is just one commit for all branches. On 16 May 2011 17:28, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2011/5/16 Ferenc Kovacs i...@tyrael.hu: oh, so you favor that over merging between the branches? Tyrael Yeah, less spam on php.cvs :) --

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Ferenc Kovacs
ok, thanks for the heads up. should I revert and commit them again for all three branch, or merge them for the other two? (5.4, trunk) Tyrael On Mon, May 16, 2011 at 11:30 PM, Pierrick Charron pierr...@webstart.frwrote: And also easier to revert since there is just one commit for all branches.

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/phar/zip.c branches/PHP_5_4/ext/phar/zip.c trunk/ext/phar/zip.c

2011-05-16 Thread Johannes Schlüter
johannes Mon, 16 May 2011 22:24:41 + Revision: http://svn.php.net/viewvc?view=revisionrevision=32 Log: - Handle error if tempfile can't be opened, found by parfait Changed paths: U php/php-src/branches/PHP_5_3/ext/phar/zip.c U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/ date/tests/DateInterval_format_a.phpt date/tests/bug51819.phpt date/tests/bug51994.phpt standard/tests/file/bug39863.phpt standard/tests/network/getho

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:22:17 + Revision: http://svn.php.net/viewvc?view=revisionrevision=33 Log: reverting 311103,311105-311109, will commit them to all three branches Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/file/bug39863.phpt branches/PHP_5_4/ext/standard/tests/file/bug39863.phpt trunk/ext/standard/tests/file/bug39863.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:28:46 + Revision: http://svn.php.net/viewvc?view=revisionrevision=34 Log: removing XFAIL as #39863 has already been fixed Bug: http://bugs.php.net/39863 (Assigned) file_exists() silently truncates after a null byte

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Kalle Sommer Nielsen
2011/5/16 Ferenc Kovacs i...@tyrael.hu: ok, thanks for the heads up. should I revert and commit them again for all three branch, or merge them for the other two? (5.4, trunk) Merging is way easier, as you already committed theres no point in reverting just to re-add it, more of a good practice

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/serialize/001.phpt branches/PHP_5_3/ext/standard/tests/serialize/serialization_arrays_001.phpt branches/PHP_5_3/ext/standard/tests/seri

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:31:14 + Revision: http://svn.php.net/viewvc?view=revisionrevision=35 Log: adding the serialize_precision=100 for the tests, credits to Mats Lindh for reporting it Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/network/gethostbynamel_error.phpt branches/PHP_5_4/ext/standard/tests/network/gethostbynamel_error.phpt trunk/ext/standard/tests/networ

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:33:05 + Revision: http://svn.php.net/viewvc?view=revisionrevision=36 Log: fix the test with the removal of the unnecessary newline Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/tests/DateInterval_format_a.phpt branches/PHP_5_4/ext/date/tests/DateInterval_format_a.phpt trunk/ext/date/tests/DateInterval_format_a.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:35:23 + Revision: http://svn.php.net/viewvc?view=revisionrevision=37 Log: set the timezone to UTC as suggested by Alexey Shein, and adding an SKIPIF as this test was originaly intended to be windows only Changed paths: U

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/tests/network/ gethostbynamel_error.phpt

2011-05-16 Thread Ferenc Kovacs
On Tue, May 17, 2011 at 1:30 AM, Kalle Sommer Nielsen ka...@php.net wrote: 2011/5/16 Ferenc Kovacs i...@tyrael.hu: ok, thanks for the heads up. should I revert and commit them again for all three branch, or merge them for the other two? (5.4, trunk) Merging is way easier, as you already

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/tests/bug51994.phpt branches/PHP_5_4/ext/date/tests/bug51994.phpt trunk/ext/date/tests/bug51994.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:39:16 + Revision: http://svn.php.net/viewvc?view=revisionrevision=38 Log: adding an XFAIL, as we have an open bug for this test Changed paths: U php/php-src/branches/PHP_5_3/ext/date/tests/bug51994.phpt U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/tests/bug51819.phpt branches/PHP_5_4/ext/date/tests/bug51819.phpt trunk/ext/date/tests/bug51819.phpt

2011-05-16 Thread Ferenc Kovacs
tyrael Mon, 16 May 2011 23:43:12 + Revision: http://svn.php.net/viewvc?view=revisionrevision=39 Log: adding an XFAIL, as we have an open bug for this test Changed paths: U php/php-src/branches/PHP_5_3/ext/date/tests/bug51819.phpt U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqlnd/mysqlnd_wireprotocol.c branches/PHP_5_4/ext/mysqlnd/mysqlnd_wireprotocol.c trunk/ext/mysqlnd/mysqlnd_wireprotocol.c

2011-05-16 Thread Johannes Schlüter
johannes Tue, 17 May 2011 00:16:57 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311120 Log: - Move the field access behind the check # Only called from one place where the connection is checked, but # playing safe, again (parfait) Changed