Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Pierre Joye
hi, This is a new feature, what does it do in 5.4? Also it was clearly not tested (did not build with < 1.0.0 f.e.). I am totally not in favour of having that in 5.4 yet, even if it looks non intrusive. The overall stability and reliability is a key, not only specific functions. Cheers, On Tue,

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stas did you ACK that change? It seems rather intrusive and I am not sure if we want that in a minor version just 24 h before releasing. can we solve that before tagging 5.4.4? thx > On Tue, Jun 12, 2012 at 1:04 AM, Scott MacVicar > wrote: >> Commit

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Scott MacVicar
I checked with Stas and he said ok for 5.4. On 12 Jun 2012, at 06:08, David Soria Parra wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Stas did you ACK that change? It seems rather intrusive and I am not > sure if we want that in a minor version just 24 h before releasing. > can w

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Pierre Joye
On Tue, Jun 12, 2012 at 4:50 PM, Scott MacVicar wrote: > I checked with Stas and he said ok for 5.4. Make it public next time. RFC says no new feature but very very small ones. RMs apply this rule. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List

[PHP-CVS] com php-src: add CVE: NEWS

2012-06-12 Thread Stanislav Malyshev
Commit:f8cc363841ecd126c0c43f2773e4d85a54b8484c Author:Stanislav Malyshev Tue, 12 Jun 2012 11:18:43 -0700 Parents: bccd1e672fabc3c788e93075221d47d9f077b167 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f8cc363841ecd126c0c43f2773e4d85a54b8484c

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Stas Malyshev
Hi! > I checked with Stas and he said ok for 5.4. Looks like there's a disagreement about this one and whether it should be in hash or openssl, so I'll revert this for now from 5.4 and after we discuss it on internals and decide where we want it, we'll decide where it goes. Sorry for misunderstan

[PHP-CVS] com php-src: Revert "Add PBKDF2 support via openssl()": ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_pkcs5_pbkdf2_hmac.phpt

2012-06-12 Thread Stanislav Malyshev
Commit:c7be96b08fb457f8a2b4e2a64f59437b230886c1 Author:Stanislav Malyshev Tue, 12 Jun 2012 11:22:49 -0700 Parents: a2bfad051df022058f19afc5f09fd835cbbcf145 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c7be96b08fb457f8a2b4e2a64f59437b230886c1

[PHP-CVS] com php-src: Revert "Rename openssl_pkcs5_pbkdf2_hmac() to something that doesn't sound like a spell.": ext/openssl/CREDITS ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/

2012-06-12 Thread Stanislav Malyshev
Commit:a2bfad051df022058f19afc5f09fd835cbbcf145 Author:Stanislav Malyshev Tue, 12 Jun 2012 11:21:54 -0700 Parents: f8cc363841ecd126c0c43f2773e4d85a54b8484c Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=a2bfad051df022058f19afc5f09fd835cbbcf145

[PHP-CVS] com php-src: re-add 61755 to NEWS: NEWS

2012-06-12 Thread Stanislav Malyshev
Commit:79e44c394fe34c4c902b8a25ffac27a178ab5211 Author:Stanislav Malyshev Tue, 12 Jun 2012 11:53:24 -0700 Parents: c7be96b08fb457f8a2b4e2a64f59437b230886c1 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=79e44c394fe34c4c902b8a25ffac27a178ab5211

[PHP-CVS] com php-src: re-add 61755 to NEWS: NEWS

2012-06-12 Thread Stanislav Malyshev
Commit:f0d6059389c0d00e6fa4a890b69d422aab8c3b0d Author:Stanislav Malyshev Tue, 12 Jun 2012 11:49:35 -0700 Parents: f464ffd78046d31eb4bbd6d44dced3cd39d12c69 Branches: PHP-5.3 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f0d6059389c0d00e6fa4a890b69d422aab8c3b0d

[PHP-CVS] com php-src: merge NEWS, add #61755: NEWS

2012-06-12 Thread Stanislav Malyshev
Commit:d939ce5d1bcd6cc9dd4454642f76efc744ae9fa0 Author:Stanislav Malyshev Tue, 12 Jun 2012 11:59:02 -0700 Parents: 4c3575fa02da6ad8bd69fb59b57b0755363e8039 Branches: PHP-5.4.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d939ce5d1bcd6cc9dd4454642f76efc744ae9fa

[PHP-CVS] com php-src: 5.4.4: configure.in main/php_version.h

2012-06-12 Thread Stanislav Malyshev
Commit:e961c76a0bf81dbf7322fbd87fafc0642b6bef62 Author:Stanislav Malyshev Tue, 12 Jun 2012 21:54:23 -0700 Parents: d939ce5d1bcd6cc9dd4454642f76efc744ae9fa0 Branches: PHP-5.4.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e961c76a0bf81dbf7322fbd87fafc0642b6bef6

[PHP-CVS] tag php-src: create tag php-5.4.4

2012-06-12 Thread Stanislav Malyshev
Tag php-5.4.4 in php-src.git was created Tag: 0b90e0277aa760ccfdd9537eb09c8cc143afe1c5 Tagger: Stanislav Malyshev Tue Jun 12 22:18:26 2012 -0700 Log: 5.4.4 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (Darwin) iF4EABEIAAYFAk/YIqUACgkQL3lWvF2gS12JQQD/XVZ+M1ti/wtnEmqaUw