georg Thu Apr 3 03:03:12 2003 EDT
Modified files:
/php4/ext/mysqli/tests 047.phpt
Log:
fixed output
Index: php4/ext/mysqli/tests/047.phpt
diff -u php4/ext/mysqli/tests/047.phpt:1.2 php4/ext/mysqli/tests/047.phpt:1.3
---
georg Thu Apr 3 03:03:59 2003 EDT
Modified files:
/php4/ext/mysqlimysqli_api.c
Log:
fixed mysqli_prepare_result
Index: php4/ext/mysqli/mysqli_api.c
diff -u php4/ext/mysqli/mysqli_api.c:1.21 php4/ext/mysqli/mysqli_api.c:1.22
---
Regardless, I think the ideal answer is for everyone to just follow
the same standard from the beginning. If we all did that, there would
be no reason for style- or whitespace-related commits.
Yes, but that is simply never going to happen as even a brief look at the
current code will attest
chregu Thu Apr 3 05:21:19 2003 EDT
Modified files:
/php4/ext/domxmlphp_domxml.c php_domxml.h
Log:
- Added domxml_elem_set_attribute_node() method. (Rob Richards)
Index: php4/ext/domxml/php_domxml.c
diff -u php4/ext/domxml/php_domxml.c:1.242
chregu Thu Apr 3 05:24:53 2003 EDT
Modified files:
/php4 NEWS
Log:
new domxml_elem_set_attribute_node() should have gone into NEWS, but I forgot..
Index: php4/NEWS
diff -u php4/NEWS:1.1388 php4/NEWS:1.1389
--- php4/NEWS:1.1388Wed Apr 2 20:30:52
On Wed, 2 Apr 2003, Rasmus Lerdorf wrote:
Oh, give me a break Jani. A space here or there makes absolutely no
difference to the readability of the code, but all these whitespace
commits get in the way of any real work when trying to track down problems
via cvs diffs.
If you had committed
sniper Thu Apr 3 06:04:16 2003 EDT
Modified files:
/php4 NEWS
Log:
reorder
Index: php4/NEWS
diff -u php4/NEWS:1.1389 php4/NEWS:1.1390
--- php4/NEWS:1.1389Thu Apr 3 05:24:53 2003
+++ php4/NEWS Thu Apr 3 06:04:16 2003
@@ -1,7 +1,6 @@
PHP
Please take a few minutes and read all the entries in this file.
(the ones for PHP 5)
I've been trying to keep the different 'types' of entries grouped
so please, try putting your entries in correct places.
--Jani
On Thu, 3 Apr 2003, Christian
rasmus Thu Apr 3 10:57:31 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/exif exif.c
Log:
Clean up the parameter handling here
Index: php4/ext/exif/exif.c
diff -u php4/ext/exif/exif.c:1.118.2.15 php4/ext/exif/exif.c:1.118.2.16
---
sas Thu Apr 3 13:11:04 2003 EDT
Modified files: (Branch: PHP_4)
/php4/ext/standard basic_functions.c
Log:
MFH
Index: php4/ext/standard/basic_functions.c
diff -u php4/ext/standard/basic_functions.c:1.543.2.5.2.1
sas Thu Apr 3 13:19:15 2003 EDT
Modified files:
/php4/main output.c
Log:
Add some checks and avoid passing invalid data to call_user_function_ex.
Fixes some heap corruption and allocation of negative amounts of memory.
Index: php4/main/output.c
sas Thu Apr 3 13:19:52 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4/main output.c
Log:
MFH
Index: php4/main/output.c
diff -u php4/main/output.c:1.142.2.8 php4/main/output.c:1.142.2.9
--- php4/main/output.c:1.142.2.8Wed Apr 2 19:51:14 2003
+++
sas Thu Apr 3 13:20:40 2003 EDT
Modified files: (Branch: PHP_4)
/php4/main output.c
Log:
MFH
Index: php4/main/output.c
diff -u php4/main/output.c:1.142.2.3.2.1 php4/main/output.c:1.142.2.3.2.2
--- php4/main/output.c:1.142.2.3.2.1Tue Apr 1 14:15:15
sas Thu Apr 3 13:22:14 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
Update - we purged the full list\!
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.15 php4/TODO_SEGFAULTS:1.1.2.16
---
Waiting to see if anybody was going to comment on it or make silly
whitespace changes first.
On Thu, 3 Apr 2003, Jani Taskinen wrote:
Shouldn't you MFB this?
--Jani
On Thu, 3 Apr 2003, Rasmus Lerdorf wrote:
rasmus Thu Apr 3 10:57:31 2003 EDT
pollita Thu Apr 3 13:33:05 2003 EDT
Modified files:
/php4/ext/standard array.c
Log:
Kludgy fix for floating point drift causing problems like range(1.0,1.5,0.1) ==
array(1.0,1.1,1.2,1.3,1.4);
Index: php4/ext/standard/array.c
diff -u
sniper Thu Apr 3 13:44:00 2003 EDT
Modified files:
/php4/main output.c
Log:
WS CS fix
Index: php4/main/output.c
diff -u php4/main/output.c:1.153 php4/main/output.c:1.154
--- php4/main/output.c:1.153Thu Apr 3 13:19:15 2003
+++ php4/main/output.c Thu Apr
sas Thu Apr 3 13:52:35 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
update regarding dbase extension
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.16 php4/TODO_SEGFAULTS:1.1.2.17
---
sas Thu Apr 3 13:55:54 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
fix
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.17 php4/TODO_SEGFAULTS:1.1.2.18
--- php4/TODO_SEGFAULTS:1.1.2.17Thu Apr 3 13:52:35
That dbase extension is a trainwreck. Did you see the code I fixed
yesterday? It had:
cp = (char *)malloc(256);
strcpy(cp, dp); strcat(cp, .dbf);
;(
-Rasmus
On Thu, 3 Apr 2003, Sascha Schumann wrote:
sas Thu Apr 3 13:52:35 2003 EDT
Modified files: (Branch:
sas Thu Apr 3 14:18:58 2003 EDT
Modified files:
/php4/ext/gdgd.c
Log:
Fix segfaults in imagecreate/imagecreatetruecolor
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.261 php4/ext/gd/gd.c:1.262
--- php4/ext/gd/gd.c:1.261 Mon Mar 31
On Thu, 3 Apr 2003, Sascha Schumann wrote:
sas Thu Apr 3 14:18:58 2003 EDT
Modified files:
/php4/ext/gd gd.c
Log:
Fix segfaults in imagecreate/imagecreatetruecolor
Can we please stick to using php_error_docref and try to keep the
descriptions in
Can we please stick to using php_error_docref and try to keep the
descriptions in the same format (ie. with a capital and a point)?
I don't think php_error_docref adds value to PHP.
- Sascha
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
sas Thu Apr 3 14:46:26 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
augment summary with fixes which predate the list
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.20 php4/TODO_SEGFAULTS:1.1.2.21
---
On Thu, 3 Apr 2003, Jani Taskinen wrote:
sniperThu Apr 3 13:44:00 2003 EDT
Modified files:
/php4/mainoutput.c
Log:
WS CS fix
Jani, in addition to regularly polluting the CVS history, you
are also desyncing the various branches. This does not
sas Thu Apr 3 15:07:40 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
one in socket_select
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.21 php4/TODO_SEGFAULTS:1.1.2.22
--- php4/TODO_SEGFAULTS:1.1.2.21Thu
On Thu, 3 Apr 2003, Sascha Schumann wrote:
Can we please stick to using php_error_docref and try to keep the
descriptions in the same format (ie. with a capital and a point)?
I don't think php_error_docref adds value to PHP.
So because *you* dont think so we should do it all
helly Thu Apr 3 15:59:43 2003 EDT
Modified files:
/php4 configure.in
Log:
Check for flex version 2.5.4
Index: php4/configure.in
diff -u php4/configure.in:1.438 php4/configure.in:1.439
--- php4/configure.in:1.438 Wed Apr 2 16:17:16 2003
+++
rasmus Thu Apr 3 17:45:26 2003 EDT
Modified files:
/php4/ext/exif exif.c
Log:
MFB
Index: php4/ext/exif/exif.c
diff -u php4/ext/exif/exif.c:1.142 php4/ext/exif/exif.c:1.143
--- php4/ext/exif/exif.c:1.142 Wed Apr 2 17:07:22 2003
+++
sniper Thu Apr 3 18:10:17 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/gdgd.c
Log:
MFH
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.221.2.20 php4/ext/gd/gd.c:1.221.2.21
--- php4/ext/gd/gd.c:1.221.2.20 Thu Apr 3 14:19:25 2003
+++
iliaa Thu Apr 3 19:16:48 2003 EDT
Modified files:
/php4/ext/gdgd.c
Log:
Fix segfault in imagecopyresized().
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.264 php4/ext/gd/gd.c:1.265
--- php4/ext/gd/gd.c:1.264 Thu Apr 3 19:09:23 2003
+++
iliaa Thu Apr 3 19:16:55 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/gdgd.c
Log:
MFH
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.221.2.21 php4/ext/gd/gd.c:1.221.2.22
--- php4/ext/gd/gd.c:1.221.2.21 Thu Apr 3 18:10:17 2003
+++
iliaa Thu Apr 3 19:29:37 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
Fixed segv as well as info about new segvs in gd.
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.22 php4/TODO_SEGFAULTS:1.1.2.23
---
iliaa Thu Apr 3 19:44:35 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
More gd stuff.
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.23 php4/TODO_SEGFAULTS:1.1.2.24
--- php4/TODO_SEGFAULTS:1.1.2.23Thu Apr
+ if (dstW 0 || dstH 0 || srcW 0 || srcH 0) {
Why is that not =
marcus
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
On April 3, 2003 07:35 pm, Marcus Börger wrote:
+ if (dstW 0 || dstH 0 || srcW 0 || srcH 0) {
Why is that not =
Why not indeed...
I'll make the change.
Ilia
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
iliaa Thu Apr 3 20:17:35 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4 TODO_SEGFAULTS
Log:
Notes about various possible integer overflows in bundled gd library.
Index: php4/TODO_SEGFAULTS
diff -u php4/TODO_SEGFAULTS:1.1.2.24
iliaa Thu Apr 3 20:33:58 2003 EDT
Modified files:
/php4/ext/gdgd.c
Log:
Might as well disallow 0x0 images.
Thanks Marcus.
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.265 php4/ext/gd/gd.c:1.266
--- php4/ext/gd/gd.c:1.265 Thu Apr 3
pollita Thu Apr 3 20:33:58 2003 EDT
Modified files:
/php4/main/streams streams.c
Log:
Prevent php_stream_get_record from grabbing more than maxlen characters
Index: php4/main/streams/streams.c
diff -u php4/main/streams/streams.c:1.16
iliaa Thu Apr 3 20:34:08 2003 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/gdgd.c
Log:
MFH
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.221.2.22 php4/ext/gd/gd.c:1.221.2.23
--- php4/ext/gd/gd.c:1.221.2.22 Thu Apr 3 19:16:54 2003
+++
On Thu, 3 Apr 2003, Derick Rethans wrote:
On Thu, 3 Apr 2003, Sascha Schumann wrote:
Can we please stick to using php_error_docref and try to keep the
descriptions in the same format (ie. with a capital and a point)?
I don't think php_error_docref adds value to PHP.
So because
41 matches
Mail list logo
