[PHP-CVS] cvs: php-src / NEWS

2003-07-21 Thread Jani Taskinen
sniper Mon Jul 21 04:20:48 2003 EDT Modified files: /php-srcNEWS Log: some style fixes Index: php-src/NEWS diff -u php-src/NEWS:1.1442 php-src/NEWS:1.1443 --- php-src/NEWS:1.1442 Sun Jul 20 18:03:28 2003 +++ php-src/NEWSMon Jul 21 04:20:48 2003 @@

[PHP-CVS] cvs: php-src /ext/fdf/tests .cvsignore

2003-07-21 Thread Jani Taskinen
sniper Mon Jul 21 04:27:23 2003 EDT Added files: /php-src/ext/fdf/tests .cvsignore Log: Missing .cvsignore Index: php-src/ext/fdf/tests/.cvsignore +++ php-src/ext/fdf/tests/.cvsignore phpt.* *.diff *.log *.exp *.out *.php -- PHP CVS Mailing List

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/fdf/tests .cvsignore

2003-07-21 Thread Jani Taskinen
sniper Mon Jul 21 04:27:47 2003 EDT Added files: (Branch: PHP_4_3) /php-src/ext/fdf/tests .cvsignore Log: MFH Index: php-src/ext/fdf/tests/.cvsignore +++ php-src/ext/fdf/tests/.cvsignore phpt.* *.diff *.log *.exp *.out *.php -- PHP CVS Mailing List

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS

2003-07-21 Thread Jani Taskinen
sniper Mon Jul 21 04:43:27 2003 EDT Modified files: (Branch: PHP_4_3) /php-srcNEWS Log: expat upgrade news Index: php-src/NEWS diff -u php-src/NEWS:1.1247.2.288 php-src/NEWS:1.1247.2.289 --- php-src/NEWS:1.1247.2.288 Sat Jul 19 11:37:08 2003 +++

[PHP-CVS] cvs: php-src /tests/lang 036.phpt 037.phpt

2003-07-21 Thread Zeev Suraski
zeevMon Jul 21 07:48:37 2003 EDT Added files: /php-src/tests/lang 036.phpt 037.phpt Log: Add a couple of tests Index: php-src/tests/lang/036.phpt +++ php-src/tests/lang/036.phpt --TEST-- Child public element should not override parent private element

[PHP-CVS] cvs: php-src /tests/lang bug24499.phpt ZendEngine2 zend_object_handlers.c

2003-07-21 Thread Zeev Suraski
zeevMon Jul 21 08:13:16 2003 EDT Added files: /php-src/tests/lang bug24499.phpt Modified files: /ZendEngine2zend_object_handlers.c Log: Fix bug #24499 Index: ZendEngine2/zend_object_handlers.c diff -u

[PHP-CVS] cvs: php-src /ext/standard url.c

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 09:36:23 2003 EDT Modified files: /php-src/ext/standard url.c Log: Fixed bug #24560 (parse_url() incorrectly handling certain file:// based schemas). Index: php-src/ext/standard/url.c diff -u php-src/ext/standard/url.c:1.66

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS /ext/standard url.c /ext/standard/tests/strings url_t.phpt

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 09:37:10 2003 EDT Modified files: (Branch: PHP_4_3) /php-srcNEWS /php-src/ext/standard url.c /php-src/ext/standard/tests/strings url_t.phpt Log: MFH: Fixed bug #24560 (parse_url() incorrectly handling certain file:// based

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS

2003-07-21 Thread Jani Taskinen
sniper Mon Jul 21 10:03:43 2003 EDT Modified files: (Branch: PHP_4_3) /php-srcNEWS Log: nitpicking right from the start.. :) Index: php-src/NEWS diff -u php-src/NEWS:1.1247.2.290 php-src/NEWS:1.1247.2.291 --- php-src/NEWS:1.1247.2.290 Mon Jul 21 09:37:09

[PHP-CVS] cvs: php-src(PHP_4_3) /sapi/nsapi nsapi.c

2003-07-21 Thread Uwe Schindler
thetaphiMon Jul 21 10:20:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/sapi/nsapi nsapi.c Log: some code cleanups Index: php-src/sapi/nsapi/nsapi.c diff -u php-src/sapi/nsapi/nsapi.c:1.28.2.17 php-src/sapi/nsapi/nsapi.c:1.28.2.18 ---

[PHP-CVS] cvs: php-src /main main.c

2003-07-21 Thread Zeev Suraski
zeevMon Jul 21 13:41:42 2003 EDT Modified files: /php-src/main main.c Log: Remove old code Index: php-src/main/main.c diff -u php-src/main/main.c:1.560 php-src/main/main.c:1.561 --- php-src/main/main.c:1.560 Tue Jun 17 13:15:02 2003 +++

[PHP-CVS] cvs: php-src /main php_variables.c

2003-07-21 Thread Zeev Suraski
zeevMon Jul 21 13:42:24 2003 EDT Modified files: /php-src/main php_variables.c Log: Fix register_globals Index: php-src/main/php_variables.c diff -u php-src/main/php_variables.c:1.64 php-src/main/php_variables.c:1.65 ---

[PHP-CVS] cvs: php-src /ext/pgsql pgsql.c

2003-07-21 Thread Marcus Boerger
helly Mon Jul 21 16:49:47 2003 EDT Modified files: /php-src/ext/pgsql pgsql.c Log: Go without #24499 hint sneaked in by accident Index: php-src/ext/pgsql/pgsql.c diff -u php-src/ext/pgsql/pgsql.c:1.279 php-src/ext/pgsql/pgsql.c:1.280 ---

[PHP-CVS] cvs: php-src /ext/pgsql pgsql.c

2003-07-21 Thread Marcus Boerger
helly Mon Jul 21 16:53:00 2003 EDT Modified files: /php-src/ext/pgsql pgsql.c Log: Reset vars when reusing a persistent connection as requested from postgres developers Index: php-src/ext/pgsql/pgsql.c diff -u php-src/ext/pgsql/pgsql.c:1.280

[PHP-CVS] cvs: php-src /ext/session session.c /ext/session/tests bug24592.phpt

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 17:47:52 2003 EDT Added files: /php-src/ext/session/tests bug24592.phpt Modified files: /php-src/ext/sessionsession.c Log: Fixed bug #24592 (Possible crash in session extnsion, with NULL values) Index:

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS /ext/session session.c /ext/session/tests bug24592.phpt

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 17:49:52 2003 EDT Added files: (Branch: PHP_4_3) /php-src/ext/session/tests bug24592.phpt Modified files: /php-src/ext/sessionsession.c /php-srcNEWS Log: MFH: Fixed bug #24592 (Possible crash in session

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/session/testsbug24592.phpt

2003-07-21 Thread Sascha Schumann
On Mon, 21 Jul 2003, Ilia Alshanetsky wrote: iliaa Mon Jul 21 17:47:52 2003 EDT Added files: /php-src/ext/session/testsbug24592.phpt Modified files: /php-src/ext/session session.c Log: Fixed bug #24592 (Possible crash in session extnsion, with NULL

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/session/tests bug24592.phpt

2003-07-21 Thread Ilia Alshanetsky
On July 21, 2003 06:30 pm, Sascha Schumann wrote: On Mon, 21 Jul 2003, Ilia Alshanetsky wrote: iliaa Mon Jul 21 17:47:52 2003 EDT Added files: /php-src/ext/session/tests bug24592.phpt Modified files: /php-src/ext/sessionsession.c Log: Fixed

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-21 Thread Sascha Schumann
sas Mon Jul 21 21:10:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Proper fix for #24592 The core issue is that undefined variables are refcounted (refcount != 0) while is_ref is still set to 0. I don't know

[PHP-CVS] cvs: php-src /ext/session session.c

2003-07-21 Thread Sascha Schumann
sas Mon Jul 21 21:11:07 2003 EDT Modified files: /php-src/ext/sessionsession.c Log: MFB proper fix for #24592 Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.367 php-src/ext/session/session.c:1.368 ---

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/session/testsbug24592.phpt

2003-07-21 Thread Sascha Schumann
Ilia, thanks for bringing up this issue, I probably would not have looked at it otherwise. In this case using ZEND_SET_SYMBOL_WITH_LENGTH is overkill. Majority of the code inside the macro is not used and the zend_hash_find() is needlesly duplicated if the macro is used. Change wise we

[PHP-CVS] cvs: php-src /main fopen_wrappers.c

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 21:32:01 2003 EDT Modified files: /php-src/main fopen_wrappers.c Log: Make php_check_safe_mode_include_dir check independent of unrelated open_basedir directive and make it properly handle undefined/empty safe_mode_include_dir

[PHP-CVS] cvs: php-src(PHP_4_3) /main fopen_wrappers.c

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 21:32:21 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/main fopen_wrappers.c Log: MFH: r1.165 safe_mode patch Index: php-src/main/fopen_wrappers.c diff -u php-src/main/fopen_wrappers.c:1.153.2.5

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS

2003-07-21 Thread Ilia Alshanetsky
iliaa Mon Jul 21 21:35:02 2003 EDT Modified files: (Branch: PHP_4_3) /php-srcNEWS Log: BFN + proper credit for session bug fix. Index: php-src/NEWS diff -u php-src/NEWS:1.1247.2.292 php-src/NEWS:1.1247.2.293 --- php-src/NEWS:1.1247.2.292 Mon Jul 21

[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS

2003-07-21 Thread Sascha Schumann
sas Mon Jul 21 21:39:53 2003 EDT Modified files: (Branch: PHP_4_3) /php-srcNEWS Log: fix typo, shorten line Index: php-src/NEWS diff -u php-src/NEWS:1.1247.2.293 php-src/NEWS:1.1247.2.294 --- php-src/NEWS:1.1247.2.293 Mon Jul 21 21:35:02 2003 +++