Re: [PHP-CVS] com php-src: Fixed problem introduced in a763929 (fixing bug #61347).: ext/spl/spl_array.c

2012-03-28 Thread Alexey Shein
Thanks for fixing this! 28 марта 2012 г. 17:04 пользователь Gustavo André dos Santos Lopes написал: > Commit:    f07dd29fdca49228551e8d39fb4282b33dffaa23 > Author:    Gustavo André dos Santos Lopes         Wed, > 28 Mar 2012 13:04:41 +0100 > Parents:   067603106eba10e7648ccfe11834b10580fde2a9 >

Re: [PHP-CVS] com php-src: ext/pcntl/pcntl.c: Fix typo in comment: ext/pcntl/pcntl.c

2012-03-28 Thread Alexey Shein
29 марта 2012 г. 5:47 пользователь Yasuo Ohgaki написал: > Hi, > > I was following the instruction of the pull request page > > https://qa.php.net/pulls/#repo=php-src > > The instruction on the page only considered working on > master, but php-src has several active branches. > > I merged this sim

Re: [PHP-CVS] com php-src: Fixed bug Fixed bug #61605 (header_remove() does not remove all headers): NEWS main/SAPI.c sapi/cgi/tests/bug61605.phpt

2012-04-04 Thread Alexey Shein
4 апреля 2012 г. 13:14 пользователь Xinchen Hui написал: > Commit:    efd671f242e87e3301a1b3e76179955f26119feb > Author:    Xinchen Hui         Wed, 4 Apr 2012 16:14:28 > +0800 > Parents:   3ea9fa1b4626f6125f25d8b0bcffac7becc1d092 > Branches:  PHP-5.4 > > Link:       > http://git.php.net/?p=php

Re: [PHP-CVS] com php-src: Fixed bug Fixed bug #61605 (header_remove() does not remove all headers): NEWS main/SAPI.c sapi/cgi/tests/bug61605.phpt

2012-04-04 Thread Alexey Shein
4 апреля 2012 г. 14:03 пользователь Laruence написал: > seems right here https://github.com/php/php-src/network.. > > maybe the ci message is wrong. > > thanks CI is out of business here. It seems you had a conflict when merging into master, please correct NEWS file in PHP-5.4 branch: https://git

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/curl/tests/ bug48203.phpt bug48203_multi.phpt curl_file_deleted_before_curl_close.phpt

2011-06-09 Thread Alexey Shein
Reopened bug and uploaded my patch here: http://bugs.php.net/bug.php?id=48203. 2011/6/9 Shein Alexey : > shein                                    Thu, 09 Jun 2011 07:16:13 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=311959 > > Log: > Updated (curre

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/dom/examples/note.dtd branches/PHP_5_4/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt trunk/ext/dom/examples/note.dtd trunk/ext/dom/te

2011-06-09 Thread Alexey Shein
PHP_5_3 version? 2011/6/5 Hannes Magnusson : > bjori                                    Sun, 05 Jun 2011 11:31:18 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=311827 > > Log: > No need to fetch external files and endless amount of DTDs for this test > > Changed paths: >    

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt branches/PHP_5_4/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt trunk/ext/dom/t

2011-06-09 Thread Alexey Shein
It seems your fix should only belong to PHP_5_3 branch, since it doesn't fit anymore into others after bjori's changes. 2011/6/9 Ilia Alshanetsky : > iliaa                                    Wed, 08 Jun 2011 23:30:02 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=311955 > > L

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/dom/examples/note.dtd branches/PHP_5_4/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt trunk/ext/dom/examples/note.dtd trunk/ext/dom/te

2011-06-09 Thread Alexey Shein
haven't applied it to PHP_5_3 branch as well. > -Hannes > > On Thu, Jun 9, 2011 at 11:09, Alexey Shein wrote: >> PHP_5_3 version? >> >> 2011/6/5 Hannes Magnusson : >>> bjori                                    Sun, 05 Jun 2011 11:31:18 + >>&g

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/config.m4 branches/PHP_5_4/sapi/cli/config.w32 branches/PHP_5_4/sapi/cli/php_cli.c branches/PHP_5_4/sapi/cli/php_cli_server.c branches/PHP_5_

2011-06-21 Thread Alexey Shein
Anybody? It seems Pierre fixed only windows build, at least, mine is still broken: sapi/cli/php_cli.o: In function `main': /home/conf/php-src/trunk/sapi/cli/php_cli.c:1301: undefined reference to `cli_server_sapi_module' /home/conf/php-src/trunk/sapi/cli/php_cli.c:1361: undefined reference to `do_

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/config.m4 branches/PHP_5_4/sapi/cli/config.w32 branches/PHP_5_4/sapi/cli/php_cli.c branches/PHP_5_4/sapi/cli/php_cli_server.c branches/PHP_5_

2011-06-22 Thread Alexey Shein
2011/6/22 Christopher Jones : > > > On 06/21/2011 11:01 PM, Alexey Shein wrote: >> >> Anybody? It seems Pierre fixed only windows build, at least, mine is >> still broken: > > I've built 5.4 & trunk OK on a couple of Linux machines.  Have you > c

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/dom/examples/note.dtd branches/PHP_5_4/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt trunk/ext/dom/examples/note.dtd trunk/ext/dom/te

2011-06-22 Thread Alexey Shein
inutes for the test to run. > > -Hannes > > On Thu, Jun 9, 2011 at 11:09, Alexey Shein wrote: >> PHP_5_3 version? >> >> 2011/6/5 Hannes Magnusson : >>> bjori                                    Sun, 05 Jun 2011 11:31:18 + >>> >>> Revision:

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/dom/tests/DOMDocument_loadHTML_error1.phpt branches/PHP_5_3/ext/dom/tests/DOMDocument_loadHTML_error2.phpt branches/PHP_5_3/ext/dom/tests/DOMDocum

2011-07-04 Thread Alexey Shein
It seems php/php-src/trunk/ext/dom/tests/DOMDocument_relaxNGValidate_error2.phpt is incorrect and doesn't take into account printed warnings on non-existant relax-ng scheme. 2011/6/29 Knut Urdalen : > knut                                     Tue, 28 Jun 2011 20:17:15 + > > Revision: http://svn

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt trunk/ext/session/tests/rfc1867_invalid_settings.phpt

2011-09-04 Thread Alexey Shein
Hello, why did you fix the test this way? Why not to fix the code and remove excessive warning? 2011/9/4 Ferenc Kovacs : > tyrael                                   Sun, 04 Sep 2011 14:28:52 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316109 > > Log: > passing an invalid se

[PHP-CVS] Re: =?utf-8?q?svn:_/php/php-src/_branches/PHP=5F5=5F4/ext/xsl/tests/xsltprocessor=5FregisterPHPFunctions-funcnostring.phpt_branches/PHP=5F5=5F4/ext/xsl/tests/xsltprocessor=5FregisterPHPFunct

2011-09-05 Thread Alexey Shein
2011/9/5 Christian Stocker : > Hi > > Why did you do that? They're different on purpose. > > I'll revert that, since the tests now fail. > I spotted them on gcov.php.net (it's x64 box, see at the bottom http://gcov.php.net/viewer.php?version=PHP_5_4&func=system), so I checked them on my x64 ubuntu

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt trunk/ext/session/tests/rfc1867_invalid_settings.phpt

2011-09-05 Thread Alexey Shein
gt; so I think that it is the intended behavior. > so changing the test to expect this seemed the logical choice. > > On Sun, Sep 4, 2011 at 6:10 PM, Alexey Shein wrote: >> Hello, why did you fix the test this way? Why not to fix the code and >> remove excessive warning? >&g

[PHP-CVS] Re: =?utf-8?q?svn:_/php/php-src/_branches/PHP=5F5=5F4/ext/xsl/tests/xsltprocessor=5FregisterPHPFunctions-funcnostring.phpt_branches/PHP=5F5=5F4/ext/xsl/tests/xsltprocessor=5FregisterPHPFunct

2011-09-05 Thread Alexey Shein
Just tested at home on x86 box, all tests pass. It seems I forgot to svn up before changing this, sorry again for messing things up. 2011/9/5 Alexey Shein : > 2011/9/5 Christian Stocker : >> Hi >> >> Why did you do that? They're different on purpose. >> >>

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/directory/open_basedir_001.phpt branches/PHP_5_4/ext/standard/tests/directory/open_basedir_001.phpt trunk/ext/standard/tests/direct

2011-09-06 Thread Alexey Shein
Pierre, the code and skip messages like this contradict each other: > +--SKIPIF-- > + +if (substr(PHP_OS, 0, 3) == 'WIN') { > +       die('skip.. only for Windows'); > +} You're checking that OS is Windows but message says that test is only for windows. If your intention was to skip this test on W

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/curl/interface.c branches/PHP_5_3/ext/curl/tests/bug48203.phpt branches/PHP_5_3/ext/curl/tests/bug54798.phpt branches/PHP_5_

2011-09-08 Thread Alexey Shein
Hello, Hannes! It seems your fix is wrong, bug54798 still fails on my machine on trunk, 5.4 and 5.3 branches (ubuntu x64). IMO you should move your patch one line upper, i.e. before call to _php_curl_cleanup_handle(ch); since error is rasing there. I've also made some patches for this, could you r

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/curl/interface.c branches/PHP_5_3/ext/curl/multi.c branches/PHP_5_3/ext/curl/php_curl.h branches/PHP_5_3/ext/curl/tests/bug48203_multi.phpt branch

2011-09-12 Thread Alexey Shein
Hello, found memleak in a couple of tests: http://pastebin.com/pGpkr8GR 2011/9/12 Hannes Magnusson : > bjori                                    Mon, 12 Sep 2011 09:16:04 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316511 > > Log: > Fixed issues when streams were closed be

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c branches/PHP_5_4/sapi/cli/tests/php_cli_server_004.phpt trunk/sapi/cli/php_cli_server.c trunk/sapi/cli

2011-09-21 Thread Alexey Shein
Hello, laruence, could you also take a look here: http://tools.ietf.org/html/draft-robinson-www-interface-00 (see chapter 5. Environment variables) and add them too? Thank you. 2011/9/21 Xinchen Hui : > laruence                                 Wed, 21 Sep 2011 03:09:42 + > > Revision: http://

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/curl/interface.c trunk/ext/curl/interface.c

2011-09-23 Thread Alexey Shein
Hello, any regression tests to be added? 2011/9/23 Rasmus Lerdorf : > rasmus                                   Fri, 23 Sep 2011 13:16:37 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=317201 > > Log: > Fix for bug #55767 > > Bug: https://bugs.php.net/55767 (Open) CURLOPT_POST

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/tests/lang/ 019.phpt

2012-01-03 Thread Alexey Shein
2012/1/4 Nuno Lopes : > Gah, thank you! > Nuno > You're welcome. Could you please also look at this failing test: http://ci.qa.php.net/job/php-src-trunk-matrix-build/architecture=x86,os=linux-debian-6.0/lastCompletedBuild/testReport/php-src.ext.standard.tests/general_functions/bug39322_phpt___Bug_

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/session/tests/bug60634.phpt branches/PHP_5_4/ext/session/tests/bug60634.phpt trunk/ext/session/tests/bug60634.phpt

2012-01-03 Thread Alexey Shein
Hello, Arpad, Could you add XFAIL section to your test since it's failing on all branches (as can be seen for example here: http://ci.qa.php.net/job/php-src-trunk-matrix-build/architecture=x86,os=linux-debian-6.0/lastCompletedBuild/testReport/) or, which is better, fix it :) Thank you. 2012/1/4 A

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/general_functions/bug39322.phpt branches/PHP_5_4/ext/standard/tests/general_functions/bug39322.phpt trunk/ext/standard/tests/genera

2012-01-09 Thread Alexey Shein
Thanks for fixiing this! :) 2012/1/8 Nuno Lopes : > nlopess                                  Sun, 08 Jan 2012 18:03:56 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=321933 > > Log: > do kill 9 to fix a race condition in this test. (should fix the debian 32-bit > buildbot) >