[PHP-CVS] cvs: php-src /sapi/cli/tests 016.phpt

2008-07-06 Thread Nuno Lopes
nlopess Sun Jul 6 16:42:10 2008 UTC Modified files: /php-src/sapi/cli/tests 016.phpt Log: MFB http://cvs.php.net/viewvc.cgi/php-src/sapi/cli/tests/016.phpt?r1=1.1&r2=1.2&diff_format=u Index: php-src/sapi/cli/tests/016.phpt diff -u php-src/sapi/cli/tests/016

[PHP-CVS] cvs: php-src /tests/lang bug44654.phpt

2008-07-06 Thread Nuno Lopes
nlopess Sun Jul 6 16:43:36 2008 UTC Modified files: /php-src/tests/lang bug44654.phpt Log: uhm, forgot to commit this one http://cvs.php.net/viewvc.cgi/php-src/tests/lang/bug44654.phpt?r1=1.1&r2=1.2&diff_format=u Index: php-src/tests/lang/bug44654.phpt diff -u

[PHP-CVS] cvs: php-src(PHP_5_3) /sapi/cli/tests 021.phpt

2008-07-06 Thread Nuno Lopes
nlopess Sun Jul 6 16:59:39 2008 UTC Added files: (Branch: PHP_5_3) /php-src/sapi/cli/tests 021.phpt Log: add test for the shebang thing http://cvs.php.net/viewvc.cgi/php-src/sapi/cli/tests/021.phpt?view=markup&rev=1.1 Index: php-src/sapi/cli/tests/021.ph

[PHP-CVS] cvs: php-src /sapi/cli/tests 021.phpt

2008-07-06 Thread Nuno Lopes
nlopess Sun Jul 6 17:00:00 2008 UTC Modified files: /php-src/sapi/cli/tests 021.phpt Log: add http://cvs.php.net/viewvc.cgi/php-src/sapi/cli/tests/021.phpt?r1=1.1&r2=1.2&diff_format=u Index: php-src/sapi/cli/tests/021.phpt diff -u /dev/null php-src/sapi/cli

[PHP-CVS] cvs: php-src(PHP_5_3) /tests/lang comments.phpt comments2.phpt script_tag.phpt

2008-07-08 Thread Nuno Lopes
nlopess Tue Jul 8 14:38:31 2008 UTC Added files: (Branch: PHP_5_3) /php-src/tests/lang comments2.phpt script_tag.phpt Modified files: /php-src/tests/lang comments.phpt Log: add more tests for the parser. currently both fail http://cvs.ph

[PHP-CVS] cvs: php-src /tests/lang comments.phpt comments2.phpt script_tag.phpt

2008-07-08 Thread Nuno Lopes
nlopess Tue Jul 8 14:39:14 2008 UTC Modified files: /php-src/tests/lang comments2.phpt script_tag.phpt comments.phpt Log: add new tests http://cvs.php.net/viewvc.cgi/php-src/tests/lang/comments2.phpt?r1=1.1&r2=1.2&diff_format=u Index: php-src/tests/lang/comment

[PHP-CVS] cvs: php-src(PHP_5_3) / run-tests.php

2008-07-08 Thread Nuno Lopes
nlopess Tue Jul 8 18:18:08 2008 UTC Modified files: (Branch: PHP_5_3) /php-srcrun-tests.php Log: increase pcre.backtrack_limit so that the phpinfo.phpt test passes on my computer. we should really consider increase the default of this limit.. (but not the r

[PHP-CVS] cvs: php-src / run-tests.php

2008-07-08 Thread Nuno Lopes
nlopess Tue Jul 8 18:18:49 2008 UTC Modified files: /php-srcrun-tests.php Log: MFB: increase pcre.backtrack_limit http://cvs.php.net/viewvc.cgi/php-src/run-tests.php?r1=1.360&r2=1.361&diff_format=u Index: php-src/run-tests.php diff -u php-src/run-tests.php:

[PHP-CVS] cvs: php-src(PHP_4_4) /main php_compat.h

2008-07-17 Thread Nuno Lopes
nlopess Thu Jul 17 14:33:36 2008 UTC Modified files: (Branch: PHP_4_4) /php-src/main php_compat.h Log: update PCRE symbols http://cvs.php.net/viewvc.cgi/php-src/main/php_compat.h?r1=1.11.4.6.2.4&r2=1.11.4.6.2.5&diff_format=u Index: php-src/main/php_compat.h

[PHP-CVS] cvs: php-src(PHP_5_3) /main php_compat.h

2008-07-17 Thread Nuno Lopes
nlopess Thu Jul 17 14:34:51 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main php_compat.h Log: update PCRE symbols http://cvs.php.net/viewvc.cgi/php-src/main/php_compat.h?r1=1.25.2.3.2.4.2.1&r2=1.25.2.3.2.4.2.2&diff_format=u Index: php-src/main/php_

[PHP-CVS] cvs: php-src /main php_compat.h

2008-07-17 Thread Nuno Lopes
nlopess Thu Jul 17 14:35:33 2008 UTC Modified files: /php-src/main php_compat.h Log: update PCRE symbols http://cvs.php.net/viewvc.cgi/php-src/main/php_compat.h?r1=1.34&r2=1.35&diff_format=u Index: php-src/main/php_compat.h diff -u php-src/main/php_compat.

[PHP-CVS] cvs: php-src(PHP_4_4) /win32 php4dllts.dsp

2008-07-17 Thread Nuno Lopes
nlopess Thu Jul 17 14:42:15 2008 UTC Modified files: (Branch: PHP_4_4) /php-src/win32 php4dllts.dsp Log: update for PCRE upgrade http://cvs.php.net/viewvc.cgi/php-src/win32/php4dllts.dsp?r1=1.87.2.9.2.5&r2=1.87.2.9.2.6&diff_format=u Index: php-src/win32/php4d

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard browscap.c

2008-08-07 Thread Nuno Lopes
nlopess Thu Aug 7 12:50:17 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard browscap.c Log: upgrade to PCRE (i.e. get ride of ereg usage) http://cvs.php.net/viewvc.cgi/php-src/ext/standard/browscap.c?r1=1.85.2.2.2.3.2.6&r2=1.85.2.2.2.3.2.7&

[PHP-CVS] cvs: php-src /ext/standard browscap.c

2008-08-07 Thread Nuno Lopes
nlopess Thu Aug 7 12:51:05 2008 UTC Modified files: /php-src/ext/standard browscap.c Log: MFB: upgrade to PCRE http://cvs.php.net/viewvc.cgi/php-src/ext/standard/browscap.c?r1=1.99&r2=1.100&diff_format=u Index: php-src/ext/standard/browscap.c diff -u php-

[PHP-CVS] cvs: php-src(PHP_5_3) /sapi/litespeed config.m4

2008-08-07 Thread Nuno Lopes
nlopess Thu Aug 7 19:32:15 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/sapi/litespeed config.m4 Log: fix this, so that I can build php without litespeed.. http://cvs.php.net/viewvc.cgi/php-src/sapi/litespeed/config.m4?r1=1.2.2.3&r2=1.2.2.4&diff_forma

[PHP-CVS] cvs: php-src /sapi/litespeed config.m4

2008-08-07 Thread Nuno Lopes
nlopess Thu Aug 7 19:32:48 2008 UTC Modified files: /php-src/sapi/litespeed config.m4 Log: MFB: fix build http://cvs.php.net/viewvc.cgi/php-src/sapi/litespeed/config.m4?r1=1.3&r2=1.4&diff_format=u Index: php-src/sapi/litespeed/config.m4 diff -u php-src/sapi

[PHP-CVS] cvs: php-src /ext/curl/tests .cvsignore

2008-08-11 Thread Nuno Lopes
nlopess Mon Aug 11 15:18:47 2008 UTC Added files: /php-src/ext/curl/tests .cvsignore Log: add http://cvs.php.net/viewvc.cgi/php-src/ext/curl/tests/.cvsignore?view=markup&rev=1.1 Index: php-src/ext/curl/tests/.cvsignore +++ php-src/ext/curl/tests/.cvsigno

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/curl/tests .cvsignore

2008-08-11 Thread Nuno Lopes
nlopess Mon Aug 11 15:20:57 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/curl/tests .cvsignore Log: add http://cvs.php.net/viewvc.cgi/php-src/ext/curl/tests/.cvsignore?view=markup&rev=1.1 Index: php-src/ext/curl/tests/.cvsignore +++ php-src/ext/cu

[PHP-CVS] cvs: php-src /ext/mbstring mbstring.c

2008-08-11 Thread Nuno Lopes
nlopess Mon Aug 11 15:40:41 2008 UTC Modified files: /php-src/ext/mbstring mbstring.c Log: fix build when host machine doest has pcre installed http://cvs.php.net/viewvc.cgi/php-src/ext/mbstring/mbstring.c?r1=1.295&r2=1.296&diff_format=u Index: php-src/ext

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c

2008-08-11 Thread Nuno Lopes
nlopess Mon Aug 11 15:42:35 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mbstring mbstring.c Log: MFH: fix build when pcre is not present http://cvs.php.net/viewvc.cgi/php-src/ext/mbstring/mbstring.c?r1=1.224.2.22.2.25.2.29&r2=1.224.2.22.2.25.2.3

[PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests bug44925.phpt

2008-08-14 Thread Nuno Lopes
nlopess Thu Aug 14 13:12:42 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/pcre/tests bug44925.phpt Modified files: /php-srcNEWS /php-src/ext/pcre php_pcre.c Log: Fixed bug #44925 (preg_grep() modifies input array) ht

[PHP-CVS] cvs: php-src /ext/pcre php_pcre.c /ext/pcre/tests bug44925.phpt

2008-08-14 Thread Nuno Lopes
nlopess Thu Aug 14 14:35:23 2008 UTC Modified files: /php-src/ext/pcre php_pcre.c /php-src/ext/pcre/tests bug44925.phpt Log: sync with 5.3 branch. add test for bug #44925 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/php_pcre.c?r1=1.237&r2=1.238&diff

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre php_pcre.c /ext/pcre/tests bug44925.phpt

2008-08-14 Thread Nuno Lopes
nlopess Thu Aug 14 14:37:39 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre php_pcre.c /php-src/ext/pcre/tests bug44925.phpt Log: after rereading the documentation about preg_grep(), lets match the behavior in HEAD (return the original array

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests bug44925.phpt

2008-08-14 Thread Nuno Lopes
ch yet so bug fixes MUST go there too. In which case you move that NEWS entry to the PHP_5_2 NEWS.. --Jani Nuno Lopes [EMAIL PROTECTED] kirjoitti: nlopess Thu Aug 14 13:12:42 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/pcre/tests bug44925.phpt Modified files:

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard streamsfuncs.c

2005-06-22 Thread Nuno Lopes
-/* {{{ proto long stream_copy_to_stream(resource source, resource dest [, long maxlen ]) +/* {{{ proto long stream_copy_to_stream(resource source, resource dest [, long maxlen [, long pos]]) Reads up to maxlen bytes from source stream and writes them to dest stream. */ PHP_FUNCTION(stream_c

Re: [PHP-CVS] cvs: php-src(PHP_5_0) /pear go-pear-list.php

2005-06-26 Thread Nuno Lopes
Watch out! You have a cvs conflict below: $packages = array( // required packages for the installer "PEAR" =>"1.3.5", -"XML_RPC" =>"1.2.2", +"XML_RPC" =>"1.3.0", "Console_Getopt"=>"1.2", +<<< go-pear-list.php +"Archive_Tar

Re: [PHP-CVS] cvs: php-src / NEWS /ext/dbx .cvsignore CREDITS INSTALL config.m4 config.w32 dbx.c dbx.dsp dbx.h dbx_fbsql.c dbx_fbsql.h dbx_mssql.c dbx_mssql.h dbx_mysql.c dbx_mysql.h dbx_oci8.c dbx_o

2005-07-12 Thread Nuno Lopes
- Original Message - sniper Sun Jul 10 15:05:10 2005 EDT Modified files: /php-src NEWS Log: - Moved ext/dbx and ext/ircg to PECL. Can you please also create the pecl pages, so that we can link them from the docs? When we don't do that, we always receive lots of notes and bug rep

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /win32/build buildconf.js

2005-09-18 Thread Nuno Lopes
edink Sat Sep 17 16:00:02 2005 EDT Modified files: (Branch: PHP_5_1) /php-src/win32/build buildconf.js Log: Added --add-modules-dir option to buidconf.js: If this option is not specified buildconf.js will search for PECL in the usual places (pecl, ../pecl). Now it is possibl

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/date php_date.c

2005-10-07 Thread Nuno Lopes
derick Wed Oct 5 07:06:57 2005 EDT Modified files: (Branch: PHP_5_1) /php-src/ext/date php_date.c Log: - Implement correct Windows timezone guessing. Thanks for you work, Derick! However after checking the correct TZ, you forgot to return it :) Something like the above will

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/date php_date.c

2005-10-07 Thread Nuno Lopes
derick Wed Oct 5 07:06:57 2005 EDT Modified files: (Branch: PHP_5_1) /php-src/ext/date php_date.c Log: - Implement correct Windows timezone guessing. Thanks for you work, Derick! However after checking the correct TZ, you forgot to return it :) Something like the above will

Re: [PHP-CVS] cvs: php-src /ext/pspell pspell.c

2005-10-17 Thread Nuno Lopes
Thanks for fixing that out. Now it is correct! My test case was obviously not using the api correctly. Nuno - Original Message - From: "Ilia Alshanetsky" <[EMAIL PROTECTED]> To: Sent: Monday, October 17, 2005 4:29 PM Subject: [PHP-CVS] cvs: php-src /ext/pspell pspell.c iliaa Mon

Re: [PHP-CVS] cvs: php-src / genfiles

2005-11-08 Thread Nuno Lopes
And what about flex/bison parsers? - Original Message - sniper Tue Nov 8 15:21:40 2005 EDT Modified files: /php-src genfiles Log: More files to have #line directives stripped for release http://cvs.php.net/diff.php/php-src/genfiles?r1=1.23&r2=1.24&ty=u Index: php-src/genfiles

Re: [PHP-CVS] cvs: php-src / genfiles

2005-11-08 Thread Nuno Lopes
Zend ones. Zend/zend_ini_scanner.c, language_parser, ini_parser,etc .. 'grep -lr "#line" *' shows all them :) Nuno - Original Message - Be more precise, which ones? :) The relevant ones are handled in the beginning of this file. --Jani On Tue, 8

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / INSTALL

2005-11-18 Thread Nuno Lopes
Please don't touch in the INSTALL and win32/install.txt files directly, because they are created automatically from the phpdoc files (make install-unix.txt && make install-win.txt) Thanks, Nuno - Original Message - sniper Fri Nov 18 11:09:51 2005 EDT Modified files: (

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / INSTALL

2005-11-19 Thread Nuno Lopes
er to have it that way. I'll leave them alone from now on. :) --Jani On Fri, 18 Nov 2005, Nuno Lopes wrote: Please don't touch in the INSTALL and win32/install.txt files directly, because they are created automatically from the phpdoc files (make install-unix.txt &&

Re: [PHP-CVS] cvs: php-src /ext/simplexml simplexml.c

2005-11-20 Thread Nuno Lopes
helly Sun Nov 20 08:03:19 2005 EDT Modified files: /php-src/ext/simplexml simplexml.c Log: - Extend SimpleXmlElement::__construct() with two parameters . int options: pass options to 2.6.0+ parsing functions . bool data_is_url: whether first parameter is a url rather then xml data

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /main php_version.h

2005-11-27 Thread Nuno Lopes
Watch out.. The DOM extension build is broken.. Nuno - Original Message - iliaa Sun Nov 27 12:29:55 2005 EDT Modified files: (Branch: PHP_5_1) /php-src configure.in /php-src/main php_version.h Log: Back to dev http://cvs.php.net/diff.php/php-src/configure.in?r1

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /main php_version.h

2005-11-27 Thread Nuno Lopes
Which build are you referring to? I just build 5.1.1-cvs with and without ZTS mode and dom extension compiled fine. I also checked the win32 snapshot box and there appear to be no issues with building the dom extension. All dom tests pass as well, more over the last DOM change was before 5.1.0 wa

Re: [PHP-CVS] cvs: php-src / run-tests.php

2005-12-01 Thread Nuno Lopes
redirect the valgrind output to another fd (--log-fd=3) and make run-tests.php also read that fd. Nuno - Original Message - From: "Dmitry Stogov" <[EMAIL PROTECTED]> To: "'Marcus Boerger'" <[EMAIL PROTECTED]>; "Nuno Lopes" <[EMAIL

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/standard/tests/file bug35781.phpt /main/streams plain_wrapper.c streams.c

2005-12-23 Thread Nuno Lopes
@@ -316,7 +316,7 @@ if (data->fd >= 0) { ret = read(data->fd, buf, count); - stream->eof = (ret == 0 || (ret == -1 && errno != EWOULDBLOCK)); + stream->eof = (ret == 0 || (ret == (size_t)-1 && errno != EWOULDBLOCK)); } else { #if HAVE_FLUSHIO Watch out! EAGAIN and EWOULDBLOCK can have diffe

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/standard/tests/file bug35781.phpt/main/streams plain_wrapper.c streams.c

2005-12-24 Thread Nuno Lopes
On 23.12.2005 21:29, Nuno Lopes wrote: @@ -316,7 +316,7 @@ if (data->fd >= 0) { ret = read(data->fd, buf, count); - stream->eof = (ret == 0 || (ret == -1 && errno != EWOULDBLOCK)); + stream->eof = (ret == 0 || (ret == (size_t)-1 && errno != EWOULDBLOCK)); }

Re: [PHP-CVS] cvs: php-src /sapi/cgi fastcgi.c fastcgi.h

2005-12-26 Thread Nuno Lopes
zeev Mon Dec 26 07:25:45 2005 EDT Added files: /php-src/sapi/cgi fastcgi.c fastcgi.h Log: Commit missing files - sorry! I've made a little patch to fix compile warnings and to define MAXPATHLEN properly on windows (defined in php.h). http://mega.ist.utl.pt/~ncpl/php_fastcgi.txt Nuno

Re: [PHP-CVS] cvs: php-src /ext/gd/tests gif.phpt

2005-12-26 Thread Nuno Lopes
Probably you want also to test for imagecreatefromjpeg existence in SKIPIF. Nuno - Original Message - pajoye Mon Dec 26 19:11:51 2005 EDT Added files: /php-src/ext/gd/tests gif.phpt Log: - basic gif i/o test http://cvs.php.net/viewcvs.cgi/php-src/ext/gd/tests/gif.phpt?view=ma

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/gd gd.c

2006-01-17 Thread Nuno Lopes
@@ -1095,6 +1095,7 @@ zval *IM; long red, green, blue, alpha; gdImagePtr im; + int ct = (-1); if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &IM, &red, &green, &blue, &alpha) == FAILURE) { RETURN_FALSE; @@ -1103,6 +1104,12 @@ ZEND_FETCH_RESOURCE(im, gdImagePtr, &IM, -1, "Im

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / NEWS /ext/standard url.c

2006-01-19 Thread Nuno Lopes
iliaa Wed Jan 18 14:05:14 2006 UTC Modified files: (Branch: PHP_5_1) /php-src/ext/standard url.c /php-src NEWS Log: Make get_headers() use the default context. http://cvs.php.net/viewcvs.cgi/php-src/ext/standard/url.c?r1=1.86.2.3&r2=1.86.2.4&diff_format=u Index: php-src/ex

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre/tests preg_filter.phpt

2008-08-31 Thread Nuno Lopes
nlopess Sun Aug 31 15:28:35 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre/tests preg_filter.phpt Log: remove unicode skipif, as the test doesnt require such support http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/tests/preg_filter.phpt?r1=1.1.2.

[PHP-CVS] cvs: php-src /ext/pcre/tests preg_filter.phpt

2008-08-31 Thread Nuno Lopes
nlopess Sun Aug 31 15:28:52 2008 UTC Modified files: /php-src/ext/pcre/tests preg_filter.phpt Log: MFB: remove extra skipif http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/tests/preg_filter.phpt?r1=1.1&r2=1.2&diff_format=u Index: php-src/ext/pcre/tests/preg_f

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre php_pcre.c

2008-09-02 Thread Nuno Lopes
nlopess Tue Sep 2 19:10:39 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre php_pcre.c Log: kill dead variables. found by LLVM's clang static analyzer http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/php_pcre.c?r1=1.168.2.9.2.21.2.22&r2=1.168.2.9.2.2

[PHP-CVS] cvs: php-src /ext/pcre php_pcre.c

2008-09-02 Thread Nuno Lopes
nlopess Tue Sep 2 19:13:24 2008 UTC Modified files: /php-src/ext/pcre php_pcre.c Log: MFB: kill unused var http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/php_pcre.c?r1=1.239&r2=1.240&diff_format=u Index: php-src/ext/pcre/php_pcre.c diff -u php-src/ext/pcre/ph

[PHP-CVS] cvs: php-src(PHP_5_3) /main php_compat.h

2008-09-14 Thread Nuno Lopes
nlopess Sun Sep 14 14:15:52 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main php_compat.h Log: update list of pcre symbols http://cvs.php.net/viewvc.cgi/php-src/main/php_compat.h?r1=1.25.2.3.2.4.2.2&r2=1.25.2.3.2.4.2.3&diff_format=u Index: php-src/m

[PHP-CVS] cvs: php-src /ext/iconv iconv.c /ext/pcre php_pcre.c /ext/standard array.c base64.c image.c versioning.c /main rfc1867.c /main/streams glob_wrapper.c ZendEngine2 zend_constants.c

2008-09-23 Thread Nuno Lopes
nlopess Tue Sep 23 15:22:05 2008 UTC Modified files: /ZendEngine2zend_constants.c /php-src/ext/iconv iconv.c /php-src/ext/pcre php_pcre.c /php-src/ext/standard array.c base64.c image.c versioning.c /php-src/main rfc1867.c

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c assert.c basic_functions.c browscap.c crypt.c file.c filestat.c head.c html.c http.c info.c mail.c math.c proc_open.c rand.c streamsfuncs.c st

2008-10-22 Thread Nuno Lopes
Hey, hey, what are you doing? I assume you're reading the http://gcov.php.net/viewer.php?version=PHP_5_3&func=params page. That script is very dumb and unfortunately shows many false positives. I did a cursory review of your commits and most of the changes you did aren't necessary (in fact the

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pcre/pcrelib ucptable.h

2008-12-08 Thread Nuno Lopes
nlopess Mon Dec 8 20:18:15 2008 UTC Removed files: (Branch: PHP_5_2) /php-src/ext/pcre/pcrelib ucptable.h Log: remove unused file to avoid confusion -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_2) /main php_compat.h

2008-12-09 Thread Nuno Lopes
nlopess Tue Dec 9 22:00:20 2008 UTC Modified files: (Branch: PHP_5_2) /php-src/main php_compat.h Log: update PCRE symbol list (sync with php 5.3). this should fix bug #46800 http://cvs.php.net/viewvc.cgi/php-src/main/php_compat.h?r1=1.25.2.3.2.5&r2=1.25.2.

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre upgrade-pcre.php /ext/pcre/pcrelib config.h

2008-12-10 Thread Nuno Lopes
nlopess Wed Dec 10 10:16:14 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre upgrade-pcre.php /php-src/ext/pcre/pcrelib config.h Log: export the pcre API when compiling with gcc 4. this fixes e.g. the linkage of APC (reported by shire) http:

[PHP-CVS] cvs: php-src /ext/pcre upgrade-pcre.php /ext/pcre/pcrelib config.h

2008-12-10 Thread Nuno Lopes
nlopess Wed Dec 10 10:16:22 2008 UTC Modified files: /php-src/ext/pcre upgrade-pcre.php /php-src/ext/pcre/pcrelib config.h Log: MFB: export pcre API when using gcc 4 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/upgrade-pcre.php?r1=1.3&r2=1.4&diff_form

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pdo pdo_stmt.c

2008-12-11 Thread Nuno Lopes
Modified files: (Branch: PHP_5_3) /php-src/ext/pdo pdo_stmt.c Log: Fixed a possible corruption inside PDOStatement::debugDumpParams() http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_stmt.c?r1=1.118.2.38.2.24.2.39&r2=1.118.2.38.2.24.2.40&diff_format=u Index: php-src/ext/pdo/p

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pdo pdo_stmt.c

2008-12-11 Thread Nuno Lopes
ey) is not guaranteed to be NULL terminated (nor does it need to be), so when strlen() is attempted on top of it you could end up reading more data then necessary. On 11-Dec-08, at 10:43 AM, Nuno Lopes wrote: Modified files: (Branch: PHP_5_3) /php-src/ext/pdo pdo_stmt.c Log: Fixed

[PHP-CVS] cvs: php-src(PHP_5_3) / configure.in /main spprintf.c

2008-12-12 Thread Nuno Lopes
nlopess Fri Dec 12 23:43:18 2008 UTC Modified files: (Branch: PHP_5_3) /php-srcconfigure.in /php-src/main spprintf.c Log: make *printf() functions do not read strings past their specified length (if any) http://cvs.php.net/viewvc.cgi/php-src/confi

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pdo pdo_stmt.c

2008-12-12 Thread Nuno Lopes
nlopess Fri Dec 12 23:46:05 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pdopdo_stmt.c Log: we do not need the strndup() now that php_stream_printf() handles non-null terminated strings correctly http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_s

[PHP-CVS] cvs: php-src / configure.in /main spprintf.c

2008-12-12 Thread Nuno Lopes
nlopess Fri Dec 12 23:55:49 2008 UTC Modified files: /php-srcconfigure.in /php-src/main spprintf.c Log: MFB http://cvs.php.net/viewvc.cgi/php-src/configure.in?r1=1.668&r2=1.669&diff_format=u Index: php-src/configure.in diff -u php-src/configure.in

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pdo pdo_stmt.c

2008-12-12 Thread Nuno Lopes
ally that code needs to be reviewed, but just from general use case I think its safer not to pass non-terminated char pointers around. On 11-Dec-08, at 11:50 AM, Nuno Lopes wrote: Weird.. Isn't that a bug in php_stream_printf() then? I would say it shouldn't read past the specified le

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/ftp/tests ftp_get_basic.phpt server.inc

2008-12-17 Thread Nuno Lopes
Added files: (Branch: PHP_5_2) /php-src/ext/ftp/tests ftp_get_basic.phpt Modified files: /php-src/ext/ftp/tests server.inc Log: New FTP test from Nathaniel McHugh +++ php-src/ext/ftp/tests/ftp_get_basic.phpt --TEST-- FTP ftp_get file for both binary a

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt

2009-01-05 Thread Nuno Lopes
Well,.. at least it breaks BC. I think I prefer not breaking BC in this case, as it doesn't hurt much.. Nuno - Original Message - The fact that any line starting with # was ignored is actually a bug, the original intent (even in 5.2 where the bug also exists in CLI) was to handle #!

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre php_pcre.c /ext/pcre/tests bug47229.phpt preg_quote_basic.phpt

2009-01-28 Thread Nuno Lopes
nlopess Wed Jan 28 22:39:33 2009 UTC Added files: (Branch: PHP_5_3) /php-src/ext/pcre/tests bug47229.phpt Modified files: /php-src/ext/pcre php_pcre.c /php-src/ext/pcre/tests preg_quote_basic.phpt Log: fix bug #47229: preg_quo

[PHP-CVS] cvs: php-src /ext/pcre php_pcre.c /ext/pcre/tests bug47229.phpt preg_quote_basic.phpt

2009-01-28 Thread Nuno Lopes
nlopess Wed Jan 28 22:40:37 2009 UTC Modified files: /php-src/ext/pcre php_pcre.c /php-src/ext/pcre/tests bug47229.phpt preg_quote_basic.phpt Log: MFB: fix bug #47229: preg_quote should escape '-' http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/php_pcr

[PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-28 Thread Nuno Lopes
nlopess Wed Jan 28 22:43:52 2009 UTC Modified files: (Branch: PHP_5_3) /php-srcNEWS Log: BFN http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.479&r2=1.2027.2.547.2.965.2.480&diff_format=u Index: php-src/NEWS diff -u php-src/NEWS:1.2027.2.547

[PHP-CVS] cvs: php-src /ext/standard/tests/file bug46347.phpt ZendEngine2 zend_ini_scanner.l

2009-02-02 Thread Nuno Lopes
nlopess Mon Feb 2 19:25:30 2009 UTC Modified files: /ZendEngine2zend_ini_scanner.l /php-src/ext/standard/tests/filebug46347.phpt Log: MFB: fix #46347 http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_ini_scanner.l?r1=1.60&r2=1.61&diff_format=u Ind

[PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard/tests/file bug46347.phpt ZendEngine2 zend_ini_scanner.l

2009-02-02 Thread Nuno Lopes
nlopess Mon Feb 2 19:23:13 2009 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/filebug46347.phpt Modified files: /php-srcNEWS /ZendEngine2zend_ini_scanner.l Log: fix bug #46347: allow * in ini keys ht

Re: [PHP-CVS] cvs: CVSROOT / avail loginfo

2009-02-28 Thread Nuno Lopes
Thanks Philip! Nuno - Original Message - From: "Philip Olson" To: Sent: Wednesday, February 25, 2009 7:23 AM Subject: [PHP-CVS] cvs: CVSROOT / avail loginfo philip Wed Feb 25 07:23:06 2009 UTC Modified files: /CVSROOT avail loginfo Log: Added php-benchmarks # With initial k

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/strings highlight_file.phpt ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h

2009-03-12 Thread Nuno Lopes
shire Wed Mar 11 22:11:54 2009 UTC Modified files: (Branch: PHP_5_3) /ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h /php-src/ext/standard/tests/strings highlight_file.phpt Log: MFH: Add proper EOF handli

[PHP-CVS] cvs: php-src /ext/bz2 bz2.c /ext/gd gd.c

2006-10-31 Thread Nuno Lopes
nlopess Tue Oct 31 22:13:10 2006 UTC Modified files: /php-src/ext/bz2bz2.c /php-src/ext/gd gd.c Log: cleaning some warnings (char* -> zstr) http://cvs.php.net/viewvc.cgi/php-src/ext/bz2/bz2.c?r1=1.29&r2=1.30&diff_format=u Index: php-src/ext/bz2/bz2.

[PHP-CVS] cvs: php-src /ext/tidy tidy.c

2006-11-01 Thread Nuno Lopes
nlopess Wed Nov 1 18:28:37 2006 UTC Modified files: /php-src/ext/tidy tidy.c Log: start converting the tidy and tidyNode objects to be Unicode aware I added a converter pointer per node, so that the text can be converted to unicode when requested this commi

[PHP-CVS] cvs: php-src /ext/tidy tidy.c

2006-11-01 Thread Nuno Lopes
nlopess Wed Nov 1 18:55:03 2006 UTC Modified files: /php-src/ext/tidy tidy.c Log: convert a few more functions http://cvs.php.net/viewvc.cgi/php-src/ext/tidy/tidy.c?r1=1.105&r2=1.106&diff_format=u Index: php-src/ext/tidy/tidy.c diff -u php-src/ext/tidy/tidy.c

Re: [PHP-CVS] cvs: php-src /ext/tidy tidy.c

2006-11-01 Thread Nuno Lopes
cause you can access child nodes directly. But I still need to think more on the subject. Nuno - Original Message - Do you need a separate converter per node? Can they all be different for some reason? -Andrei On Nov 1, 2006, at 10:28 AM, Nuno Lopes wrote: nlopess Wed Nov 1 18:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/exif exif.c

2006-11-04 Thread Nuno Lopes
Hi Marcus! you are probably referring to the "warnings" pointed out by http://gcov.php.net/viewer.php?version=PHP_5_2&func=params&file=cc163453976b65334f071d1d4f976ef45 But that script currently produces too many false positives.. in this case it doesn't seem (from a quick code analysis) that t

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/xmlwriter php_xmlwriter.c php_xmlwriter.h /ext/zip php_zip.c php_zip.h

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:04:34 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/xmlwriter php_xmlwriter.c php_xmlwriter.h /php-src/ext/zipphp_zip.c php_zip.h Log: statification of local functions and variables. also remove a few uneeded global va

[PHP-CVS] cvs: php-src /ext/xmlwriter php_xmlwriter.c php_xmlwriter.h /ext/zip php_zip.c php_zip.h

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:18:28 2006 UTC Modified files: /php-src/ext/xmlwriter php_xmlwriter.c php_xmlwriter.h /php-src/ext/zipphp_zip.c php_zip.h Log: MFB: static'fication http://cvs.php.net/viewvc.cgi/php-src/ext/xmlwriter/php_xmlwriter.c?r1=1.39&r2=

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/filter callback_filter.c

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:33:07 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/filter callback_filter.c Log: fix an invalid read + invalid free() http://cvs.php.net/viewvc.cgi/php-src/ext/filter/callback_filter.c?r1=1.9.2.2&r2=1.9.2.3&diff_format=u Index: ph

[PHP-CVS] cvs: php-src /ext/filter callback_filter.c

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:34:00 2006 UTC Modified files: /php-src/ext/filter callback_filter.c Log: MFB: fix possible segfault http://cvs.php.net/viewvc.cgi/php-src/ext/filter/callback_filter.c?r1=1.11&r2=1.12&diff_format=u Index: php-src/ext/filter/callback_filter.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/filter/tests 033_run.inc

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:38:28 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/filter/tests 033_run.inc Log: fix test for non English guys http://cvs.php.net/viewvc.cgi/php-src/ext/filter/tests/033_run.inc?r1=1.1.2.4&r2=1.1.2.5&diff_format=u Index: php-src

[PHP-CVS] cvs: php-src /ext/filter/tests 033_run.inc

2006-11-09 Thread Nuno Lopes
nlopess Thu Nov 9 16:38:55 2006 UTC Modified files: /php-src/ext/filter/tests 033_run.inc Log: MFB: fix test http://cvs.php.net/viewvc.cgi/php-src/ext/filter/tests/033_run.inc?r1=1.3&r2=1.4&diff_format=u Index: php-src/ext/filter/tests/033_run.inc diff -u php

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/date/lib parse_tz.c

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 17:32:15 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/date/lib parse_tz.c Log: mark the binary search delimiters as unsigned, so that the compiler can use a quick shift operation http://cvs.php.net/viewvc.cgi/php-src/ext/date/

[PHP-CVS] cvs: php-src /ext/date/lib parse_tz.c

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 17:32:42 2006 UTC Modified files: /php-src/ext/date/lib parse_tz.c Log: MFB http://cvs.php.net/viewvc.cgi/php-src/ext/date/lib/parse_tz.c?r1=1.30&r2=1.31&diff_format=u Index: php-src/ext/date/lib/parse_tz.c diff -u php-src/ext/date/lib/p

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/libxml libxml.c php_libxml.h

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 18:05:12 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/libxml libxml.c php_libxml.h Log: mark a few variables and functions as static http://cvs.php.net/viewvc.cgi/php-src/ext/libxml/libxml.c?r1=1.32.2.7.2.8&r2=1.32.2.7.2.9&diff_forma

[PHP-CVS] cvs: php-src /ext/libxml libxml.c php_libxml.h

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 18:05:58 2006 UTC Modified files: /php-src/ext/libxml libxml.c php_libxml.h Log: MFB http://cvs.php.net/viewvc.cgi/php-src/ext/libxml/libxml.c?r1=1.53&r2=1.54&diff_format=u Index: php-src/ext/libxml/libxml.c diff -u php-src/ext/libxml/libxml.c

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/date/lib parse_tz.c

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 23:27:11 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/date/lib parse_tz.c Log: fix the bug I introduced previously, sorry anyway, convert the recursive version of the binary search to an iterative one http://cvs.php.net/viewv

[PHP-CVS] cvs: php-src /ext/date/lib parse_tz.c

2006-11-10 Thread Nuno Lopes
nlopess Fri Nov 10 23:27:31 2006 UTC Modified files: /php-src/ext/date/lib parse_tz.c Log: MFB http://cvs.php.net/viewvc.cgi/php-src/ext/date/lib/parse_tz.c?r1=1.31&r2=1.32&diff_format=u Index: php-src/ext/date/lib/parse_tz.c diff -u php-src/ext/date/lib/p

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_free.c zip_set_archive_comment.c

2006-11-11 Thread Nuno Lopes
nlopess Sat Nov 11 23:35:27 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/zip/libzip_set_archive_comment.c zip_free.c Log: fix leak in oo_setArchiveComment.phpt http://cvs.php.net/viewvc.cgi/php-src/ext/zip/lib/zip_set_archive_comment.c?r1=1.1&r

[PHP-CVS] cvs: php-src /ext/zip/lib zip_free.c zip_set_archive_comment.c

2006-11-11 Thread Nuno Lopes
nlopess Sat Nov 11 23:36:52 2006 UTC Modified files: /php-src/ext/zip/libzip_set_archive_comment.c zip_free.c Log: MFB :fix leak in oo_setArchiveComment.phpt http://cvs.php.net/viewvc.cgi/php-src/ext/zip/lib/zip_set_archive_comment.c?r1=1.1&r2=1.2&diff_f

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c /ext/zip/lib zip_fclose.c

2006-11-11 Thread Nuno Lopes
nlopess Sat Nov 11 23:43:00 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/zipphp_zip.c /php-src/ext/zip/libzip_fclose.c Log: fix leaks within zip entries in several tests http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.1.2.

[PHP-CVS] cvs: php-src /ext/zip php_zip.c /ext/zip/lib zip_fclose.c

2006-11-11 Thread Nuno Lopes
nlopess Sat Nov 11 23:43:40 2006 UTC Modified files: /php-src/ext/zipphp_zip.c /php-src/ext/zip/libzip_fclose.c Log: MFB: fix leaks within zip entries in several tests http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.29&r2=1.30&diff_

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-11-11 Thread Nuno Lopes
nlopess Sun Nov 12 00:31:04 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/zipphp_zip.c Log: fix leak in the object destrucotr when zip_close() fails (fixes oo_delete.phpt) http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.1.2.18&r2=1.1.2

[PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-11-11 Thread Nuno Lopes
nlopess Sun Nov 12 00:31:37 2006 UTC Modified files: /php-src/ext/zipphp_zip.c Log: MFB: fix leak in the object destrucotr when zip_close() fails (fixes oo_delete.phpt) http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.30&r2=1.31&diff_format=u In

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip zip_stream.c

2006-11-11 Thread Nuno Lopes
nlopess Sun Nov 12 00:41:16 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/zipzip_stream.c Log: fix leak in oo_stream.phpt http://cvs.php.net/viewvc.cgi/php-src/ext/zip/zip_stream.c?r1=1.1.2.1&r2=1.1.2.2&diff_format=u Index: php-src/ext/zip/zip_strea

[PHP-CVS] cvs: php-src /ext/zip zip_stream.c

2006-11-11 Thread Nuno Lopes
nlopess Sun Nov 12 00:41:41 2006 UTC Modified files: /php-src/ext/zipzip_stream.c Log: MFB: fix leak in oo_stream.phpt http://cvs.php.net/viewvc.cgi/php-src/ext/zip/zip_stream.c?r1=1.2&r2=1.3&diff_format=u Index: php-src/ext/zip/zip_stream.c diff -u php-src/

Re: [PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-11-11 Thread Nuno Lopes
On 11/12/06, Nuno Lopes <[EMAIL PROTECTED]> wrote: nlopess Sun Nov 12 00:31:37 2006 UTC Modified files: /php-src/ext/zipphp_zip.c Log: MFB: fix leak in the object destrucotr when zip_close() fails (fixes oo_delete.phpt) http://cvs.php.net/viewvc.cgi/php-src/e

Re: [PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-11-11 Thread Nuno Lopes
Hello, On 11/12/06, Nuno Lopes <[EMAIL PROTECTED]> wrote: > It sounds wrong. _zip_free is a private function and is used in > zip_close. Can you do it there instead? > > itself.oo_delete.phpt works here, which error do you have? > > --Pierre Yes, I also thought that i

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/date/lib parse_tz.c

2006-11-15 Thread Nuno Lopes
On Fri, 10 Nov 2006, Nuno Lopes wrote: nlopess Fri Nov 10 23:27:11 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/date/lib parse_tz.c Log: fix the bug I introduced previously, sorry anyway, convert the recursive version of the binary search to an iterative

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pcre/pcrelib internal.h

2006-11-16 Thread Nuno Lopes
nlopess Thu Nov 16 18:58:02 2006 UTC Removed files: (Branch: PHP_5_2) /php-src/ext/pcre/pcrelib internal.h Log: remove old file (which was already removed from 4.4 and HEAD trees) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://ww

<    1   2   3   4   5   6   7   >