[PHP-CVS] 回复： [PHP-CVS] Re: 回复： [PHP-CVS] com php-src: Fix zend_dval_to_lval outside 64bit integers range: Zend/tests/bug39018.phpt Zend/tests/dval_to_lval_32.phpt Zend/tests/dval_to_lval_64.phpt Zend
I didn't notice that, The tests passed, thanks! -- reeze | reeze.cn 已使用 Sparrow (http://www.sparrowmailapp.com/?sig) 在 2013年2月25日星期一，上午11:17，Gustavo Lopes 写道： On Sun, 24 Feb 2013 06:29:17 +0100, Reeze Xia re...@php.net (mailto:re...@php.net) wrote: I got two tests failed on Mac OS X: ➜ php-src-master git:(master) ✗ cat Zend/tests/dval_to_lval_64.diff 001+ int(-9223372036854775808) 002+ int(-9223372036854775808) 003+ int(-9223372036854775808) 004+ int(-9223372036854775808) 005+ int(-9223372036854775808) 001- int(2943463994971652096) 002- int(2943463994972176384) 003- int(2943463994972700672) 004- int(2943463994973224960) 005- int(2943463994973749248) ➜ php-src-master git:(master) ✗ cat Zend/tests/bug39018.diff 003- Notice: Uninitialized string offset: %s in %s on line 6 004- You have to run make clean or at least delete the object files in Zend. Because only a header file change, the makefile doesn't have anything recompiled. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] 回复： [PHP-CVS] com php-src: Fix zend_dval_to_lval outside 64bit integers range: Zend/tests/bug39018.phpt Zend/tests/dval_to_lval_32.phpt Zend/tests/dval_to_lval_64.phpt Zend/zend_operators.h
Hi Gustavo,
I got two tests failed on Mac OS X:
➜ php-src-master git:(master) ✗ cat Zend/tests/dval_to_lval_64.diff
001+ int(-9223372036854775808)
002+ int(-9223372036854775808)
003+ int(-9223372036854775808)
004+ int(-9223372036854775808)
005+ int(-9223372036854775808)
001- int(2943463994971652096)
002- int(2943463994972176384)
003- int(2943463994972700672)
004- int(2943463994973224960)
005- int(2943463994973749248)
➜ php-src-master git:(master) ✗ cat Zend/tests/bug39018.diff
003- Notice: Uninitialized string offset: %s in %s on line 6
004-
$ uname -a
Darwin MacBookPro.local 12.2.0 Darwin Kernel Version 12.2.0: RELEASE_X86_64
x86_64
--
reeze | reeze.cn
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)
在 2013年2月24日星期日，上午12:23，Gustavo André dos Santos Lopes 写道：
Commit: 77566edbafb969e166239b3fbc929588c6630ee9
Author: Gustavo Lopes glo...@nebm.ist.utl.pt
(mailto:glo...@nebm.ist.utl.pt) Sun, 17 Feb 2013 23:40:26 +0100
Parents: 64a2a8a7536de781aac015e7392cb56308d8aed0
Branches: PHP-5.5 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=77566edbafb969e166239b3fbc929588c6630ee9
Log:
Fix zend_dval_to_lval outside 64bit integers range
PHP should preserve the least significant bits when casting from double
to long. Zend.m4 contains this:
AC_DEFINE([ZEND_DVAL_TO_LVAL_CAST_OK], 1, [Define if double cast to long
preserves least significant bits])
If ZEND_DVAL_TO_LVAL_CAST_OK is not defined, zend_operators.h had an
inline implementation of zend_dval_to_lval() that would do a cast to an
int64_t (when sizeof(long) == 4), then a cast to unsigned long and
finally the cast to long.
While this works well for doubles inside the range of values of the type
used in the first cast (int64_t in the 32-bit version and unsigned long
in the 64-bit version), if outside the range, it is undefined behavior
that WILL give varying and not particularly useful results.
This commit uses fmod() to first put the double in a range that can
safely be cast to unsigned long and then casts this unsigned long to
long. This last cast is implementation defined, but it's very likely
that this gives the expected result (i.e. the internal 2's complement
representation is unchanged) on all platforms that PHP supports. In any
case, the previous implementationa already had this assumption.
This alternative code path is indeed significantly slower than simply
casting the double (almost an order of magnitude), but that should not
matter because casting doubles with a very high absolute value is a
rare event.
Changed paths:
M Zend/tests/bug39018.phpt
A Zend/tests/dval_to_lval_32.phpt
A Zend/tests/dval_to_lval_64.phpt
M Zend/zend_operators.h
Diff:
diff --git a/Zend/tests/bug39018.phpt b/Zend/tests/bug39018.phpt
index 32566ba..a00e1fb 100644
--- a/Zend/tests/bug39018.phpt
+++ b/Zend/tests/bug39018.phpt
@@ -64,6 +64,8 @@ print \nDone\n;
--EXPECTF--
Notice: String offset cast occurred in %s on line %d
+Notice: Uninitialized string offset: %s in %s on line 6
+
Notice: Uninitialized string offset: 0 in %s on line %d
Notice: Uninitialized string offset: 0 in %s on line %d
diff --git a/Zend/tests/dval_to_lval_32.phpt b/Zend/tests/dval_to_lval_32.phpt
new file mode 100644
index 000..ddb16cc
--- /dev/null
+++ b/Zend/tests/dval_to_lval_32.phpt
@@ -0,0 +1,29 @@
+--TEST--
+zend_dval_to_lval preserves low bits (32 bit long)
+--SKIPIF--
+?php
+if (PHP_INT_SIZE != 4)
+ die(skip for machines with 32-bit longs);
+?
+--FILE--
+?php
+ /* test doubles around -4e21 */
+ $values = [
+ -4001048576.,
+ -4000524288.,
+ -40.,
+ -3999475712.,
+ -3998951424.,
+ ];
+
+ foreach ($values as $v) {
+ var_dump((int)$v);
+ }
+
+?
+--EXPECT--
+int(-2056257536)
+int(-2055733248)
+int(-2055208960)
+int(-2054684672)
+int(-2054160384)
diff --git a/Zend/tests/dval_to_lval_64.phpt b/Zend/tests/dval_to_lval_64.phpt
new file mode 100644
index 000..da7f56d
--- /dev/null
+++ b/Zend/tests/dval_to_lval_64.phpt
@@ -0,0 +1,29 @@
+--TEST--
+zend_dval_to_lval preserves low bits (64 bit long)
+--SKIPIF--
+?php
+if (PHP_INT_SIZE != 8)
+ die(skip for machines with 64-bit longs);
+?
+--FILE--
+?php
+ /* test doubles around -4e21 */
+ $values = [
+ -4001048576.,
+ -4000524288.,
+ -40.,
+ -3999475712.,
+ -3998951424.,
+ ];
+
+ foreach ($values as $v) {
+ var_dump((int)$v);
+ }
+
+?
+--EXPECT--
+int(2943463994971652096)
+int(2943463994972176384)
+int(2943463994972700672)
+int(2943463994973224960)
+int(2943463994973749248)
diff --git a/Zend/zend_operators.h b/Zend/zend_operators.h
index 93c60e4..a3a432f 100644
--- a/Zend/zend_operators.h
+++ b/Zend/zend_operators.h
@@ -68,22 +68,36 @@ END_EXTERN_C()
#if ZEND_DVAL_TO_LVAL_CAST_OK
# define zend_dval_to_lval(d) ((long) (d
[PHP-CVS] 回复： [PHP-CVS] com php-src: Fix broken test This was missing a %s for the path here: ext/session/tests/bug60860.phpt
Hi, This test failed with diff: 003+ Fatal error: session_start(): Failed to initialize storage module: user (path: ) in /Users/reeze/Opensource/php-tes t/php-src-master/ext/session/tests/bug60860.php on line 3^M 003- Fatal error: session_start(): Failed to initialize storage module: user (path: %s) in %s on line 3 The `PG(save_path)` might be empty, how about: (path: %s) (path:%s) -- reeze | reeze.cn 已使用 Sparrow (http://www.sparrowmailapp.com/?sig) 在 2012年12月14日星期五，上午8:13，Rasmus Lerdorf 写道： Commit: eecdb4c254bafe5fc53b1e06055482944cd3560f Author: Rasmus Lerdorf ras...@php.net (mailto:ras...@php.net) Thu, 13 Dec 2012 16:13:37 -0800 Parents: a11606b18fd20be1048a858eb5011fb7117855a9 Branches: PHP-5.3 PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=eecdb4c254bafe5fc53b1e06055482944cd3560f Log: Fix broken test This was missing a %s for the path here Changed paths: M ext/session/tests/bug60860.phpt Diff: diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt index 1231020..223fb35 100644 --- a/ext/session/tests/bug60860.phpt +++ b/ext/session/tests/bug60860.phpt @@ -14,4 +14,4 @@ echo ok\n; --EXPECTF-- Warning: session_start(): user session functions not defined in %s on line 3 -Fatal error: session_start(): Failed to initialize storage module: user (path: ) in %s on line 3 +Fatal error: session_start(): Failed to initialize storage module: user (path: %s) in %s on line 3 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] 回复： [PHP-CVS] com php-src: forked two tests for windows: ext/zlib/tests/bug55544-win.phpt ext/zlib/tests/bug55544.phpt ext/zlib/tests/bug_52944-win.phpt ext/zlib/tests/bug_52944.phpt
Hi Anatoliy, 在 2012年9月3日星期一，下午7:37，Anatoliy Belsky 写道： Commit: ff0aa24054c166de64993ef608ccbb8486c64ba5 Author: Anatoliy Belsky a...@php.net (mailto:a...@php.net) Mon, 3 Sep 2012 13:37:34 +0200 Parents: 33db8c0ef6f46917349fbe07514a06f4f98bff85 Branches: PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ff0aa24054c166de64993ef608ccbb8486c64ba5 Log: forked two tests for windows * bug55544.phpt - VT vs. EXT at the start of the data block, but the data can still be decoded correctly * bug_52944.phpt works with the corrupted data and has some different out Most likely the ASM optimization under windows is responsible for this behaviour. Bugs: https://bugs.php.net/55544 Changed paths: A ext/zlib/tests/bug55544-win.phpt M ext/zlib/tests/bug55544.phpt A ext/zlib/tests/bug_52944-win.phpt M ext/zlib/tests/bug_52944.phpt https://bugs.php.net/bug.php?id=62962 It output : '%' 'C' in OSX too, maybe due to the same reason :) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php 附件： - diff_ff0aa24054c166de64993ef608ccbb8486c64ba5.txt
[PHP-CVS] 回复： [PHP-CVS] com php-src: forked two tests for windows: ext/zlib/tests/bug55544-win.phpt ext/zlib/tests/bug55544.phpt ext/zlib/tests/bug_52944-win.phpt ext/zlib/tests/bug_52944.phpt
Hi Anatoliy, I'v attached a patch to https://bugs.php.net/bug.php?id=62962, And I test it on the lastest mac os x 10.8 and 10.7, everything looks fine, anyway it behavior likes windows :) Best, Reeze Xia 在 2012年9月3日星期一，下午9:43，Anatoliy Belsky 写道： Hi Xia, ok, that might be also due to the ASM parts cause I get no issue with the non ASM version under windows. Nevertheless the test works with the corrupted data. Unfortunately I've no macintosh to test that, may be you could fork that test for mac? Cheers Anatoliy On Mon, September 3, 2012 13:58, Reeze Xia wrote: Hi Anatoliy, 在 2012年9月3日星期一，下午7:37，Anatoliy Belsky 写道： Commit: ff0aa24054c166de64993ef608ccbb8486c64ba5 Author: Anatoliy Belsky a...@php.net (mailto:a...@php.net) Mon, 3 Sep 2012 13:37:34 +0200 Parents: 33db8c0ef6f46917349fbe07514a06f4f98bff85 Branches: PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ff0aa24054c166de64993ef608ccbb8486c64ba5 Log: forked two tests for windows * bug55544.phpt - VT vs. EXT at the start of the data block, but the data can still be decoded correctly * bug_52944.phpt works with the corrupted data and has some different out Most likely the ASM optimization under windows is responsible for this behaviour. Bugs: https://bugs.php.net/55544 Changed paths: A ext/zlib/tests/bug55544-win.phpt M ext/zlib/tests/bug55544.phpt A ext/zlib/tests/bug_52944-win.phpt M ext/zlib/tests/bug_52944.phpt https://bugs.php.net/bug.php?id=62962 It output : '%' 'C' in OSX too, maybe due to the same reason :) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php 附件： - diff_ff0aa24054c166de64993ef608ccbb8486c64ba5.txt
[PHP-CVS] 回复： [PHP-CVS] com php-src: Bug doesn't exists in any release: NEWS
-- Reeze Sent with sparrow 在 2012年7月18日星期三，18:00，Xinchen Hui 写道： Commit: c7c939b5d8b2a8e2d7d72bf83c031005e93cd3fe Author: Xinchen Hui larue...@php.net Wed, 18 Jul 2012 18:00:09 +0800 Parents: c7614a8c19d5d1f366ec219e745760ea2133e5a0 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c7c939b5d8b2a8e2d7d72bf83c031005e93cd3fe Log: Bug doesn't exists in any release Changed paths: M NEWS The fix for number_format()'s binary safty is reverted only in 5.4.5 branch https://github.com/php/php-src/commits/PHP-5.4.5 Diff: diff --git a/NEWS b/NEWS index 8dc740c..9da5717 100644 --- a/NEWS +++ b/NEWS @@ -3,8 +3,6 @@ PHP NEWS ?? ??? 2012, PHP 5.4.6 - Core: - . Fixed bug in number_format() when the number was not finite. See pull - request #134. (Reeze Xia) . Fixed bug #62565 (Crashes due non-initialized internal properties_table). (Felipe) @@ -17,7 +15,7 @@ PHP NEWS - Fileinfo: . Fixed bug #61964 (finfo_open with directory causes invalid free). - (reeze@gmail.com) + (reeze@gmail.com) - Intl: . Fixed bug #62564 (Extending MessageFormatter and adding property causes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] 回复： [PHP-CVS] com php-src: Bug doesn't exists in any release: NEWS
-- Reeze Sent with sparrow 在 2012年7月18日星期三，19:20，Reeze 写道： -- Reeze Sent with sparrow 在 2012年7月18日星期三，18:00，Xinchen Hui 写道： Commit: c7c939b5d8b2a8e2d7d72bf83c031005e93cd3fe Author: Xinchen Hui larue...@php.net Wed, 18 Jul 2012 18:00:09 +0800 Parents: c7614a8c19d5d1f366ec219e745760ea2133e5a0 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c7c939b5d8b2a8e2d7d72bf83c031005e93cd3fe Log: Bug doesn't exists in any release Changed paths: M NEWS The fix for number_format()'s binary safty is reverted only in 5.4.5 branch https://github.com/php/php-src/commits/PHP-5.4.5 Diff: diff --git a/NEWS b/NEWS index 8dc740c..9da5717 100644 --- a/NEWS +++ b/NEWS @@ -3,8 +3,6 @@ PHP NEWS ?? ??? 2012, PHP 5.4.6 - Core: - . Fixed bug in number_format() when the number was not finite. See pull - request #134. (Reeze Xia) . Fixed bug #62565 (Crashes due non-initialized internal properties_table). (Felipe) @@ -17,7 +15,7 @@ PHP NEWS - Fileinfo: . Fixed bug #61964 (finfo_open with directory causes invalid free). - (reeze@gmail.com) + (reeze@gmail.com) - Intl: . Fixed bug #62564 (Extending MessageFormatter and adding property causes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php Ah you mean release. 5.4.5 is the latest version. ignore me
[PHP-CVS] 回复： [PHP-CVS] com php-src: Improve JSON error handling: NEWS ext/json/json.c ext/json/tests/003.phpt ext/json/tests/004.phpt ext/json/tests/bug54058.phpt ext/json/tests/bug61537.phpt ext/jso
-- reeze | reeze.cn 在 2012年6月27日星期三，下午6:21，Nikita Popov 写道： Commit: 4662151ea7d7b6920d115cf2a2d6e9d4232727a3 Author: Nikita Popov ni...@php.net (mailto:ni...@php.net) Wed, 27 Jun 2012 12:19:41 +0200 Parents: bc0972e78daec4d7b7adccb7116f8ded2ca5044d Branches: PHP-5.3 PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=4662151ea7d7b6920d115cf2a2d6e9d4232727a3 Log: Improve JSON error handling json_encode() no longer throws warnings. Instead only the error code for json_last_error() is set. As it is hard to debug the error from just an error code an optional $as_string parameter was added to json_last_error(), which returns an error message instead of an error code. Changed paths: M NEWS M ext/json/json.c How about update json_last_error 's proto comment? :) M ext/json/tests/003.phpt M ext/json/tests/004.phpt M ext/json/tests/bug54058.phpt M ext/json/tests/bug61537.phpt M ext/json/tests/inf_nan_error.phpt M ext/json/tests/json_encode_basic.phpt M ext/json/tests/unsupported_type_error.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php 附件： - diff_4662151ea7d7b6920d115cf2a2d6e9d4232727a3.txt
[PHP-CVS] 回复： [PHP-CVS] 回复： com php-src: Implemented FR #61602 Allow access to name of constant used as
Hi Laruence,
I'v sent another PR https://github.com/php/php-src/pull/88 to improve the
previous commit :)
Thanks.
--
reeze | reeze.cn
在 2012年5月23日星期三，下午1:29，Laruence 写道：
Hi:
I am going to revert this , please make a new PR after you fix this. :)
thanks
On Wed, May 23, 2012 at 11:55 AM, Reeze reeze@gmail.com
(mailto:reeze@gmail.com) wrote:
Hi, Nuno，
Thanks for reminding， I've attached a patch for this. could you take a look?
GET_REFLECTION_OBJECT_PTR used widely, but define yet another macro seems
useless, so I expand the macro.
Thanks.
Best
--
reeze | reeze.cn
在 2012年5月23日星期三，上午2:50，Nuno Lopes 写道：
Commit: 054f3e3ce5af13c2c3a6ccd54f7dc3e2f6cd4f74
Author: reeze reeze@gmail.com (mailto:reeze@gmail.com) Tue, 3 Apr
2012 13:47:16 +0800
Parents: 3bf53aa911e1e2128a11aee45c126000635de006
Branches: PHP-5.4 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=054f3e3ce5af13c2c3a6ccd54f7dc3e2f6cd4f74
Log:
Implemented FR #61602 Allow access to name of constant used as default value
Bugs:
https://bugs.php.net/61602
diff --git a/ext/reflection/php_reflection.c
b/ext/reflection/php_reflection.c
index 1cf65ce..ef1ed7e 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -1457,6 +1457,57 @@ static void
_reflection_export(INTERNAL_FUNCTION_PARAMETERS, zend_class_entry *c
}
/* }}} */
+/* {{{ _reflection_param_get_default_param */
+static parameter_reference
*_reflection_param_get_default_param(INTERNAL_FUNCTION_PARAMETERS)
+{
+ reflection_object *intern;
+ parameter_reference *param;
+
+ if (zend_parse_parameters_none() == FAILURE) {
+ return NULL;
+ }
+
+ GET_REFLECTION_OBJECT_PTR(param);
You cannot use GET_REFLECTION_OBJECT_PTR here because it has a
'return;' statement (i.e., without a return value). While gcc accepts
this (but issues a warning), it's considered an error in C99, and it
breaks the build with other compilers.
Please either fix it or revert the patch.
Nuno
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
Laruence Xinchen Hui
http://www.laruence.com/
Re: [PHP-CVS] com php-src: Updated NEWS w.r.t to ext/intl changes: NEWS
-- Reeze Sent with sparrow On 2012年5月23日Wednesday at 19:35, Gustavo André dos Santos Lopes wrote: Commit: 1c19146f464017a28779446ee0972d1956809d25 Author: Gustavo André dos Santos Lopes cataphr...@php.net Wed, 23 May 2012 13:35:11 +0200 Parents: 1eff3b01b8e2fdeadc9640ae1a19b8330277ccc5 Branches: PHP-5.3 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=1c19146f464017a28779446ee0972d1956809d25 Log: Updated NEWS w.r.t to ext/intl changes Changed paths: M NEWS Diff: diff --git a/NEWS b/NEWS index 7542724..169366d 100644 --- a/NEWS +++ b/NEWS @@ -6,11 +6,19 @@ PHP NEWS - FPM . Fixed bug #61045 (fpm don't send error log to fastcgi clients). (fat) - . Fixed bug #61835 (php-fpm is not allowed to run as root). (fat) + . Fixed bug #61835 (php-fpm is not allowed to run as root). (fat) . Fixed bug #61295 (php-fpm should not fail with commented 'user' for non-root start). (fat) . Fixed bug #61026 (FPM pools can listen on the same address). (fat) +- Intl + . Fixed bug #62082 (grapheme_extract() memory leaks). (Gustavo) It's bug #62083 :) + . Fixed bug #62082 (Memory corruption in internal get_icu_disp_value_src_php + function). (Gustavo) + . Fixed bug #62081 (IntlDateFormatter constructor leaks memory when called + twice). (Gustavo) + . Fixed bug #62070 (Collator::getSortKey() returns garbage). (Gustavo) + - XML Writer: . Fixed bug #62064 (memory leak in the XML Writer module). (jean-pierre dot lozi at lip6 dot fr) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] 回复： com php-src: Implemented FR #61602 Allow access to name of constant used as
Hi, Nuno，
Thanks for reminding， I've attached a patch for this. could you take a look?
GET_REFLECTION_OBJECT_PTR used widely, but define yet another macro seems
useless, so I expand the macro.
Thanks.
Best
--
reeze | reeze.cn
在 2012年5月23日星期三，上午2:50，Nuno Lopes 写道：
Commit: 054f3e3ce5af13c2c3a6ccd54f7dc3e2f6cd4f74
Author: reeze reeze@gmail.com (mailto:reeze@gmail.com) Tue, 3 Apr
2012 13:47:16 +0800
Parents: 3bf53aa911e1e2128a11aee45c126000635de006
Branches: PHP-5.4 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=054f3e3ce5af13c2c3a6ccd54f7dc3e2f6cd4f74
Log:
Implemented FR #61602 Allow access to name of constant used as default value
Bugs:
https://bugs.php.net/61602
diff --git a/ext/reflection/php_reflection.c
b/ext/reflection/php_reflection.c
index 1cf65ce..ef1ed7e 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -1457,6 +1457,57 @@ static void
_reflection_export(INTERNAL_FUNCTION_PARAMETERS, zend_class_entry *c
}
/* }}} */
+/* {{{ _reflection_param_get_default_param */
+static parameter_reference
*_reflection_param_get_default_param(INTERNAL_FUNCTION_PARAMETERS)
+{
+ reflection_object *intern;
+ parameter_reference *param;
+
+ if (zend_parse_parameters_none() == FAILURE) {
+ return NULL;
+ }
+
+ GET_REFLECTION_OBJECT_PTR(param);
You cannot use GET_REFLECTION_OBJECT_PTR here because it has a
'return;' statement (i.e., without a return value). While gcc accepts
this (but issues a warning), it's considered an error in C99, and it
breaks the build with other compilers.
Please either fix it or revert the patch.
Nuno
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
