iliaa Wed May 20 15:05:36 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
MFB: Re-introduce the Matteo's patch and combine default & text handling
since they appear to be the same irregardless on notes inside sql
Ilia Alshanetsky ha scritto:
> iliaa Tue May 19 19:15:18 2009 UTC
>
> Modified files: (Branch: PHP_5_3)
> /php-src/ext/pdo_sqlite sqlite_statement.c
> Log:
> The \0 removal is only needed prior to 3.4.0
I hate to do this (and as a php-src newbie I'm a bit afraid
iliaa Tue May 19 19:15:18 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
The \0 removal is only needed prior to 3.4.0
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_sqlite/sqlite_statement.c?r1=1.18.2.4.2.3.2.8&
it looks like in recent version of sqlite3 the behavior had changed
some what. I am going to check which version of sqlite3 had followed
the old behavior and put the code into the appropriate define block.
Ilia Alshanetsky
On 19-May-09, at 1:33 PM, Matteo Beccati wrote:
Ilia Alshanetsk
The code should be (*len)--; then the result is as desired, I'll adjust.
Ilia Alshanetsky
On 19-May-09, at 1:33 PM, Matteo Beccati wrote:
Ilia Alshanetsky ha scritto:
*len is a pointer to an integer, that is being decremented to
reduce the
overall length of the string to "remove" the NU
Ilia Alshanetsky ha scritto:
> *len is a pointer to an integer, that is being decremented to reduce the
> overall length of the string to "remove" the NUL terminator. If you
> remove the operation you'll end up with 2 NULs at the end of the string.
As I said, I coulndn't find any reference to the
*len is a pointer to an integer, that is being decremented to reduce
the overall length of the string to "remove" the NUL terminator. If
you remove the operation you'll end up with 2 NULs at the end of the
string.
Ilia Alshanetsky
On 19-May-09, at 12:58 PM, Matteo Beccati wrote:
Hi I
Hi Ilia,
> + if (*len) {
> + /* sqlite3.h says "the NUL terminator is
> included in the byte count for TEXT values" */
> + *len--; /* do not remove this, even though it
> generates a warning */
> + }
iliaa Tue May 19 16:14:13 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
Revert faulty warning fix
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_sqlite/sqlite_statement.c?r1=1.18.2.4.2.3.2.7&r2=1.18.2.4.2.3.2.8
indeyetsWed Apr 1 14:35:24 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
MFH: reverted previous patch, using explicit cast instead
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_sqlite/sqlite_statement.c?r1
indeyetsWed Apr 1 11:32:14 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
MFH: const pointer was used in non-const context
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_sqlite/sqlite_statement.c?r1=1.18.2.4
scottmacFri Mar 7 16:58:55 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
Fixed bug #41135 (When binding as binary data use sqlite3_bind_blob() to stop
errors with null bytes.)
Fixed bug #42443 (Bind intege
12 matches
Mail list logo
