Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

2008-08-16 Thread Antony Dovgal 

There is something wrong with this SKIPIF section.

On 15.08.2008 23:01, Pierre-Alain Joye wrote:

http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt?view=markuprev=1.1
Index: php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
+++ php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
--TEST--
Test popen() and pclose function: error conditions

--SKIPIF--
?php
if(substr(PHP_OS, 0, 3) != 'WIN'  PHP_DEBUG)) die(skip Not Valid for Linux);


There is a parse error in this line (see ))).
Also I don't get why it's not valid only for debug builds.
And btw Windows and Linux are not the only two systems we support.


if(!PHP_DEBUG) die(skip Not Valid for release builds);
if (!(strpos('MSVC9', $inf) || strpos('MSVC8', $inf))) die(skip Not Valid for build 
done with VC  8);


And this is the weirdest part of all. 
Where does this $inf come from?


--
Wbr, 
Antony Dovgal


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

2008-08-16 Thread Pierre Joye 
hi Tony,

On Sat, Aug 16, 2008 at 12:28 PM, Antony Dovgal [EMAIL PROTECTED] wrote:
 There is something wrong with this SKIPIF section.

 On 15.08.2008 23:01, Pierre-Alain Joye wrote:


 http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt?view=markuprev=1.1
 Index: php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
 +++ php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
 --TEST--
 Test popen() and pclose function: error conditions

 --SKIPIF--
 ?php
 if(substr(PHP_OS, 0, 3) != 'WIN'  PHP_DEBUG)) die(skip Not Valid for
 Linux);

 There is a parse error in this line (see ))).

Sorry, commited from the wrong tree, fixed now.

 Also I don't get why it's not valid only for debug builds.

We have extra warning in debug mode on Windows (CRT warning printed
out as warning), see dummy_invalid_parameter_handler in main/main.c

 And btw Windows and Linux are not the only two systems we support.

And? These tests are for windows and also improve portability across
OSes. Are you asking me to work on other OSes as well?

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

2008-08-16 Thread Antony Dovgal 

On 16.08.2008 14:57, Pierre Joye wrote:

And btw Windows and Linux are not the only two systems we support.


And? These tests are for windows and also improve portability across
OSes. Are you asking me to work on other OSes as well?


And saying not valid for Linux when running the test on FreeBSD is kinda odd.
Hence I'd recommend using for windows only instead of not for linux.

--
Wbr, 
Antony Dovgal


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

2008-08-16 Thread Hannes Magnusson 
On Sat, Aug 16, 2008 at 12:57, Pierre Joye [EMAIL PROTECTED] wrote:
 if(substr(PHP_OS, 0, 3) != 'WIN'  PHP_DEBUG)) die(skip Not Valid for
 Linux);
 And btw Windows and Linux are not the only two systems we support.

 And? These tests are for windows and also improve portability across
 OSes. Are you asking me to work on other OSes as well?

No. But If I run this test on BSD, AIX.. I will get SKIP: Not valid
for linux, wtf? I'm not on Linux... :)

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

2008-08-15 Thread Pierre-Alain Joye 
pajoye  Fri Aug 15 19:01:42 2008 UTC

  Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/file
popen_pclose_error-win32-debug.phpt 

  Modified files:  
/php-src/ext/standard/tests/filepopen_pclose_error-win32.phpt 
  Log:
  -MFH:
   - fix test
   - add debug build mode (crt outputs callback for invalid parameters)
  
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt?r1=1.1.2.1.2.1r2=1.1.2.1.2.2diff_format=u
Index: php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt
diff -u 
php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt:1.1.2.1.2.1 
php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt:1.1.2.1.2.2
--- php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt:1.1.2.1.2.1   
Mon Nov  5 17:43:21 2007
+++ php-src/ext/standard/tests/file/popen_pclose_error-win32.phpt   Fri Aug 
15 19:01:42 2008
@@ -3,8 +3,8 @@
 
 --SKIPIF--
 ?php
-if(substr(PHP_OS, 0, 3) != 'WIN' )
-  die(skip Not Valid for Linux);
+if(substr(PHP_OS, 0, 3) != 'WIN') die(skip Not Valid for Linux);
+if(PHP_DEBUG) die(skip Not Valid for debug builds);
 ?
 
 --FILE--

http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt?view=markuprev=1.1
Index: php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
+++ php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt
--TEST--
Test popen() and pclose function: error conditions

--SKIPIF--
?php
if(substr(PHP_OS, 0, 3) != 'WIN'  PHP_DEBUG)) die(skip Not Valid for Linux);
if(!PHP_DEBUG) die(skip Not Valid for release builds);
if (!(strpos('MSVC9', $inf) || strpos('MSVC8', $inf))) die(skip Not Valid for 
build done with VC  8);
?

--FILE--
?php
/*
 * Prototype: resource popen ( string command, string mode )
 * Description: Opens process file pointer.

 * Prototype: int pclose ( resource handle );
 * Description: Closes process file pointer.
 */
$file_path = dirname(__FILE__);
echo *** Testing for error conditions ***\n;
var_dump( popen() );  // Zero Arguments
var_dump( popen(abc.txt) );   // Single Argument
var_dump( popen(abc.txt, rw) );   // Invalid mode Argument
var_dump( pclose() );
$file_handle = fopen($file_path./popen.tmp, w);
var_dump( pclose($file_handle, $file_handle) );
pclose($file_handle);
var_dump( pclose(1) );
echo \n--- Done ---;
?
--CLEAN--
?php
$file_path = dirname(__FILE__);
unlink($file_path./popen.tmp);
?
--EXPECTF--
*** Testing for error conditions ***

Warning: popen() expects exactly 2 parameters, 0 given in %s on line %d
NULL

Warning: popen() expects exactly 2 parameters, 1 given in %s on line %d
NULL

Warning: Invalid parameter detected in CRT function '_fdopen' (%s:%d) in %s on 
line %d

Warning: popen(abc.txt,rw): Invalid argument in %s on line %d
bool(false)

Warning: pclose() expects exactly 1 parameter, 0 given in %s on line %d
bool(false)

Warning: pclose() expects exactly 1 parameter, 2 given in %s on line %d
bool(false)

Warning: pclose() expects parameter 1 to be resource, integer given in %s on 
line %d
bool(false)

--- Done ---'abc.txt' is not recognized as an internal or external command,
operable program or batch file.



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php