Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
Hi Stas, this bug was really mysqli@mysqlnd. No other tests test this, this is why we were not able to catch this before. Therefore, it should be enabled also for libmysql, because it checks right behavior. It's about regression testing, and if libmysql fails someday on this, we should be

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 12:28 AM, Andrey Hristov wrote: this bug was really mysqli@mysqlnd. No other tests test this, this is why we were not able to catch this before. Therefore, it should be enabled also for libmysql, because it checks right behavior. It's about regression testing, and if libmysql

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:38 AM, Stas Malyshev wrote: Hi! On 9/6/11 12:28 AM, Andrey Hristov wrote: this bug was really mysqli@mysqlnd. No other tests test this, this is why we were not able to catch this before. Therefore, it should be enabled also for libmysql, because it checks right behavior. It's

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper around mysql_num_rows(), and this is what we test.

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-05 Thread Stanislav Malyshev
stas Tue, 06 Sep 2011 05:13:47 + Revision: http://svn.php.net/viewvc?view=revisionrevision=316203 Log: this tests looks mysqlnd only Changed paths: U php/php-src/branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt U