Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/main/php_ini.c trunk/ext/standard/basic_functions.c

2011-09-26 Thread Pierre Joye
yes, another commit has been done at the same time by mistake, I added a comment about that in the respective bug report. Cheers, On Mon, Sep 26, 2011 at 2:30 PM, Hannes Magnusson wrote: > On Mon, Sep 26, 2011 at 10:49, Pierre Joye wrote: >> pajoye                                   Mon, 26 Sep

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/main/php_ini.c trunk/ext/standard/basic_functions.c

2011-09-26 Thread Hannes Magnusson
On Mon, Sep 26, 2011 at 10:49, Pierre Joye wrote: > pajoye                                   Mon, 26 Sep 2011 08:49:28 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=317306 > > Log: > - be sure to check if the var ha not been removed between the two calls > > Changed paths: >

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/main/php_ini.c trunk/ext/standard/basic_functions.c

2011-09-26 Thread Pierre Joye
pajoye Mon, 26 Sep 2011 08:49:28 + Revision: http://svn.php.net/viewvc?view=revision&revision=317306 Log: - be sure to check if the var ha not been removed between the two calls Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions

[PHP-CVS] svn: /php/php-src/branches/ PHP_5_3/ext/standard/basic_functions.c PHP_5_4/ext/standard/basic_functions.c

2011-09-26 Thread Pierre Joye
pajoye Mon, 26 Sep 2011 08:36:33 + Revision: http://svn.php.net/viewvc?view=revision&revision=317304 Log: - Fix bug #55622, better fix for this issue, old fix can break if sizeof(size_t) > sizeof(int) like on sparc Bug: https://bugs.php.net/55622 (error get

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-09-06 Thread Pierre Joye
pajoye Tue, 06 Sep 2011 17:41:08 + Revision: http://svn.php.net/viewvc?view=revision&revision=316285 Log: - fix #55622, mem corruption on large input Bug: https://bugs.php.net/55622 (error getting bug information) Changed paths: U php/php-src/br

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Laruence
Hi: This was what it was before I edit it. I also don't very sure about it. and after tracking, I found this statements was introduced in -r243300 diff: http://svn.php.net/viewvc/php/php-src/trunk/ext/standard/basic_functions.c?r1=243098&r2=243300 looks like it was wrong in the rewr

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Xinchen Hui
laruence Mon, 08 Aug 2011 00:47:40 + Revision: http://svn.php.net/viewvc?view=revision&revision=314452 Log: Remove no sense statements Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c U php/php-src/branches/PHP_5_4/ext/s

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Stas Malyshev
Hi! On 8/7/11 7:25 AM, Xinchen Hui wrote: laruence Sun, 07 Aug 2011 14:25:30 + memset(opts, 0, count * sizeof(opt_struct)); + if (!opts) { + RETURN_FALSE; + } + I'm not sure I understand this

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Xinchen Hui
laruence Sun, 07 Aug 2011 14:25:30 + Revision: http://svn.php.net/viewvc?view=revision&revision=314425 Log: revert -r314422 No need to check erealloc's return Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c U php/php-s

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Antony Dovgal
On 08/07/2011 06:16 PM, Laruence wrote: Hi: oh, sorry for mis-understanding, I will revert these changes. You can leave it as it is now, I believe. Just don't waste your time on such checks. -- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP -- PHP CVS Mailing L

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Pierre Joye
We however have plenty of realloc calls without any checks. Cheers, On Sun, Aug 7, 2011 at 3:50 PM, Antony Dovgal wrote: > On 08/07/2011 05:19 PM, Xinchen Hui wrote: >> >>                opts = (opt_struct *) erealloc(opts, sizeof(opt_struct) * >> (len + count + 1)); >> +               if (!opts

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Antony Dovgal
On 08/07/2011 05:19 PM, Xinchen Hui wrote: opts = (opt_struct *) erealloc(opts, sizeof(opt_struct) * (len + count + 1)); + if (!opts) { + RETURN_FALSE; + } + erealloc() cannot return NULL whatever happens and if you look at the

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-08-07 Thread Xinchen Hui
laruence Sun, 07 Aug 2011 13:19:04 + Revision: http://svn.php.net/viewvc?view=revision&revision=314422 Log: Fixed bug that may dereferenced NULL pointer before checking Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c

2011-06-23 Thread Felipe Pena
felipe Thu, 23 Jun 2011 21:48:15 + Revision: http://svn.php.net/viewvc?view=revision&revision=312417 Log: - Fixed crash in error_log() (strlen(NULL)) reported by: shm, Maksymilian Arciemowicz Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2011-06-11 Thread Felipe Pena
felipe Sun, 12 Jun 2011 02:47:48 + Revision: http://svn.php.net/viewvc?view=revision&revision=312079 Log: - Fixed bug #54680 (missing TRACK_VARS_SERVER check) Bug: http://bugs.php.net/54680 (Open) missing TRACK_VARS_SERVER Changed paths: U php/p

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c http.c php_http.h url.h

2011-01-12 Thread Stanislav Malyshev
stas Thu, 13 Jan 2011 07:27:46 + Revision: http://svn.php.net/viewvc?view=revision&revision=307432 Log: revert non-BC change in 5.3 Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c U php/php-src/branches/PHP_5_3/ext/

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c http.c php_http.h url.h

2011-01-10 Thread Pierre Joye
hi, Yes, it breaks the ABI, please revert this patch. Maybe another implementation by adding a new function could help, but I'm not sure we need that now in 5.3 either. Cheers, On Mon, Jan 10, 2011 at 5:35 AM, Adam Harvey wrote: > On 8 January 2011 10:34, Rui Hirokawa wrote: >> hirokawa      

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c http.c php_http.h url.h

2011-01-09 Thread Kalle Sommer Nielsen
Hi Adam 2011/1/10 Adam Harvey : > On 8 January 2011 10:34, Rui Hirokawa wrote: >> hirokawa                                 Sat, 08 Jan 2011 02:34:33 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=307248 >> >> Log: >> MFH: added an option to http_build_query for RFC-3986 >>

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c http.c php_http.h url.h

2011-01-09 Thread Adam Harvey
On 8 January 2011 10:34, Rui Hirokawa wrote: > hirokawa                                 Sat, 08 Jan 2011 02:34:33 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=307248 > > Log: > MFH: added an option to http_build_query for RFC-3986 > based url-encoding. Somebody should doub

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c http.c php_http.h url.h

2011-01-07 Thread Rui Hirokawa
hirokawa Sat, 08 Jan 2011 02:34:33 + Revision: http://svn.php.net/viewvc?view=revision&revision=307248 Log: MFH: added an option to http_build_query for RFC-3986 based url-encoding. Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functio

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c

2010-08-17 Thread Kalle Sommer Nielsen
kalleTue, 17 Aug 2010 13:34:11 + Revision: http://svn.php.net/viewvc?view=revision&revision=302389 Log: Fix my fix for arginfo, trunk patch will follow shortly Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c Modified: ph

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c

2010-08-16 Thread Kalle Sommer Nielsen
kalleMon, 16 Aug 2010 21:59:42 + Revision: http://svn.php.net/viewvc?view=revision&revision=302377 Log: Fix arginfo for copy(), see r302376 for more info Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c Modified: php/php-

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_3/ext/standard/tests/general_functions/bug50690.phpt trunk/ext/standard/basic_functions.c trunk/ext/standard

2010-01-24 Thread Pierre Joye
pajoye Sun, 24 Jan 2010 13:49:47 + Revision: http://svn.php.net/viewvc?view=revision&revision=293902 Log: - #50690, putenv does assign value when their length is one char Bug: http://bugs.php.net/50690 (Assigned) putenv() does not assign values to env. vars

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c dns.c php_dns.h

2010-01-07 Thread Matteo Beccati
Il 07/01/2010 12:12, Jani Taskinen ha scritto: On 01/07/2010 01:02 PM, Sebastian Bergmann wrote: sebastian Thu, 07 Jan 2010 11:02:39 + Revision: http://svn.php.net/viewvc?view=revision&revision=293211 Log: sed -i "s#1997-2008#1997-2010#g" **/*.c **/*.h Bug: http://bugs.php.net/1997 (Bogus

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c dns.c php_dns.h

2010-01-07 Thread Kalle Sommer Nielsen
> Why is that commit script picking these without word 'bug' in the commit > message? Sebastian spammed a few reports now unintentionally.. I guess its because the commit script also considers #\d as a bug report. Not just "bug #\d" -- regrads, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Ma

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c dns.c php_dns.h

2010-01-07 Thread Jani Taskinen
On 01/07/2010 01:02 PM, Sebastian Bergmann wrote: sebastianThu, 07 Jan 2010 11:02:39 + Revision: http://svn.php.net/viewvc?view=revision&revision=293211 Log: sed -i "s#1997-2008#1997-2010#g" **/*.c **/*.h Bug: http://bugs.php.net/1997 (Bogus) Compilation Pro

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/standard/ basic_functions.c dns.c php_dns.h

2010-01-07 Thread Sebastian Bergmann
sebastianThu, 07 Jan 2010 11:02:39 + Revision: http://svn.php.net/viewvc?view=revision&revision=293211 Log: sed -i "s#1997-2008#1997-2010#g" **/*.c **/*.h Bug: http://bugs.php.net/1997 (Bogus) Compilation Problems Changed paths: U php/php-src/bran

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c

2009-08-12 Thread Scott MacVicar
scottmac Wed, 12 Aug 2009 09:18:41 + Revision: http://svn.php.net/viewvc?view=revision&revision=287151 Log: Fix build on platforms where crypt isn't always available Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c U php