Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
I overlooked one more error; I wrote --SKIP-- everywhere --SKIPIF-- is expected :/ I committed the fix and now it should be ok ;) Moriyoshi On 2008/07/25, at 19:47, Antony Dovgal wrote: On 25.07.2008 14:36, Moriyoshi Koizumi wrote: ini_set() returns the previously set value, so that's fine. But I eventually noticed that the logic is inversed - "or" should be "and" actually. Thanks for the heads-up. The tests still fail, though. Even with zend multibyte enabled. -- ext/mbstring/tests/zend_multibyte-02.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-03.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-04.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-05.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-06.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-07.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-08.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-09.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
On 25.07.2008 14:36, Moriyoshi Koizumi wrote: ini_set() returns the previously set value, so that's fine. But I eventually noticed that the logic is inversed - "or" should be "and" actually. Thanks for the heads-up. The tests still fail, though. Even with zend multibyte enabled. -- ext/mbstring/tests/zend_multibyte-02.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-03.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-04.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-05.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-06.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-07.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-08.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-09.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
On 2008/07/25, at 19:11, Antony Dovgal wrote: On 25.07.2008 13:51, Moriyoshi Koizumi wrote: It's probable that segfaults occurred in the test 10, 11 and 12. would you mind posting it if that's the case? No, there are no segfaults and valgrind keeps silence, too. It seems I found it: --SKIP-- Note that "***" instead of SJIS. ini_set() returns the previously set value, so that's fine. But I eventually noticed that the logic is inversed - "or" should be "and" actually. Thanks for the heads-up. Moriyoshi -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
On 25.07.2008 13:51, Moriyoshi Koizumi wrote: It's probable that segfaults occurred in the test 10, 11 and 12. would you mind posting it if that's the case? No, there are no segfaults and valgrind keeps silence, too. It seems I found it: --SKIP-- Note that "***" instead of SJIS. -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
It's probable that segfaults occurred in the test 10, 11 and 12. would you mind posting it if that's the case? Moriyoshi On 2008/07/25, at 18:51, Antony Dovgal wrote: On 25.07.2008 13:29, Moriyoshi Koizumi wrote: Can you send me the test results? I tested on PPC and i386, and they went well without problems. I'm testing on Linux 64bit. Here are the diffs. -- ext/mbstring/tests/zend_multibyte-02.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-03.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-04.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-05.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-06.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-07.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-08.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-09.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-10.diff -- 001+ 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 3 -- ext/mbstring/tests/zend_multibyte-11.diff -- 001+ 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 3 -- ext/mbstring/tests/zend_multibyte-12.diff -- 001+ 1 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 4 -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
On 25.07.2008 13:29, Moriyoshi Koizumi wrote: Can you send me the test results? I tested on PPC and i386, and they went well without problems. I'm testing on Linux 64bit. Here are the diffs. -- ext/mbstring/tests/zend_multibyte-02.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-03.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-04.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-05.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-06.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-07.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-08.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-09.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-10.diff -- 001+ 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 3 -- ext/mbstring/tests/zend_multibyte-11.diff -- 001+ 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 3 -- ext/mbstring/tests/zend_multibyte-12.diff -- 001+ 1 001- Fatal error: Encoding declaration pragma must be the very first statement in the script in %s on line 4 -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
Can you send me the test results? I tested on PPC and i386, and they went well without problems. Moriyoshi On 2008/07/25, at 16:09, Antony Dovgal wrote: On 25.07.2008 02:21, Moriyoshi Koizumi wrote: moriyoshi Thu Jul 24 22:21:42 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/mbstring/tests zend_multibyte-01.phpt zend_multibyte-02.phpt zend_multibyte-03.phpt zend_multibyte-04.phpt zend_multibyte-05.phpt zend_multibyte-06.phpt zend_multibyte-07.phpt zend_multibyte-08.phpt zend_multibyte-09.phpt zend_multibyte-10.phpt zend_multibyte-11.phpt zend_multibyte-12.phpt All of these tests fail (except for the first one). -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
On 25.07.2008 02:21, Moriyoshi Koizumi wrote: moriyoshi Thu Jul 24 22:21:42 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/mbstring/tests zend_multibyte-01.phpt zend_multibyte-02.phpt zend_multibyte-03.phpt zend_multibyte-04.phpt zend_multibyte-05.phpt zend_multibyte-06.phpt zend_multibyte-07.phpt zend_multibyte-08.phpt zend_multibyte-09.phpt zend_multibyte-10.phpt zend_multibyte-11.phpt zend_multibyte-12.phpt All of these tests fail (except for the first one). -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
