Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-14 Thread Greg Beaver
Hannes Magnusson wrote: > On Thu, Feb 5, 2009 at 22:32, Greg Beaver wrote: > >> I really don't give a crap. Change it if you want, I was merging >> *existing* code in PHP_5_3 to HEAD, not adding new stuff. >> > > Which is exactly why we have major syncing issues. > > HEAD is for developme

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-13 Thread Hannes Magnusson
On Thu, Feb 5, 2009 at 22:32, Greg Beaver wrote: > I really don't give a crap. Change it if you want, I was merging > *existing* code in PHP_5_3 to HEAD, not adding new stuff. Which is exactly why we have major syncing issues. HEAD is for development. Stuff should be merged *to* 5.3, not *from*

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Greg Beaver
Christopher Jones wrote: > It's no big deal. It caught my eye originally too, so I'll make the > changes. Thanks Chris -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Pierre Joye
On Thu, Feb 5, 2009 at 10:32 PM, Greg Beaver wrote: > I sure am glad we worked this out, can you imagine the horrors? > Security experts would be blogging endlessly about those periods I added > back into the error messages. What a disgrace to the language I am. In > the future, I'll be really

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Christopher Jones
Greg Beaver wrote: Johannes Schlüter wrote: On Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote: Antony Dovgal wrote: On 03.02.2009 22:02, Greg Beaver wrote: - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes", sizeof(php_bz2_filter_

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Greg Beaver
Johannes Schlüter wrote: > On Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote: > >> Antony Dovgal wrote: >> >>> On 03.02.2009 22:02, Greg Beaver wrote: >>> >>> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes", sizeof(php_bz2_filter_

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Johannes Schlüter
On Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote: > Antony Dovgal wrote: > > On 03.02.2009 22:02, Greg Beaver wrote: > > > >> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating > >> %zu bytes", sizeof(php_bz2_filter_data)); > >> + php_error_docref(NULL TSRMLS

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Greg Beaver
Antony Dovgal wrote: > On 03.02.2009 22:02, Greg Beaver wrote: > >> -php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating >> %zu bytes", sizeof(php_bz2_filter_data)); >> +php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating >> %zu bytes.", sizeof(php

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Antony Dovgal
On 03.02.2009 22:02, Greg Beaver wrote: > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating > %zu bytes", sizeof(php_bz2_filter_data)); > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating > %zu bytes.", sizeof(php_bz2_filter_data)); > -

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standardfile.cfilters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c/ext/zlibzlib_filter.c /main php_streams.h /main/streams ca

2006-03-15 Thread Sara Golemon
ick Rethans" <[EMAIL PROTECTED]> To: "Sara Golemon" <[EMAIL PROTECTED]> Cc: "Dmitry Stogov" <[EMAIL PROTECTED]>; Sent: Wednesday, March 15, 2006 12:36 PM Subject: Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standardfile.cfilters.c streamsfuncs.c use

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standardfile.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c/ext/zlib zlib_filter.c /main php_streams.h /main/streams

2006-03-15 Thread Derick Rethans
On Wed, 15 Mar 2006, Derick Rethans wrote: > On Wed, 15 Mar 2006, Sara Golemon wrote: > > > Maybe a silly a question, but have you guys tried 'make clean'? (There are > > some header file changes that might need to propagate to untouched source > > files) I'm not getting these kinds of errors ov

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standardfile.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c/ext/zlib zlib_filter.c /main php_streams.h /main/streams

2006-03-15 Thread Derick Rethans
On Wed, 15 Mar 2006, Sara Golemon wrote: > Maybe a silly a question, but have you guys tried 'make clean'? (There are > some header file changes that might need to propagate to untouched source > files) I'm not getting these kinds of errors over here, but I am getting a > PASS from tests/lang/024

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standardfile.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c/ext/zlib zlib_filter.c /main php_streams.h /main/streams

2006-03-15 Thread Sara Golemon
age - From: "Derick Rethans" <[EMAIL PROTECTED]> To: "Sara Golemon" <[EMAIL PROTECTED]> Cc: "Dmitry Stogov" <[EMAIL PROTECTED]>; Sent: Wednesday, March 15, 2006 7:05 AM Subject: Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/stan

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standard file.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c /ext/zlib zlib_filter.c /main php_streams.h /main/stream

2006-03-15 Thread Derick Rethans
On Wed, 15 Mar 2006, Derick Rethans wrote: > No short script yet... I will try. http://files.derickrethans.nl/uc-stream.tar.gz regards, Derick -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standard file.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c /ext/zlib zlib_filter.c /main php_streams.h /main/stream

2006-03-15 Thread Derick Rethans
On Tue, 14 Mar 2006, Sara Golemon wrote: > > "make test" stops work after this patch, because now fgets() always > returns > > FALSE. > > It is not possible for me to commit ZE patches without testing. > > Please fix this ASAP or revert your patches. > > > Sorry about that. Should look good now (

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standard file.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c /ext/zlib zlib_filter.c /main php_streams.h /main/strea

2006-03-14 Thread Sara Golemon
> "make test" stops work after this patch, because now fgets() always returns > FALSE. > It is not possible for me to commit ZE patches without testing. > Please fix this ASAP or revert your patches. > Sorry about that. Should look good now (though of course there's still stuff to be done with str

RE: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c /ext/standard file.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c /ext/zlib zlib_filter.c /main php_streams.h /main/strea

2006-03-14 Thread Dmitry Stogov
Hi Sara, "make test" stops work after this patch, because now fgets() always returns FALSE. It is not possible for me to commit ZE patches without testing. Please fix this ASAP or revert your patches. Thanks. Dmitry. > -Original Message- > From: Sara Golemon [mailto:[EMAIL PROTECTED] >