Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-28 Thread Antony Dovgal
On 28.05.2009 14:50, Jani Taskinen wrote: > Strike 2 for me.. duh. > > Thanks for fixing that one..a bit too greedy search and replace. :) You're welcome, Jani =) -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubsc

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-28 Thread Jani Taskinen
Strike 2 for me.. duh. Thanks for fixing that one..a bit too greedy search and replace. :) --Jani Antony Dovgal wrote: tony2001Thu May 28 09:45:20 2009 UTC Modified files: /php-src/ext/curl interface.c Log: fix build http://cvs.php.net/viewvc.c

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-20 Thread Antony Dovgal
On 18.05.2009 16:03, Pierre-Alain Joye wrote: > while (*p != NULL) { > - add_next_index_ascii_string(protocol_list, *p, 1); > - *p++; > + add_next_index_ascii_string(protocol_list, *p++, 1); HEAD chokes on this line. Progra

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-18 Thread Jani Taskinen
Pierre Joye wrote: On Mon, May 18, 2009 at 2:07 PM, Jani Taskinen wrote: Can't you do it all in one commit? Now you've littered the log with these half-assed commits, and STILL didn't do everything..there are several "RETURN_FALSE;"'s there where simple "return" is necessary. I do, only misse

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-18 Thread Pierre Joye
On Mon, May 18, 2009 at 2:07 PM, Jani Taskinen wrote: > Can't you do it all in one commit? Now you've littered the log with these > half-assed commits, and STILL didn't do everything..there are several > "RETURN_FALSE;"'s there where simple "return" is necessary. I do, only missed the 2nd one...

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-18 Thread Jani Taskinen
Can't you do it all in one commit? Now you've littered the log with these half-assed commits, and STILL didn't do everything..there are several "RETURN_FALSE;"'s there where simple "return" is necessary. --Jani Pierre-Alain Joye wrote: pajoye Mon May 18 12:03:05 2009 UTC Modified

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2008-11-11 Thread Marcus Boerger
Hello Pierre, Tuesday, November 11, 2008, 12:01:38 PM, you wrote: > hi, > On Tue, Nov 11, 2008 at 11:51 AM, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> This is extremely bad code. We have tons of better APIs to do what you >> want. And besides wouldn't it be better to list all those entries wi

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2008-11-11 Thread Pierre Joye
hi, On Tue, Nov 11, 2008 at 11:51 AM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > This is extremely bad code. We have tons of better APIs to do what you > want. And besides wouldn't it be better to list all those entries with > enabled/disabled as table rows anyway? I do not think adding a 30 li

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2008-11-11 Thread Marcus Boerger
Hello Pierre-Alain, Monday, November 10, 2008, 11:58:44 PM, you wrote: > pajoye Mon Nov 10 22:58:44 2008 UTC > Modified files: > /php-src/ext/curl interface.c > Log: > - make the curl phpinfo more verbose > > http://cvs.php.net/viewvc.cgi/php-src/ext/curl/i

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2008-11-10 Thread Kalle Sommer Nielsen
2008/11/10 Pierre-Alain Joye <[EMAIL PROTECTED]>: > pajoye Mon Nov 10 22:58:44 2008 UTC > > Modified files: >/php-src/ext/curl interface.c > Log: > - make the curl phpinfo more verbose > > http://cvs.php.net/viewvc.cgi/php-src/ext/curl/interface.c?r1=1.128&r2=1.129&diff_format=u >

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2006-12-07 Thread Andrei Zmievski
You can do it much simpler with: convert_to_string_with_converter_ex(current, UG(utf8_conv)); -Andrei On Dec 7, 2006, at 4:46 PM, Ilia Alshanetsky wrote: + + if (Z_TYPE_PP(current) == IS_UNICODE) { + zend_unicode_to_string_ex(UG(utf8_conv), &postv

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2006-12-06 Thread Andrei Zmievski
What about the values? -Andrei On Dec 6, 2006, at 5:06 PM, Ilia Alshanetsky wrote: iliaa Thu Dec 7 01:06:54 2006 UTC Modified files: /php-src/ext/curl interface.c Log: Allow submission of unicode data in utf8 form http://cvs.php.net/viewvc.cgi/php-src/ext/curl/interf

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2006-12-06 Thread Ilia Alshanetsky
Dealing with post fields is tricky, because we need to check is the first char is @, in which case this is a name of a file to upload. As far as regular fields if someone wants to post data then there is issue of encoding, we could post it as utf8. However, the form may not be expecting utf

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2006-12-06 Thread Andrei Zmievski
How're you dealing with POSTFIELDS? It seems you're just converting them to binary strings using runtime encoding. I think we may need to do something smarter than that in case people want to post Unicode content. -Andrei On Dec 6, 2006, at 9:52 AM, Ilia Alshanetsky wrote: iliaa W

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2005-01-06 Thread Joe Orton
On Wed, Jan 05, 2005 at 08:30:57PM -0800, Andi Gutmans wrote: > Isn't the compiler supposed to take care of that? curl_formadd takes a varargs array so the compiler is completely ignorant about what types should be used unfortunately :( joe -- PHP CVS Mailing List (http://www.php.net/) To unsub

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2005-01-05 Thread Andi Gutmans
Isn't the compiler supposed to take care of that? Andi At 09:33 PM 1/5/2005 +, Joe Orton wrote: jorton Wed Jan 5 16:33:57 2005 EDT Modified files: /php-src/ext/curl interface.c Log: Fix #31413: curl POSTFIELDS usage on 64-bit platforms. http://cvs.php.net/diff.php/php-src/

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2004-03-12 Thread Sterling Hughes
not a good fix, use IS_STRING to test. -sterling On Mar 12, 2004, at 11:08 AM, John Coggeshall wrote: john Fri Mar 12 11:08:11 2004 EDT Modified files: /php-src/ext/curl interface.c Log: Fixed a crash which happens if your READFUNCTION callback doesn't actually return a string as p

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c multi.c php_curl.h

2004-03-10 Thread Sterling Hughes
+ zend_llist_init(&(*mh).easyh, sizeof(zval *), (llist_dtor_func_t) ZVAL_PTR_DTOR, 0); + why not &mh->easyh ? -sterling ZEND_REGISTER_RESOURCE(return_value, mh, le_curl_multi_handle); } /* }}} */ @@ -86,7 +88,9 @@ _php_curl_cleanup_handle(ch); ch->uses++; - +