Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/zlib/zlib.c trunk/ext/zlib/zlib.c
On 3/7/12 12:51 AM, Gustavo André dos Santos Lopes wrote: cataphract Wed, 07 Mar 2012 08:51:30 + Revision: http://svn.php.net/viewvc?view=revisionrevision=323988 Log: - Tentative fix for bug #61306. #cjones: Will update NEWS when confirmed it fixes the problem. Bug: https://bugs.php.net/61306 (Assigned) Segfault at end of request Changed paths: U php/php-src/branches/PHP_5_4/ext/zlib/zlib.c U php/php-src/trunk/ext/zlib/zlib.c LOL! My gut feel says that NEWS should be kept in sync whenever code changes. It doesn't seem technically difficult. Keeping NEWS up to date avoids any bus-factor or memory-loss situations. If a bug fix is reverted, it's trivial to update NEWS again. NEWS comments can say attempt to fix or unfinished if there is some temporary uncertainty about a fix. -- Email: christopher.jo...@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/zlib/zlib.c trunk/ext/zlib/zlib.c
On Mar 7, 2012, at 8:15 AM, Christopher Jones wrote: On 3/7/12 12:51 AM, Gustavo André dos Santos Lopes wrote: cataphract Wed, 07 Mar 2012 08:51:30 + Revision: http://svn.php.net/viewvc?view=revisionrevision=323988 Log: - Tentative fix for bug #61306. #cjones: Will update NEWS when confirmed it fixes the problem. Bug: https://bugs.php.net/61306 (Assigned) Segfault at end of request Changed paths: U php/php-src/branches/PHP_5_4/ext/zlib/zlib.c U php/php-src/trunk/ext/zlib/zlib.c LOL! My gut feel says that NEWS should be kept in sync whenever code changes. It doesn't seem technically difficult. Keeping NEWS up to date avoids any bus-factor or memory-loss situations. If a bug fix is reverted, it's trivial to update NEWS again. NEWS comments can say attempt to fix or unfinished if there is some temporary uncertainty about a fix. They don't call him Christopher NEWS Jones for nothin'. :) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php