Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/zlib/zlib.c trunk/ext/zlib/zlib.c

2012-03-07 Thread Philip Olson 

On Mar 7, 2012, at 8:15 AM, Christopher Jones wrote:

> 
> 
> On 3/7/12 12:51 AM, Gustavo André dos Santos Lopes wrote:
>> cataphract   Wed, 07 Mar 2012 08:51:30 +
>> 
>> Revision: http://svn.php.net/viewvc?view=revision&revision=323988
>> 
>> Log:
>> - Tentative fix for bug #61306.
>> #cjones: Will update NEWS when confirmed it fixes the problem.
>> 
>> Bug: https://bugs.php.net/61306 (Assigned) Segfault at end of request
>> 
>> Changed paths:
>> U   php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
>> U   php/php-src/trunk/ext/zlib/zlib.c
>> 
> 
> LOL!  My gut feel says that NEWS should be kept in sync whenever code
> changes.  It doesn't seem technically difficult.  Keeping NEWS up to
> date avoids any bus-factor or memory-loss situations.  If a bug fix is
> reverted, it's trivial to update NEWS again.  NEWS comments can say
> "attempt to fix" or "unfinished" if there is some temporary
> uncertainty about a fix.

They don't call him Christopher NEWS Jones for nothin'. :)
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/zlib/zlib.c trunk/ext/zlib/zlib.c

2012-03-07 Thread Christopher Jones 



On 3/7/12 12:51 AM, Gustavo André dos Santos Lopes wrote:

cataphract   Wed, 07 Mar 2012 08:51:30 +

Revision: http://svn.php.net/viewvc?view=revision&revision=323988

Log:
- Tentative fix for bug #61306.
#cjones: Will update NEWS when confirmed it fixes the problem.

Bug: https://bugs.php.net/61306 (Assigned) Segfault at end of request

Changed paths:
 U   php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
 U   php/php-src/trunk/ext/zlib/zlib.c



LOL!  My gut feel says that NEWS should be kept in sync whenever code
changes.  It doesn't seem technically difficult.  Keeping NEWS up to
date avoids any bus-factor or memory-loss situations.  If a bug fix is
reverted, it's trivial to update NEWS again.  NEWS comments can say
"attempt to fix" or "unfinished" if there is some temporary
uncertainty about a fix.

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ext/zlib/ zlib.c

2011-12-26 Thread Pierre Joye 
ah right, I misread the initial commit. applied.

On Tue, Dec 27, 2011 at 2:29 AM, Stas Malyshev  wrote:
> Hi!
>
>
>> was only present in 5.4 as far as I can tell, see Stas' commit yesterday.
>
>
> Not sure what you mean as I did identical commits to both 5.4 and trunk. I
> also think it might be better to do it on RINIT, just in case.
>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ext/zlib/ zlib.c

2011-12-26 Thread Stas Malyshev 

Hi!


was only present in 5.4 as far as I can tell, see Stas' commit yesterday.


Not sure what you mean as I did identical commits to both 5.4 and trunk. 
I also think it might be better to do it on RINIT, just in case.


--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ext/zlib/ zlib.c

2011-12-26 Thread Pierre Joye 
was only present in 5.4 as far as I can tell, see Stas' commit yesterday.

On Tue, Dec 27, 2011 at 1:01 AM, Hannes Magnusson
 wrote:
> trunk?
>
> -Hannes
>
> On Mon, Dec 26, 2011 at 23:53, Pierre Joye  wrote:
>> pajoye                                   Mon, 26 Dec 2011 22:53:12 +
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=321417
>>
>> Log:
>> - Fix bug #60326, fix crash introduced by initial fix
>>
>> Bug: https://bugs.php.net/60326 (Assigned) ob_gzhander() removed
>>
>> Changed paths:
>>    U   php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
>>
>> Modified: php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
>> ===
>> --- php/php-src/branches/PHP_5_4/ext/zlib/zlib.c        2011-12-26 20:03:46 
>> UTC (rev 321416)
>> +++ php/php-src/branches/PHP_5_4/ext/zlib/zlib.c        2011-12-26 22:53:12 
>> UTC (rev 321417)
>> @@ -938,7 +938,7 @@
>>        REGISTER_LONG_CONSTANT("ZLIB_ENCODING_GZIP", PHP_ZLIB_ENCODING_GZIP, 
>> CONST_CS|CONST_PERSISTENT);
>>        REGISTER_LONG_CONSTANT("ZLIB_ENCODING_DEFLATE", 
>> PHP_ZLIB_ENCODING_DEFLATE, CONST_CS|CONST_PERSISTENT);
>>        REGISTER_INI_ENTRIES();
>> -
>> +       ZLIBG(ob_gzhandler) = NULL;
>>        return SUCCESS;
>>  }
>>  /* }}} */
>> @@ -969,7 +969,6 @@
>>  static PHP_RSHUTDOWN_FUNCTION(zlib)
>>  {
>>        ZLIBG(output_compression) = 0;
>> -
>>        php_zlib_cleanup_ob_gzhandler_mess(TSRMLS_C);
>>
>>     return SUCCESS;
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ext/zlib/ zlib.c

2011-12-26 Thread Hannes Magnusson 
trunk?

-Hannes

On Mon, Dec 26, 2011 at 23:53, Pierre Joye  wrote:
> pajoye                                   Mon, 26 Dec 2011 22:53:12 +
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=321417
>
> Log:
> - Fix bug #60326, fix crash introduced by initial fix
>
> Bug: https://bugs.php.net/60326 (Assigned) ob_gzhander() removed
>
> Changed paths:
>    U   php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
>
> Modified: php/php-src/branches/PHP_5_4/ext/zlib/zlib.c
> ===
> --- php/php-src/branches/PHP_5_4/ext/zlib/zlib.c        2011-12-26 20:03:46 
> UTC (rev 321416)
> +++ php/php-src/branches/PHP_5_4/ext/zlib/zlib.c        2011-12-26 22:53:12 
> UTC (rev 321417)
> @@ -938,7 +938,7 @@
>        REGISTER_LONG_CONSTANT("ZLIB_ENCODING_GZIP", PHP_ZLIB_ENCODING_GZIP, 
> CONST_CS|CONST_PERSISTENT);
>        REGISTER_LONG_CONSTANT("ZLIB_ENCODING_DEFLATE", 
> PHP_ZLIB_ENCODING_DEFLATE, CONST_CS|CONST_PERSISTENT);
>        REGISTER_INI_ENTRIES();
> -
> +       ZLIBG(ob_gzhandler) = NULL;
>        return SUCCESS;
>  }
>  /* }}} */
> @@ -969,7 +969,6 @@
>  static PHP_RSHUTDOWN_FUNCTION(zlib)
>  {
>        ZLIBG(output_compression) = 0;
> -
>        php_zlib_cleanup_ob_gzhandler_mess(TSRMLS_C);
>
>     return SUCCESS;
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php